Review 12.4 Merged

91137[TASK] Avoid "ord(): Providing an empty string is deprecated"

Stefan Bürk CR +2 V +2 Easy +3 −1 updated 10/17/25, 15:49

Commit message

Composing the value is now done in a local variable and only
passed to `ord()` if not empty, otherwise `(int)0` is used
as fallback matching the outcoming of earlier PHP versions [3].

[1] https://wiki.php.net/rfc/deprecations_php_8_5
[2] https://github.com/php/php-src/commit/93676a0425147de239f3758de6b0bce359dccdc6
[3] https://3v4l.org/kLZGe

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 10/17/25, 15:22

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 10/17/25, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86931

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 10/17/25, 15:49

  4. Stefan Bürk merged patch set 2 10/17/25, 15:49