Review main Merged

91143[BUGFIX] Enhance error handling in YamlSource

Josua Vogel CR +2 V +2 Easy +2 −2 updated 10/24/25, 17:18

Commit message

This fix ensures an error message is set, when saving the
form definition fails.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Sven Liebert +1
    • Elias Häußler +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Sven Liebert +1
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2633

Show 48 earlier messages
  1. Josua Vogel uploaded patch set 1 10/17/25, 17:55

  2. core-ci voted on patch set 1 V +1 10/17/25, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86945

  3. Josua Vogel uploaded patch set 2 V +1 10/17/25, 18:08

  4. core-ci voted on patch set 2 V -1 10/17/25, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86947

  5. Josua Vogel uploaded patch set 3 V -1 10/17/25, 18:18

  6. core-ci voted on patch set 3 V -1 10/17/25, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86948

  7. Josua Vogel uploaded patch set 4 V -1 10/17/25, 18:33

  8. core-ci voted on patch set 4 V +1 10/17/25, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86949

  1. Oli Bartsch commented on patch set 4 10/18/25, 08:45

    does this only affect v14?
  2. Sven Liebert commented on patch set 4 10/18/25, 17:35

    Reply

    Looking into source code of v13, should be backported I think.
  3. Josua Vogel updated the commit message in patch set 5 V +1 10/19/25, 17:18

  4. Josua Vogel commented on patch set 5 10/19/25, 17:19

    Reply

    You´re right, issue was created for v14, but it affects v13 too. I updated the commit message
  5. core-ci voted on patch set 5 V +1 10/19/25, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87020

  6. Sven Liebert voted on patch set 5 CR +1 V +1 10/19/25, 17:44

  7. Sven Liebert commented on patch set 5 CR 0 V 0 10/19/25, 17:47

    Could you also check v12? :)
  8. Josua Vogel commented on patch set 5 10/20/25, 05:40

    Reply

    v12 receives security updates (priority bug fixes) only and IMO this isn´t security related
  9. Josua Vogel commented on patch set 5 10/20/25, 05:40

    resolve
  10. Josua Vogel commented on patch set 5 10/20/25, 05:41

    Reply

    resolved
  11. Sven Liebert voted on patch set 5 CR +1 V +1 10/20/25, 06:20

  12. Garvin Hicking commented on patch set 5 10/23/25, 09:16

    YamlSource.php:112

    Shouldn't this say "and can be written"? I feel a bit tingly about the use of "error_clear_last". Could you explain why you would argue that this should be done? Do you have a case where an error message may exist from prior operations? Just clearing an error that might not have been reported might cause issues with other try/catch statements. Just to be on the safe side I would opt to not clear the error, if it's not absolutely needed.
  13. Josua Vogel commented on patch set 5 10/23/25, 09:30

    YamlSource.php:112 Reply

    Maybe there is a error message before :) but I will remove it, to prevent possible side effects
  14. Josua Vogel uploaded patch set 6 CR +1 V +1 10/23/25, 09:37

  15. Josua Vogel commented on patch set 6 10/23/25, 09:39

    YamlSource.php:112 Reply

    Done
  16. core-ci voted on patch set 6 V +1 10/23/25, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87395

  17. Elias Häußler commented on patch set 6 10/23/25, 10:16

    YamlSource.php:111

    I'm not sure if it's a good idea to expose the absolute path to editors. I currently receive a notification that looks like follows: > The form could not be saved: The file "EXT:styleguide/Resources/Private/Forms/allfields.form.yaml" could not be saved: Check that the file /var/www/html/typo3/sysext/styleguide/Resources/Private/Forms/allfields.form.yaml exists and can be written. I think it would be better to drop the path from the exception message, because it's already written to the notification. Something like this (as the resulting notification message) should be enough for editors to recognize that something went wrong: ```suggestion $errorMessage = $error['message'] ?? 'Check that the file exists and can be written.'; ```
  18. Josua Vogel commented on patch set 6 10/23/25, 10:30

    YamlSource.php:111 Reply

    Fix applied.
  19. Josua Vogel commented on patch set 7 V +1 10/23/25, 10:30

    Published edit on patch set 6.
  20. core-ci voted on patch set 7 V +1 10/23/25, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87402

  21. Elias Häußler voted on patch set 7 CR +1 V +1 10/23/25, 10:40

  22. Sven Liebert voted on patch set 7 CR +1 V +1 10/23/25, 11:14

  23. Garvin Hicking commented on patch set 7 CR +1 V +1 10/23/25, 13:58

    Will merge this tomorrow if there are no objections
  24. Garvin Hicking voted on patch set 7 CR +2 V +2 10/24/25, 17:05

  25. Garvin Hicking merged patch set 8 10/24/25, 17:18