Review main Merged

91147[TASK] Remove wrong type declaration in FileConverterTest

Torben Hansen CR +2 V +2 Easy +0 −7 updated 10/18/25, 07:31

Commit message

The type declaration for the `$file` variable in
`FileConverterTest` is wrong because the TypeConverter
may not always return an instance of
`TYPO3\CMS\Extbase\Domain\Model\File`.

The type declaration has therefore been removed as well
as a now superfluous entry in the phpstan baseline.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Torben Hansen uploaded patch set 1 10/18/25, 05:57

  2. core-ci voted on patch set 1 V +1 10/18/25, 06:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86965

  3. Georg Ringer voted on patch set 1 CR +1 V +1 10/18/25, 06:33

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 10/18/25, 07:31

  5. Stefan Bürk merged patch set 2 10/18/25, 07:31