Review main Merged

91149[TASK] Remove useless check in ActionControllerValidationTest

Torben Hansen CR +2 V +2 Easy +0 −7 updated 10/18/25, 14:23

Commit message

It is already ensured that the `$response` variable is an
instance of `TYPO3\CMS\Extbase\Http\ForwardResponse`. The
following `assertInstanceOf` check can therefore be removed
as well as the associated entry in the phpstan baseline.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Torben Hansen uploaded patch set 1 10/18/25, 11:01

  2. core-ci voted on patch set 1 V +1 10/18/25, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86974

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 10/18/25, 12:07

  4. Anja Leichsenring voted on patch set 1 CR +1 V +1 10/18/25, 13:50

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 10/18/25, 14:23

  6. Christian Kuhn merged patch set 2 10/18/25, 14:23