Review main Merged Breaking

91154[!!!][TASK] Use strict types in Extbase Argument

Torben Hansen CR +2 V +2 Normal +65 −176 updated 10/31/25, 08:27

Commit message

This change introduces strict types for properties,
function arguments and return types in
`TYPO3\CMS\Extbase\Mvc\Controller\Argument`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1113

  1. Torben Hansen uploaded patch set 1 10/18/25, 13:18

  2. Torben Hansen marked it work in progress 10/18/25, 13:18

  3. core-ci voted on patch set 1 V +1 10/18/25, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86983

  4. Torben Hansen uploaded patch set 2 V +1 10/19/25, 15:27

  5. Torben Hansen marked it ready for review 10/19/25, 15:32

  6. core-ci voted on patch set 2 V +1 10/19/25, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87017

  7. Oliver Klee voted on patch set 2 CR +1 V +1 10/19/25, 16:15

  8. Benni Mack voted on patch set 2 CR +2 V +2 10/20/25, 10:23

  9. Benni Mack merged patch set 3 10/20/25, 10:23

  10. Sebastian Iffland commented on patch set 3 10/20/25, 11:18

    Was `declare(strict_types=1);` omitted intentionally in TYPO3\CMS\Extbase\Mvc\Controller\Argument?
  11. Torben Hansen commented on patch set 3 10/20/25, 11:21

    Reply

    No, this has been forgotten. I'll push a follow up
  12. Lina Wolf commented on patch set 3 10/26/25, 06:16

    Should we maybe make this class internal instead of making the new types API? It seems to be a class you should not fiddle with except in extremely rare cases? We never documented it.
  13. Garvin Hicking commented on patch set 3 10/31/25, 08:27

    Reply Unresolved

    Marking a class as internal would also mean to not use it for operations in extensions, but of course this class is needed to operate on arguments. We could close it off with "final", but I would say custom expansion might even be ok. So my opinion: No internal.