91156[!!!][TASK] Have stateless TypoScriptFrontendController
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 4
Files 59
- typo3/sysext/adminpanel/Classes/Modules/Info/GeneralInformation.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/Info/UserIntInformation.php+12 −8
- typo3/sysext/adminpanel/Resources/Private/Templates/Modules/Info/UserInt.html+2 −2
- typo3/sysext/backend/Resources/Private/tsref.xml+2 −2
- typo3/sysext/core/Classes/Cache/CacheDataCollector.php+15 −0
- typo3/sysext/core/Classes/Error/PageErrorHandler/PageContentErrorHandler.php2+1 −15
- typo3/sysext/core/Classes/Page/PageRenderer.php2+5 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107831-AfterCachedPageIsPersistedEventNoLongerReceivesTypoScriptFrontendController.rst3new+41 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107831-RemovedTypoScriptFrontendController.rst5new+67 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+0 −10
- typo3/sysext/extbase/Classes/ContentObject/ExtbasePluginContentObject.php+5 −4
- typo3/sysext/extbase/Classes/Service/ImageService.php+1 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/RequestBuilderTest.php+1 −15
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+0 −1
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+0 −5
- typo3/sysext/felogin/Tests/Unit/Redirect/RedirectHandlerTest.php+0 −5
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −8
- typo3/sysext/frontend/Classes/Authentication/FrontendUserAuthentication.php+1 −1
- typo3/sysext/frontend/Classes/Cache/CacheLifetimeCalculator.php+3 −4
Show 39 more files
- typo3/sysext/frontend/Classes/ContentObject/AbstractContentObject.php2+0 −18
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayInternalContentObject.php+6 −10
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+10 −25
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+5 −6
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/UserContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/UserInternalContentObject.php+5 −5
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+71 −269
- typo3/sysext/frontend/Classes/Event/AfterCacheableContentIsGeneratedEvent.php2+2 −1
- typo3/sysext/frontend/Classes/Event/AfterCachedPageIsPersistedEvent.php2+0 −7
- typo3/sysext/frontend/Classes/Event/ShouldUseCachedPageDataIfAvailableEvent.php2+0 −9
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+44 −58
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+44 −20
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php+1 −2
- typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php+1 −7
- typo3/sysext/frontend/Classes/Page/FrontendUrlPrefix.php4new+48 −0
- typo3/sysext/frontend/Classes/Page/PageParts.php+93 −0
- typo3/sysext/frontend/Classes/Resource/PublicUrlPrefixer.php+6 −9
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+3 −18
- typo3/sysext/frontend/Classes/Typolink/LegacyLinkBuilder.php+4 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −1
- typo3/sysext/frontend/Configuration/Services.yaml+0 −6
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentContentObjectTest.php+1 −4
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+1 −3
- typo3/sysext/frontend/Tests/Functional/Controller/Fixtures/TypoScriptFrontendControllerTestUserFuncs.php+4 −2
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+0 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/CaseContentObjectTest.php+1 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −15
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+1 −4
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+8 −8
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+14 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+30 −0
- typo3/sysext/redirects/Classes/Service/RedirectService.php+27 −30
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php+5 −5
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+0 −2
- .phpstorm.meta.php+0 −2
Review log 5394
Show 3569 earlier messages
-
Christian Kuhn uploaded patch set 1 10/18/25, 14:23
-
core-ci voted on patch set 1 V +1 10/18/25, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86985
-
Christian Kuhn uploaded patch set 2
V +110/18/25, 16:09 -
core-ci voted on patch set 2 V +1 10/18/25, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86989
-
Christian Kuhn uploaded patch set 3
V +110/19/25, 10:50 -
core-ci voted on patch set 3 V +1 10/19/25, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87010
-
Christian Kuhn uploaded patch set 4
V +110/19/25, 11:08 -
Christian Kuhn uploaded patch set 5 10/19/25, 11:10
-
core-ci voted on patch set 4 V +1 10/19/25, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87011
-
core-ci voted on patch set 5 V +1 10/19/25, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87012
-
Christian Kuhn uploaded patch set 6
V +110/20/25, 10:35 -
core-ci voted on patch set 6 V +1 10/20/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87069
-
Christian Kuhn uploaded patch set 7
V +110/20/25, 14:33 -
core-ci voted on patch set 7 V +1 10/20/25, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87088
-
Christian Kuhn uploaded patch set 8
V +110/20/25, 15:29 -
core-ci voted on patch set 8 V +1 10/20/25, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87094
-
Christian Kuhn uploaded patch set 9
V +110/20/25, 16:22 -
core-ci voted on patch set 9 V -1 10/20/25, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87099
-
Christian Kuhn uploaded patch set 10
V -110/20/25, 16:50 -
core-ci voted on patch set 10 V +1 10/20/25, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87102
-
Christian Kuhn uploaded patch set 11
V +110/22/25, 09:57 -
core-ci voted on patch set 11 V +1 10/22/25, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87230
-
Christian Kuhn uploaded patch set 12
V +110/22/25, 20:52 -
core-ci voted on patch set 12 V +1 10/22/25, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87306
-
Christian Kuhn uploaded patch set 13
V +110/22/25, 21:17 -
core-ci voted on patch set 13 V +1 10/22/25, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87308
-
Christian Kuhn uploaded patch set 14
V +110/22/25, 21:31 -
core-ci voted on patch set 14 V +1 10/22/25, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87309
-
Christian Kuhn uploaded patch set 15
V +110/22/25, 21:45 -
core-ci voted on patch set 15 V +1 10/22/25, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87310
-
Christian Kuhn uploaded patch set 16
V +110/22/25, 22:19 -
Christian Kuhn uploaded patch set 17 10/22/25, 22:23
-
core-ci voted on patch set 16 V +1 10/22/25, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87311
-
core-ci voted on patch set 17 V +1 10/22/25, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87312
-
Christian Kuhn uploaded patch set 18
V +110/22/25, 22:55 -
core-ci voted on patch set 18 V +1 10/22/25, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87345
-
core-ci voted on patch set 17 V +1 10/22/25, 23:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87346
-
Christian Kuhn uploaded patch set 19
V +110/22/25, 23:09 -
Christian Kuhn uploaded patch set 20 10/22/25, 23:13
-
core-ci voted on patch set 19 V +1 10/22/25, 23:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87347
-
core-ci voted on patch set 20 V +1 10/22/25, 23:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87348
-
Christian Kuhn uploaded patch set 21
V +110/23/25, 00:43 -
Christian Kuhn uploaded patch set 22 10/23/25, 00:47
-
core-ci voted on patch set 21 V +1 10/23/25, 00:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87350
-
core-ci voted on patch set 22 V +1 10/23/25, 00:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87351
-
Christian Kuhn uploaded patch set 23
V +110/23/25, 00:57 -
core-ci voted on patch set 23 V +1 10/23/25, 01:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87352
-
Christian Kuhn uploaded patch set 24
V +110/23/25, 01:17 -
Christian Kuhn uploaded patch set 25 10/23/25, 01:18
-
core-ci voted on patch set 25 V +1 10/23/25, 01:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87355
-
core-ci voted on patch set 24 V +1 10/23/25, 01:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87354
-
Christian Kuhn updated the commit message in patch set 26
V +110/23/25, 01:39 -
Christian Kuhn updated the commit message in patch set 27 10/23/25, 01:42
-
Christian Kuhn updated the commit message in patch set 28 10/23/25, 01:43
-
Christian Kuhn updated the commit message in patch set 29 10/23/25, 01:45
-
Christian Kuhn updated the commit message in patch set 30 10/23/25, 01:47
-
Christian Kuhn updated the commit message in patch set 31 10/23/25, 01:50
-
core-ci voted on patch set 26 V +1 10/23/25, 01:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87356
-
core-ci voted on patch set 27 V +1 10/23/25, 01:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87357
-
core-ci voted on patch set 28 V +1 10/23/25, 01:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87358
-
core-ci voted on patch set 29 V +1 10/23/25, 01:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87359
-
core-ci voted on patch set 30 V +1 10/23/25, 01:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87360
-
core-ci voted on patch set 31 V +1 10/23/25, 02:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87361
-
Christian Kuhn updated the commit message in patch set 32
V +110/23/25, 02:04 -
core-ci voted on patch set 32 V +1 10/23/25, 02:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87363
-
Benni Mack commented on patch set 32 10/23/25, 06:43
-
Christian Kuhn commented on patch set 32 10/24/25, 10:14
PageRenderer.php:195Replyi think we'll go with a dedicated and rather simple change to not cache the content twice in cache_pages when this change is done. a bigger overhaul of PR will need more time, though and includes some design decisions. -
Christian Kuhn uploaded patch set 33
V +110/24/25, 10:27 -
core-ci voted on patch set 33 V +1 10/24/25, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87484
-
Christian Kuhn uploaded patch set 34
V +110/24/25, 11:50 -
Christian Kuhn updated the commit message in patch set 35 10/24/25, 11:51
-
core-ci voted on patch set 34 V +1 10/24/25, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87488
-
core-ci voted on patch set 35 V +1 10/24/25, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87489
-
Christian Kuhn uploaded patch set 36
V +110/24/25, 13:21 -
core-ci voted on patch set 36 V +1 10/24/25, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87500
-
Christian Kuhn uploaded patch set 37
V +110/24/25, 14:14 -
core-ci voted on patch set 37 V +1 10/24/25, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87508
-
Christian Kuhn uploaded patch set 38
V +110/24/25, 14:26 -
core-ci voted on patch set 38 V +1 10/24/25, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87509
-
Benni Mack commented on patch set 38 10/24/25, 15:01
PageContentErrorHandler.php:121we could clean this up directly nowAbstractContentObject.php:79this will become a problem for a lot of third-party extensions (such as solr), we need to document this.AfterCacheableContentIsGeneratedEvent.php:24good comment to keep in an RST fileAfterCachedPageIsPersistedEvent.php:46we could use extension scanner here (so Rector can deal with it)ShouldUseCachedPageDataIfAvailableEvent.php:37We could use Extension Scanner here.FrontendUrlPrefix.php:19a quick comment that this service is here to evaluate absRefPrefix would be great.FrontendUrlPrefix.php:20internal or not? If not internal, we should add this to the RST for extension authors to know. -
Benni Mack updated the commit message in patch set 39
V +110/24/25, 15:08 -
core-ci voted on patch set 39 V +1 10/24/25, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87519
-
Benni Mack uploaded patch set 40
V +110/24/25, 15:34 -
Benni Mack commented on patch set 39 CR +1 V +1 10/24/25, 15:34
PageContentErrorHandler.php:121ReplyDoneAbstractContentObject.php:79ReplyDoneAfterCacheableContentIsGeneratedEvent.php:24ReplyDoneAfterCachedPageIsPersistedEvent.php:46ReplyDoneShouldUseCachedPageDataIfAvailableEvent.php:37ReplyDoneFrontendUrlPrefix.php:19ReplyDoneFrontendUrlPrefix.php:20ReplyDone -
Benni Mack voted on patch set 40 CR +1 V +1 10/24/25, 15:35
-
core-ci voted on patch set 40 V +1 10/24/25, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87520
-
Stefan Bürk voted on patch set 40 CR +1 V +1 10/24/25, 16:06
-
Christian Kuhn commented on patch set 40 CR +2 V +2 10/24/25, 16:15
thank you! -
Christian Kuhn merged patch set 41 10/24/25, 16:15
-
Garvin Hicking commented on patch set 41 10/24/25, 16:28
Breaking-107831-AfterCachedPageIsPersistedEventNoLongerReceivesTypoScriptFrontendController.rst:36```suggestion can now be found in the :php:`Request` which is available using :php:`$event->getRequest()`. ```Breaking-107831-RemovedTypoScriptFrontendController.rst:24```suggestion AbstractContentObject->getTypoScriptFrontendController() ```Breaking-107831-RemovedTypoScriptFrontendController.rst:26```suggestion All API methods that returned an instance of :php:`TypoScriptFrontendController`, ``` -
Garvin Hicking commented on patch set 41 10/24/25, 16:28
Huge success. Noted some typos while reading, will do in a combined docs patch in the future. -
Christian Kuhn commented on patch set 41 10/24/25, 16:30
Breaking-107831-AfterCachedPageIsPersistedEventNoLongerReceivesTypoScriptFrontendController.rst:36Replythx. i can take core of these typos in a next patch as drive-by if that is ok with you. -
Christian Kuhn commented on patch set 41 10/24/25, 23:46
Breaking-107831-AfterCachedPageIsPersistedEventNoLongerReceivesTypoScriptFrontendController.rst:36ReplyDoneBreaking-107831-RemovedTypoScriptFrontendController.rst:24ReplyDoneBreaking-107831-RemovedTypoScriptFrontendController.rst:26ReplyDone -
Christian Kuhn commented on patch set 41 10/24/25, 23:53
Breaking-107831-RemovedTypoScriptFrontendController.rst:24Reply
PageRenderer.php:195