Review main Merged

91166[TASK] Remove PHP 8 version checks for ReflectionAttribute

Oliver Hader CR +2 V +2 Easy +9 −18 updated 10/20/25, 11:07

Commit message

ReflectionAttribute is available since PHP 8.0, and since the minimum
PHP version requirement is now PHP 8.2 or higher, the version check
using class_exists() is no longer needed.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Oliver Hader uploaded patch set 1 10/20/25, 09:53

  2. core-ci voted on patch set 1 V +1 10/20/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87065

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 10/20/25, 10:21

  4. Simon Schaufelberger commented on patch set 1 10/20/25, 10:23

    this could even be backported to v13, what do you think?
  5. Benni Mack voted on patch set 1 CR +1 V +1 10/20/25, 10:27

  6. Oliver Klee voted on patch set 1 CR +1 V +1 10/20/25, 10:58

  7. Oliver Hader voted on patch set 1 CR +2 V +2 10/20/25, 11:04

  8. Oliver Hader merged patch set 2 10/20/25, 11:04

  9. Oliver Hader commented on patch set 2 10/20/25, 11:07

    Reply

    Sorry, I overlooked that comment. I think it could be back-ported later to v13 as well - however, it's just a clean-up.