Review 13.4 Merged

91167[BUGFIX] Ensure CSP header has nonce in partially cached state

Oliver Hader CR +2 V +2 Normal +112 −14 updated 10/23/25, 11:24

Commit message

Issue #107613 revealed that the frontend rendering stack created
two distinct `ConsumableNonce` instances – one in the global request
(used for building the Content‑Security‑Policy header) and another
one inside `PageRenderer::updateState()` (used for counting nonces
when adding assets).

When assets were rendered via an uncached cObject (e.g. `COA_INT`,
`USER_INT`) the nonce consumption counter was not incremented. As
a result the generated CSP header did not contain a nonce source and
browsers rejected inline scripts/styles.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oliver Hader uploaded patch set 1 10/20/25, 10:01

  2. core-ci voted on patch set 1 V +1 10/20/25, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87066

  3. Oliver Hader voted on patch set 1 CR +2 V +2 10/23/25, 11:24

  4. Oliver Hader merged patch set 2 10/23/25, 11:24