Review main Merged

91168[TASK] Simplify RecoveryCodes::generatePlainRecoveryCodes

Oliver Hader CR +2 V +2 Easy +5 −17 updated 10/21/25, 13:44

Commit message

RecoveryCodes::generatePlainRecoveryCodes uses a randomly
generated 64-bit word to generate random numeric recovery
codes using `hexdec` with ignoring the maximum integer
limit of `PHP_INT_MAX`, which is a 63-bit integer.

This change now concatenates the results of random_int(0,9).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Oliver Hader uploaded patch set 1 10/20/25, 11:55

  2. Oliver Hader uploaded patch set 2 10/20/25, 11:59

  3. core-ci voted on patch set 1 V +1 10/20/25, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87073

  4. Oliver Klee voted on patch set 2 CR +1 10/20/25, 12:06

  5. core-ci voted on patch set 2 V -1 10/20/25, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87074

  6. Oliver Hader uploaded patch set 3 CR +1 V -1 10/20/25, 12:28

  7. core-ci voted on patch set 3 V +1 10/20/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87076

  8. Georg Ringer voted on patch set 3 CR +1 V +1 10/20/25, 12:58

  9. Oliver Klee uploaded patch set 4 CR +1 V +1 10/20/25, 13:08

  10. Oliver Klee voted on patch set 4 CR +1 V +1 10/20/25, 13:08

  11. core-ci voted on patch set 4 V +1 10/20/25, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87080

  12. Georg Ringer voted on patch set 4 CR +1 V +1 10/20/25, 15:06

  13. Torben Hansen voted on patch set 4 CR +1 V +1 10/20/25, 16:24

  14. Oliver Hader voted on patch set 4 CR +2 V +2 10/21/25, 12:30

  15. Oliver Hader merged patch set 5 10/21/25, 13:44