Review main Merged

91169[TASK] Add new syntax for referencing labels for modules

Benni Mack CR +2 V +2 Normal +125 −10 updated 11/11/25, 17:35

Commit message

This change allows to add a domain name as "labels" reference
over "LLL:" as prefix to an actual file.

This way the legacy names "mlang_tabs_tab" etc. are gone,
because the file now needs to contain:

  - "title" instead of "mlang_tabs_tab"
  - "short_description" instead of "mlang_labels_tablabel"
  - "description" instead of "mlang_labels_tabdescr"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 4

Files 3

Review log 2028

Show 23 earlier messages
  1. Benni Mack uploaded patch set 1 10/20/25, 15:16

  2. core-ci voted on patch set 1 V +1 10/20/25, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87093

  3. Benni Mack marked it work in progress 10/21/25, 05:23

  1. Benni Mack uploaded patch set 2 V +1 11/05/25, 15:39

  2. Benni Mack marked it ready for review 11/05/25, 15:39

  3. core-ci voted on patch set 2 V -1 11/05/25, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88526

  4. Garvin Hicking commented on patch set 2 CR -1 11/10/25, 15:35

    on it
  5. Garvin Hicking uploaded patch set 3 CR -1 V -1 11/10/25, 21:32

  6. Garvin Hicking commented on patch set 3 11/10/25, 21:33

    (untested)

    Modules.php:13

    Reviewer's note: This breaks saved bookmarks (both TYPO3-internal and within clients), as no alias or redirect is in place. Since we're doing that with multiple backend modules and this is just an "inconvenience" my vote is that's fair and should not need to mee BC policy expectations. The hassle of adding a legacy redirect for this is not worth it, IMO.
  7. core-ci voted on patch set 3 V -1 11/10/25, 21:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88914

  8. Garvin Hicking uploaded patch set 4 V -1 11/11/25, 00:28

  9. core-ci voted on patch set 4 V -1 11/11/25, 00:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88922

  10. Garvin Hicking uploaded patch set 5 V -1 11/11/25, 07:43

  11. core-ci voted on patch set 5 V -1 11/11/25, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88945

  12. Lina Wolf commented on patch set 5 11/11/25, 08:12

    I would like to suggest, that we solve how to deprecate XLIFF files first (https://review.typo3.org/c/Packages/TYPO3.CMS/+/91375) then the whole file can be deprecated at once without having to deprecate every key as you have done here. Also the linting is a great idea, but we should probably solve it first in an independent check. I keep running across invalid files, for example with duplicate keys, these would have to be resolved first, before general linting can be applied
  13. Garvin Hicking uploaded patch set 6 V -1 11/11/25, 09:37

  14. core-ci voted on patch set 6 V -1 11/11/25, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88966

  15. Benni Mack commented on patch set 6 11/11/25, 12:11

    CheckIntegrityXliff.php:119

    that's not enough, we have labels in site sets as well now.
  16. Garvin Hicking commented on patch set 6 CR -1 11/11/25, 12:52

    working on this again to divide and conquer

    CheckIntegrityXliff.php:119 Reply

    (there's a distinct PHP check for site sets!)
  17. Garvin Hicking uploaded patch set 7 CR -1 V -1 11/11/25, 13:46

  18. core-ci voted on patch set 7 V +1 11/11/25, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89006

  19. Garvin Hicking updated the commit message in patch set 8 V +1 11/11/25, 15:13

  20. Garvin Hicking voted on patch set 8 CR +1 V +1 11/11/25, 15:13

  21. Garvin Hicking commented on patch set 8 11/11/25, 15:13

    Reply

    Done

    Reply

    Done

    Reply

    (covered in followup, is no longer part of this)

    CheckIntegrityXliff.php:119 Reply

    (covered in followup, is no longer part of this)
  22. core-ci voted on patch set 8 V +1 11/11/25, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89027

  23. Jochen Roth voted on patch set 8 CR +1 V +1 11/11/25, 17:34

  24. Benni Mack voted on patch set 8 CR +2 V +2 11/11/25, 17:35

  25. Benni Mack merged patch set 9 11/11/25, 17:35