Review main Merged

91171[TASK] Add declare(strict_types=1) to Extbase Argument

Torben Hansen CR +2 V +2 Easy +2 −0 updated 10/20/25, 18:44

Commit message

With #107777 the Extbase argument class now uses strict
types everywhere. It has however been forgotten to add
`declare(strict_types=1);` to the class.

With this patch, the missing declaration is added.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Torben Hansen uploaded patch set 1 10/20/25, 16:30

  2. core-ci voted on patch set 1 V +1 10/20/25, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87101

  3. Oliver Klee voted on patch set 1 CR +1 V +1 10/20/25, 18:20

  4. Georg Ringer voted on patch set 1 CR +1 V +1 10/20/25, 18:44

  5. Benni Mack voted on patch set 1 CR +2 V +2 10/20/25, 18:44

  6. Benni Mack merged patch set 2 10/20/25, 18:44