Review main Abandoned

91179[BUGFIX] Fix indicator and active state for third-level modules

Oli Bartsch CR 0 V 0 Normal +58 −6 updated 11/12/25, 19:58

Commit message

This change improves the UX of third-level module
navigation (introduced #107716) in by fixing the
expand/collapse indicator arrow animation and
refining the interaction behavior based on
whether a submodule has an overview page.

A data attribute is added to distinguish modules
with overview pages. When a module has a submodule
overview, clicking the indicator arrow only toggles
third-level visibility. Clicking the module name/icon
navigates to the overview page. A border separator
indicates the two interaction areas.

When a module has no submodule overview, clicking
anywhere toggles third-level visibility and no visual
separator is shown.

Additionally, this fixes active state highlighting
to show only the currently viewed module (overview
page or third-level item), not both.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 6

Review log 79

  1. Oli Bartsch uploaded patch set 1 10/21/25, 09:20

  2. core-ci voted on patch set 1 V +1 10/21/25, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87157

  3. Georg Ringer voted on patch set 1 CR +1 V +1 10/21/25, 11:07

  4. Garvin Hicking commented on patch set 1 10/22/25, 08:08

    I know this is "work in progress" and I don't want to cause hold-up or issues. I hope it's okay to give the following feedback. I'm not blocking and just commenting/asking. Could the "| V" indicator only show that "|" separator when hovering? I find it a bit confusing seeing a "|" hanging around in the list and taking up space that I usually am used to be empty? Also I think the same indicator should be added for the top menu labels then so that it is unified. Having the menu unfold on click to the main menu item has some sense, but I honestly feel spammed by submenu items if I click on two second-level entries after another, because when moving to another module the first clicked module no longer contracts. That makes the left frame now scroll an awful lot, and puts other important modules out of reach. I would like a user preference to opt out of this behavior to be able to have a leaner main navigation on the left-hand, is this maybe planned? Should not be User TS Config IMO, but a "real" editor preference. The "TypoScript" main menu has no dropdown in the docheader to switch modules, but "Page TSConfig" does. What is the distinction here? All other third-level entries (Styleguide, Info) also have it. (While I'm at it: How about some more spacing of the borders when hovering on a third level item entry? It feels a bit cut off to the left side)
  5. Oli Bartsch commented on patch set 1 10/22/25, 08:57

    Reply

    Thanks a lot for your feedback. Can you please add it to https://review.typo3.org/c/Packages/TYPO3.CMS/+/91189? I think, Benji will fix this there in a whole and that this patch probably never gets merged.
  6. Garvin Hicking commented on patch set 1 10/22/25, 09:16

    Reply Unresolved

    OK, I was not aware of the other patch, thanks for pointing me to it. I think that is yet in a state that might differ from this approach and my comments might not apply there. I'll wait until it gets out of "WIP" to add feedback, as I do not want to create overhead.
  7. Oli Bartsch uploaded patch set 2 CR +1 V +1 11/12/25, 16:55

  8. core-ci voted on patch set 2 V +1 11/12/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89375

  9. Oli Bartsch abandoned the change 11/12/25, 19:58