Review 12.4 Merged

91187[TASK] Simplify RecoveryCodes::generatePlainRecoveryCodes

Oliver Hader CR +2 V +2 Easy +5 −17 updated 10/21/25, 13:44

Commit message

RecoveryCodes::generatePlainRecoveryCodes uses a randomly
generated 64-bit word to generate random numeric recovery
codes using `hexdec` with ignoring the maximum integer
limit of `PHP_INT_MAX`, which is a 63-bit integer.

This change now concatenates the results of random_int(0,9).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Oliver Hader uploaded patch set 1 10/21/25, 12:26

  2. Oliver Hader voted on patch set 1 CR +2 V +2 10/21/25, 12:30

  3. core-ci voted on patch set 1 V -1 10/21/25, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87183

  4. core-ci voted on patch set 1 V +1 10/21/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87183

  5. Oliver Hader merged patch set 2 10/21/25, 13:44