Review main Merged

91191[BUGFIX] Allow new domain syntax for resourceOverrides

Benni Mack CR +2 V +2 Hard +456 −206 updated 07/06/26, 06:58

Commit message

It is now possible to override a translation file by its
translation domain via
$GLOBALS['TYPO3_CONF_VARS']['LANG']['resourceOverrides'].

For this, the TranslationDomainResolver class is added
as a helper service class.

```
// Domain syntax
$GLOBALS['TYPO3_CONF_VARS']['LANG']['resourceOverrides']['core.common'][]
  = 'EXT:my_extension/Resources/Private/Language/locallang_common_override.xlf';

// Language-specific override with domain syntax
$GLOBALS['TYPO3_CONF_VARS']['LANG']['resourceOverrides']['de']['core.common'][]
  = 'EXT:my_extension/Resources/Private/Language/de.locallang_common_override.xlf';
```

The internal `vendor/bin/typo3 language:domain:list` command receives
a `--show-overrides` flag to reveal this information.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 18

Review log 3251

Show 1626 earlier messages
  1. Benni Mack uploaded patch set 1 10/21/25, 21:32

  2. core-ci voted on patch set 1 V -1 10/21/25, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87202

  3. Benni Mack uploaded patch set 2 V -1 01/03/26, 18:48

  4. core-ci voted on patch set 2 V -1 01/03/26, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92915

  5. Benni Mack uploaded patch set 3 V -1 01/22/26, 12:58

  6. core-ci voted on patch set 3 V -1 01/22/26, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94031

  7. Ayke Halder uploaded patch set 4 V -1 02/12/26, 10:39

  8. core-ci voted on patch set 4 V -1 02/12/26, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95702

  9. Ayke Halder uploaded patch set 5 V -1 02/12/26, 15:41

  10. core-ci voted on patch set 5 V -1 02/12/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95746

  11. Ayke Halder uploaded patch set 6 V -1 02/12/26, 16:06

  12. core-ci voted on patch set 6 V -1 02/12/26, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95751

  13. Ayke Halder uploaded patch set 7 V -1 02/12/26, 16:35

  14. core-ci voted on patch set 7 V +1 02/12/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95754

  15. Benni Mack marked it ready for review 02/17/26, 15:00

  16. Garvin Hicking updated the commit message in patch set 8 V +1 02/17/26, 17:41

  17. Garvin Hicking commented on patch set 8 02/17/26, 17:43

    Needs an issue. Maybe also adjust an existing ReST file for this syntax, otherwise it will not find its way to the documentation easily. (Maybe the general "new translation domain system" one?)
  18. core-ci voted on patch set 8 V +1 02/17/26, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96074

  19. Garvin Hicking commented on patch set 8 V -1 02/17/26, 20:30

    When using this on current main, the whole page tree is broken and I get errors for the JS label resolving.
  20. Garvin Hicking commented on patch set 8 02/17/26, 20:30

    TranslateViewHelper.php:108

    I think these two (and a lower one) are unblocked to utilize constructor based DI now.
  21. Anja Leichsenring uploaded patch set 9 V +1 03/11/26, 19:31

  22. Anja Leichsenring commented on patch set 9 03/11/26, 19:32

    rebased and DI leveraged as requested, but still BE crashes and Issue is missing.
  23. Anja Leichsenring commented on patch set 9 03/11/26, 19:36

    Reply

    Crash seems to be caused by Call to undefined method TYPO3\CMS\Core\Localization\TranslationDomainMapper::isValidDomainName() | Error thrown in file /var/www/html/typo3/sysext/core/Classes/Localization/JavaScriptLanguageDomainProvider.php in line 42.
  24. core-ci voted on patch set 9 V -1 03/11/26, 20:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97777

  25. Anja Leichsenring rebased onto patch set 10 V -1 03/25/26, 14:44

  26. core-ci voted on patch set 10 V -1 03/25/26, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98705

  1. Benni Mack uploaded patch set 11 V -1 04/21/26, 14:32

  2. Benni Mack marked it ready for review 04/21/26, 14:34

  3. core-ci voted on patch set 11 V -1 04/21/26, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100648

  4. Benni Mack rebased onto patch set 12 V -1 04/22/26, 05:44

  5. core-ci voted on patch set 12 V -1 04/22/26, 06:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100684

  6. Ayke Halder commented on patch set 12 06/16/26, 08:00

    I'll pick this one up again.
  7. Ayke Halder uploaded patch set 13 V -1 06/27/26, 08:45

    Rebased
  8. Ayke Halder uploaded patch set 14 06/27/26, 08:56

    Rebased
  9. core-ci voted on patch set 14 V -1 06/27/26, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103973

  10. Ayke Halder uploaded patch set 15 V -1 06/27/26, 09:17

    Refactoring to use translationDomainResolver isValidDomainName
  11. core-ci voted on patch set 15 V +1 06/27/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103974

  12. Ayke Halder commented on patch set 15 06/27/26, 09:31

    This should work now. @benni@typo3.org I did not look any deeper into the code, so I do not know if further simplification is possible.
  13. core-ci voted on patch set 13 V -1 06/27/26, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103972

  14. Garvin Hicking updated the commit message in patch set 16 V +1 06/29/26, 17:05

  15. core-ci voted on patch set 16 V +1 06/29/26, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104052

  16. Garvin Hicking uploaded patch set 17 V +1 07/03/26, 12:37

    Fix merge conflict DI for VH
  17. Garvin Hicking commented on patch set 17 07/03/26, 12:39

    Reply

    Done

    Reply

    Done

    TranslateViewHelper.php:108 Reply

    Done
  18. core-ci voted on patch set 17 V +1 07/03/26, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104277

  19. Ayke Halder updated the commit message in patch set 18 V +1 07/03/26, 13:17

  20. core-ci voted on patch set 18 V +1 07/03/26, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104288

  21. Garvin Hicking uploaded patch set 19 V +1 07/03/26, 13:47

  22. core-ci voted on patch set 19 V +1 07/03/26, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104291

  23. Garvin Hicking voted on patch set 19 CR +1 V +1 07/03/26, 14:20

  24. Benni Mack voted on patch set 19 CR +2 V +2 07/06/26, 06:57

  25. Benni Mack merged patch set 20 07/06/26, 06:58