91191[BUGFIX] Allow new domain syntax for resourceOverrides
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 18
- typo3/sysext/core/Classes/Localization/JavaScriptLanguageDomainProvider.php+2 −2
- typo3/sysext/core/Classes/Localization/LabelFileResolver.php+23 −22
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+2 −1
- typo3/sysext/core/Classes/Localization/TranslationDomainMapper.php+6 −140
- typo3/sysext/core/Classes/Localization/TranslationDomainResolver.phpnew+206 −0
- typo3/sysext/core/Classes/ServiceProvider.php+12 −1
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-109672-AllowDomainSyntaxInResourceOverrides.rstnew+47 −0
- typo3/sysext/core/Tests/Functional/Localization/LanguageServiceTest.php+32 −0
- typo3/sysext/core/Tests/Functional/Localization/TranslationDomainAliasTest.php+2 −1
- typo3/sysext/core/Tests/Functional/Localization/TranslationDomainMapperTest.php+14 −11
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+21 −6
- typo3/sysext/core/Tests/Unit/Localization/TranslationDomainResolverTest.phprenamed+3 −6
- typo3/sysext/core/Tests/Unit/Page/PageRendererFactoryTrait.php+9 −1
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php+3 −1
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php2+3 −1
- typo3/sysext/install/Classes/Middleware/JavaScriptLanguageDomainProvider.php+3 −3
- typo3/sysext/install/Classes/ServiceProvider.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/TranslationDomainListCommand.php+66 −8
Review log 3251
Show 1626 earlier messages
-
Benni Mack uploaded patch set 1 10/21/25, 21:32
-
core-ci voted on patch set 1 V -1 10/21/25, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87202
-
Benni Mack uploaded patch set 2
V -101/03/26, 18:48 -
core-ci voted on patch set 2 V -1 01/03/26, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92915
-
Benni Mack uploaded patch set 3
V -101/22/26, 12:58 -
core-ci voted on patch set 3 V -1 01/22/26, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94031
-
Ayke Halder uploaded patch set 4
V -102/12/26, 10:39 -
core-ci voted on patch set 4 V -1 02/12/26, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95702
-
Ayke Halder uploaded patch set 5
V -102/12/26, 15:41 -
core-ci voted on patch set 5 V -1 02/12/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95746
-
Ayke Halder uploaded patch set 6
V -102/12/26, 16:06 -
core-ci voted on patch set 6 V -1 02/12/26, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95751
-
Ayke Halder uploaded patch set 7
V -102/12/26, 16:35 -
core-ci voted on patch set 7 V +1 02/12/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95754
-
Benni Mack marked it ready for review 02/17/26, 15:00
-
Garvin Hicking updated the commit message in patch set 8
V +102/17/26, 17:41 -
Garvin Hicking commented on patch set 8 02/17/26, 17:43
Needs an issue. Maybe also adjust an existing ReST file for this syntax, otherwise it will not find its way to the documentation easily. (Maybe the general "new translation domain system" one?) -
core-ci voted on patch set 8 V +1 02/17/26, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96074
-
Garvin Hicking commented on patch set 8 V -1 02/17/26, 20:30
When using this on current main, the whole page tree is broken and I get errors for the JS label resolving. -
Garvin Hicking commented on patch set 8 02/17/26, 20:30
TranslateViewHelper.php:108I think these two (and a lower one) are unblocked to utilize constructor based DI now. -
Anja Leichsenring uploaded patch set 9
V +103/11/26, 19:31 -
Anja Leichsenring commented on patch set 9 03/11/26, 19:32
rebased and DI leveraged as requested, but still BE crashes and Issue is missing. -
Anja Leichsenring commented on patch set 9 03/11/26, 19:36
Reply
Crash seems to be caused by Call to undefined method TYPO3\CMS\Core\Localization\TranslationDomainMapper::isValidDomainName() | Error thrown in file /var/www/html/typo3/sysext/core/Classes/Localization/JavaScriptLanguageDomainProvider.php in line 42. -
core-ci voted on patch set 9 V -1 03/11/26, 20:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97777
-
Anja Leichsenring rebased onto patch set 10
V -103/25/26, 14:44 -
core-ci voted on patch set 10 V -1 03/25/26, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98705
-
Benni Mack uploaded patch set 11
V -104/21/26, 14:32 -
Benni Mack marked it ready for review 04/21/26, 14:34
-
core-ci voted on patch set 11 V -1 04/21/26, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100648
-
Benni Mack rebased onto patch set 12
V -104/22/26, 05:44 -
core-ci voted on patch set 12 V -1 04/22/26, 06:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100684
-
Ayke Halder commented on patch set 12 06/16/26, 08:00
I'll pick this one up again. -
Ayke Halder uploaded patch set 13
V -106/27/26, 08:45Rebased -
Ayke Halder uploaded patch set 14 06/27/26, 08:56
Rebased -
core-ci voted on patch set 14 V -1 06/27/26, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103973
-
Ayke Halder uploaded patch set 15
V -106/27/26, 09:17Refactoring to use translationDomainResolver isValidDomainName -
core-ci voted on patch set 15 V +1 06/27/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103974
-
Ayke Halder commented on patch set 15 06/27/26, 09:31
This should work now. @benni@typo3.org I did not look any deeper into the code, so I do not know if further simplification is possible. -
core-ci voted on patch set 13 V -1 06/27/26, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103972
-
Garvin Hicking updated the commit message in patch set 16
V +106/29/26, 17:05 -
core-ci voted on patch set 16 V +1 06/29/26, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104052
-
Garvin Hicking uploaded patch set 17
V +107/03/26, 12:37Fix merge conflict DI for VH -
Garvin Hicking commented on patch set 17 07/03/26, 12:39
Reply
DoneReply
DoneTranslateViewHelper.php:108ReplyDone -
core-ci voted on patch set 17 V +1 07/03/26, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104277
-
Ayke Halder updated the commit message in patch set 18
V +107/03/26, 13:17 -
core-ci voted on patch set 18 V +1 07/03/26, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104288
-
Garvin Hicking uploaded patch set 19
V +107/03/26, 13:47 -
core-ci voted on patch set 19 V +1 07/03/26, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104291
-
Garvin Hicking voted on patch set 19 CR +1 V +1 07/03/26, 14:20
-
Benni Mack voted on patch set 19 CR +2 V +2 07/06/26, 06:57
-
Benni Mack merged patch set 20 07/06/26, 06:58