Review main Merged

91199[DOCS] Use correct finisher code examples

Oli Bartsch CR +2 V +2 Normal +47 −43 updated 10/22/25, 15:59

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Lina Wolf +1
    • Josua Vogel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Lina Wolf +1
    • Josua Vogel +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1722

  1. Oli Bartsch uploaded patch set 1 10/22/25, 11:44

  2. core-ci voted on patch set 1 V +1 10/22/25, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87247

  3. Stefan Bürk commented on patch set 1 10/22/25, 12:13

    Sure about 12.4 ? checked some of the files not existing in 12.4 ....
  4. Oli Bartsch updated the commit message in patch set 2 V +1 10/22/25, 12:18

  5. Oli Bartsch commented on patch set 2 10/22/25, 12:19

    Reply

    Done
  6. Stefan Bürk voted on patch set 2 CR +1 V +1 10/22/25, 12:26

  7. core-ci voted on patch set 2 V +1 10/22/25, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87251

  8. Josua Vogel commented on patch set 2 10/22/25, 12:37

    _finisher.php.inc:8

    ```suggestion private function addFlashMessageFinisher(FormDefinition $formDefinition, string $message) ```
  9. Oli Bartsch commented on patch set 3 CR +1 V +1 10/22/25, 13:09

    Published edit on patch set 2.
  10. Oli Bartsch commented on patch set 3 10/22/25, 13:10

    _finisher.php.inc:8 Reply

    Fix applied.
  11. core-ci voted on patch set 3 V +1 10/22/25, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87264

  12. Josua Vogel voted on patch set 3 CR +1 V +1 10/22/25, 13:20

  13. Lina Wolf commented on patch set 4 CR +1 V +1 10/22/25, 13:44

    Published edit on patch set 3.
  14. Lina Wolf commented on patch set 5 10/22/25, 13:44

    Published edit on patch set 4.
  15. Lina Wolf commented on patch set 5 10/22/25, 13:44

    Index.rst:193

    Underlines must be as long as the section header
  16. Lina Wolf voted on patch set 5 CR +1 V +1 10/22/25, 13:44

  17. Josua Vogel voted on patch set 5 CR +1 V +1 10/22/25, 13:51

  18. core-ci voted on patch set 5 V +1 10/22/25, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87270

  19. core-ci voted on patch set 4 V +1 10/22/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87269

  20. Oli Bartsch voted on patch set 5 CR +2 V +2 10/22/25, 15:57

  21. Benni Mack voted on patch set 5 CR +1 V +1 10/22/25, 15:58

  22. Oli Bartsch merged patch set 6 10/22/25, 15:59