91199[DOCS] Use correct finisher code examples
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Lina Wolf +1
- Josua Vogel +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Lina Wolf +1
- Josua Vogel +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/ConfirmationFinisher/_codesnippets/_finisher.php.inc+1 −0
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/DeleteUploadsFinisher/_codesnippets/_finisher.php.inc+1 −2
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/EmailFinisher/_codesnippets/_finisher.php.inc+1 −2
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/EmailFinisher/Index.rst+2 −2
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/FlashMessageFinisher/_codesnippets/_finisher.php.inc2+10 −4
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/FlashMessageFinisher/_codesnippets/_form.yaml+7 −21
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/FlashMessageFinisher/Index.rst+1 −1
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/RedirectFinisher/_codesnippets/_finisher.php.inc+1 −2
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/SaveToDatabaseFinisher/_codesnippets/_form.yaml+21 −7
- typo3/sysext/form/Documentation/I/Concepts/Finishers/ReadyToUseFinishers/SaveToDatabaseFinisher/Index.rst1+2 −2
Review log 1722
-
Oli Bartsch uploaded patch set 1 10/22/25, 11:44
-
core-ci voted on patch set 1 V +1 10/22/25, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87247
-
Stefan Bürk commented on patch set 1 10/22/25, 12:13
Sure about 12.4 ? checked some of the files not existing in 12.4 .... -
Oli Bartsch updated the commit message in patch set 2
V +110/22/25, 12:18 -
Oli Bartsch commented on patch set 2 10/22/25, 12:19
Reply
Done -
Stefan Bürk voted on patch set 2 CR +1 V +1 10/22/25, 12:26
-
core-ci voted on patch set 2 V +1 10/22/25, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87251
-
Josua Vogel commented on patch set 2 10/22/25, 12:37
_finisher.php.inc:8```suggestion private function addFlashMessageFinisher(FormDefinition $formDefinition, string $message) ``` -
Oli Bartsch commented on patch set 3
CR +1V +110/22/25, 13:09Published edit on patch set 2. -
Oli Bartsch commented on patch set 3 10/22/25, 13:10
_finisher.php.inc:8ReplyFix applied. -
core-ci voted on patch set 3 V +1 10/22/25, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87264
-
Josua Vogel voted on patch set 3 CR +1 V +1 10/22/25, 13:20
-
Lina Wolf commented on patch set 4
CR +1V +110/22/25, 13:44Published edit on patch set 3. -
Lina Wolf commented on patch set 5 10/22/25, 13:44
Published edit on patch set 4. -
Lina Wolf commented on patch set 5 10/22/25, 13:44
Index.rst:193Underlines must be as long as the section header -
Lina Wolf voted on patch set 5 CR +1 V +1 10/22/25, 13:44
-
Josua Vogel voted on patch set 5 CR +1 V +1 10/22/25, 13:51
-
core-ci voted on patch set 5 V +1 10/22/25, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87270
-
core-ci voted on patch set 4 V +1 10/22/25, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87269
-
Oli Bartsch voted on patch set 5 CR +2 V +2 10/22/25, 15:57
-
Benni Mack voted on patch set 5 CR +1 V +1 10/22/25, 15:58
-
Oli Bartsch merged patch set 6 10/22/25, 15:59