Review 13.4 Merged

91200[BUGFIX] Avoid using `bool` as `array` in `EXT:indexed_search`

Stefan Bürk CR +2 V +2 Easy +6 −1 updated 10/22/25, 12:14

Commit message

The lexer of `EXT:indexed_search` calls method `getWord()`
in `split2Words()` and expands the result into two
variables using the list syntax `[] = ...`. This
triggers a `PHP Warning` with PHP 8.5.0.

The patch sanitizes the code to check the return array.

  typo3/sysext/indexed_search/Classes/Lexer.php:59
  Cannot use bool as array

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 10/22/25, 12:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/22/25, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87248

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 10/22/25, 12:14

  4. Stefan Bürk merged patch set 2 10/22/25, 12:14