Review main Abandoned

91206[BUGFIX] Improve accessibility for column edit icon

Lina Wolf CR 0 V -1 Easy +4 −3 updated 10/29/25, 18:44

Commit message

The label is not used in any other place
so adding an argument to it should be safe.

Review

  • Code review CR 0
  • Verified V -1
    • Benjamin Franzke -1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1013

  1. Lina Wolf uploaded patch set 1 10/22/25, 14:29

  2. core-ci voted on patch set 1 V +1 10/22/25, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87271

  3. Georg Ringer commented on patch set 1 10/22/25, 15:27

    locallang_layout.xlf:79

    I suggest using "%s" to avoid a strange text like > Edit content in area Normal doesnt really make sense
  4. Lina Wolf uploaded patch set 2 V +1 10/22/25, 16:51

  5. Lina Wolf commented on patch set 1 10/22/25, 16:51

    locallang_layout.xlf:79 Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/22/25, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87282

  7. Chris Müller updated the commit message in patch set 3 V +1 10/22/25, 17:54

  8. Chris Müller commented on patch set 3 10/22/25, 17:58

    ColumnHeader.html:10

    Why do you add an aria-label when you have the same text as link text? The link text is only visually hidden, therefore available for screenreaders. IMHO no aria-label needed.
  9. core-ci voted on patch set 3 V +1 10/22/25, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87285

  10. Lina Wolf commented on patch set 3 10/22/25, 18:27

    ColumnHeader.html:10 Reply

    According to the A11y tester (see ticket) it has to have either a visible text or an aria label / aria labled by
  11. Chris Müller commented on patch set 3 10/22/25, 19:18

    ColumnHeader.html:10 Reply

    Acknowledged
  12. Benjamin Franzke commented on patch set 3 V -1 10/23/25, 19:58

    ColumnHeader.html:10 Unresolved

    I can *not* verify that tools (tested NVDA, Narrator and Voiceover) can not read out the existing label (in `span class="visually-hidden"`), all three tools read the labels, once without duplication or any strange behavior. That means, it seems there is no bug, as you already questioned as well in https://forge.typo3.org/issues/107740#note-2 We actually generally prefer text-content instead of unnecessary `aria-label` attributes, I'll -1 this for now and will request feedback on what the actual issue is meant to be, otherwise we can not verify that this patch solves any real issue.
  13. Benjamin Franzke abandoned the change 10/29/25, 18:44

    I'm abandoning here, because this reported issue was invalid and has now been reported against EXT:container. See https://forge.typo3.org/issues/107740#note-8 and https://github.com/b13/container/issues/637