91206[BUGFIX] Improve accessibility for column edit icon
Commit message
Review
-
Code review CR 0
-
Verified V -1
- Benjamin Franzke -1
- core-ci +1 CI
Issues 1
Files 2
Review log 1013
-
Lina Wolf uploaded patch set 1 10/22/25, 14:29
-
core-ci voted on patch set 1 V +1 10/22/25, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87271
-
Georg Ringer commented on patch set 1 10/22/25, 15:27
-
Lina Wolf uploaded patch set 2
V +110/22/25, 16:51 -
Lina Wolf commented on patch set 1 10/22/25, 16:51
locallang_layout.xlf:79ReplyDone -
core-ci voted on patch set 2 V +1 10/22/25, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87282
-
Chris Müller updated the commit message in patch set 3
V +110/22/25, 17:54 -
Chris Müller commented on patch set 3 10/22/25, 17:58
ColumnHeader.html:10Why do you add an aria-label when you have the same text as link text? The link text is only visually hidden, therefore available for screenreaders. IMHO no aria-label needed. -
core-ci voted on patch set 3 V +1 10/22/25, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87285
-
Lina Wolf commented on patch set 3 10/22/25, 18:27
ColumnHeader.html:10ReplyAccording to the A11y tester (see ticket) it has to have either a visible text or an aria label / aria labled by -
Chris Müller commented on patch set 3 10/22/25, 19:18
ColumnHeader.html:10ReplyAcknowledged -
Benjamin Franzke commented on patch set 3 V -1 10/23/25, 19:58
ColumnHeader.html:10UnresolvedI can *not* verify that tools (tested NVDA, Narrator and Voiceover) can not read out the existing label (in `span class="visually-hidden"`), all three tools read the labels, once without duplication or any strange behavior. That means, it seems there is no bug, as you already questioned as well in https://forge.typo3.org/issues/107740#note-2 We actually generally prefer text-content instead of unnecessary `aria-label` attributes, I'll -1 this for now and will request feedback on what the actual issue is meant to be, otherwise we can not verify that this patch solves any real issue. -
Benjamin Franzke abandoned the change 10/29/25, 18:44
I'm abandoning here, because this reported issue was invalid and has now been reported against EXT:container. See https://forge.typo3.org/issues/107740#note-8 and https://github.com/b13/container/issues/637
locallang_layout.xlf:79