Review main Abandoned

91207[BUGFIX] Add aria-label to new page content search box

Lina Wolf CR -1 V +1 Easy +2 −1 updated 11/05/25, 13:39

Commit message

A placeholder is not sufficient to make the field accessible.

Review

  • Code review CR -1
    • Benjamin Franzke -1
    • Georg Ringer +1
    • Sven Liebert +1
  • Verified V +1
    • Georg Ringer +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Lina Wolf uploaded patch set 1 10/22/25, 14:45

  2. core-ci voted on patch set 1 V +1 10/22/25, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87273

  3. Sven Liebert voted on patch set 1 CR +1 V +1 10/22/25, 18:28

  4. Georg Ringer voted on patch set 1 CR +1 V +1 10/22/25, 21:03

  5. Benjamin Franzke commented on patch set 1 CR -1 10/22/25, 21:09

    new-record-wizard.ts:572

    This "looks" like it helps for visual impairment, but it actually does not, because the placeholder is used as an accessible name by all screenreaders, that means this change should not change screenreader output at all. (Can easily be verified using the chrome accessibility tree, which shows "Search for any content type" as accessible name for the searchbox without this patch.) Missing labels are actually not really an issue for screenreaders (e.g. visual impairment), but needed for users with cognitive impairment, see section "target group" in https://forge.typo3.org/issues/107718 That means we probably need a permanently visible label here.
  6. Lina Wolf commented on patch set 1 10/23/25, 07:51

  7. Lina Wolf marked it work in progress 10/23/25, 07:51

  8. Lina Wolf abandoned the change 11/05/25, 13:39

    A different solution is needed