Review main Merged

91214[BUGFIX] Streamline pseudo button behavior

Benjamin Franzke CR +2 V +2 Hard +130 −353 updated 11/10/25, 08:33

Commit message

Ensure that SPACE activates on keyup, and ENTER
on keydown, as every browser vendor/OS does for
native buttons.

Also make sure to share code to avoid discrepancies
and to ease maintenance.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 25

Show 5 more files

Review log 1117

  1. Benjamin Franzke uploaded patch set 1 10/23/25, 07:27

  2. core-ci voted on patch set 1 V +1 10/23/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87381

  3. Benjamin Franzke uploaded patch set 2 V +1 10/29/25, 20:26

  4. core-ci voted on patch set 2 V +1 10/29/25, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88044

  5. Benjamin Franzke uploaded patch set 3 V +1 10/29/25, 20:42

  6. core-ci voted on patch set 3 V +1 10/29/25, 20:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88045

  7. Benjamin Franzke uploaded patch set 4 V +1 10/29/25, 21:16

  8. Benjamin Franzke uploaded patch set 5 10/29/25, 21:24

  9. core-ci voted on patch set 4 V +1 10/29/25, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88052

  10. core-ci voted on patch set 5 V +1 10/29/25, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88055

  11. Benjamin Franzke rebased onto patch set 6 V +1 11/08/25, 20:26

  12. core-ci voted on patch set 6 V +1 11/08/25, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88715

  13. Benjamin Kott voted on patch set 6 CR +1 V +1 11/09/25, 16:46

  14. Oli Bartsch voted on patch set 6 CR +1 V +1 11/10/25, 07:19

  15. Andreas Kienast voted on patch set 6 CR +1 V +1 11/10/25, 07:58

  16. Benjamin Kott voted on patch set 6 CR +2 V +2 11/10/25, 08:19

  17. Benjamin Kott merged patch set 7 11/10/25, 08:33