Review main Merged

91215[BUGFIX] Avoid ORDER BY from count queries in Webhooks/Reactions

Oli Bartsch CR +2 V +2 Easy +22 −18 updated 10/23/25, 08:33

Commit message

PostgreSQL is stricter than MySQL when it comes
to `GROUP BY` clauses and `ORDER BY` in count
queries. When using `count(*)` with `ORDER BY`
on a column that's not in the `GROUP BY` clause,
PostgreSQL throws an error.

The `ORDER BY` clause is unnecessary for count
queries and can cause compatibility issues with
PostgreSQL. This change adds an optional parameter
to skip `ORDER BY` when counting records.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Oli Bartsch uploaded patch set 1 10/23/25, 07:29

  2. core-ci voted on patch set 1 V +1 10/23/25, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87382

  3. Oli Bartsch commented on patch set 1 10/23/25, 07:39

  4. core-ci commented on patch set 1 10/23/25, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87383

  5. Oli Bartsch commented on patch set 1 10/23/25, 08:02

    Reply

    Passed.
  6. Oliver Klee voted on patch set 1 CR +1 10/23/25, 08:04

  7. Garvin Hicking voted on patch set 1 CR +1 V +1 10/23/25, 08:20

  8. Stefan Bürk voted on patch set 1 CR +1 V +1 10/23/25, 08:24

  9. Oli Bartsch voted on patch set 1 CR +2 V +2 10/23/25, 08:33

  10. Oli Bartsch merged patch set 2 10/23/25, 08:33