Review main Merged

91223[TASK] Add text alternative for tree options menu

Marno Schmigotzki CR +2 V +2 Easy +10 −2 updated 10/27/25, 19:26

Commit message

Add an aria label for the options menu in the tree
structure, which is commonly used, as well as to the
page tree, to describe the functionality of this
button and improve accessibility.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Elias Häußler +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1521

  1. Marno Schmigotzki uploaded patch set 1 10/23/25, 11:13

  2. Marno Schmigotzki updated the commit message in patch set 2 10/23/25, 11:18

  3. Marno Schmigotzki updated the commit message in patch set 3 10/23/25, 11:19

  4. core-ci voted on patch set 1 V +1 10/23/25, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87407

  5. core-ci voted on patch set 2 V +1 10/23/25, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87409

  6. core-ci voted on patch set 3 V +1 10/23/25, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87410

  7. Oli Bartsch commented on patch set 3 10/23/25, 12:00

    tree-toolbar.ts:62

    I think we can't add this here, because this is the main tree-toolbar component, which is the base for every tree in the backend. Although, page-tree overwrites the toolbar. Saying this, we should also add such label to the page-tree.
  8. Benjamin Franzke wrote 10/23/25, 12:05

    Hashtag added: tas2025
  9. Marno Schmigotzki commented on patch set 3 10/23/25, 12:32

    tree-toolbar.ts:62 Reply

    Thanks for your feedback. I can add this to the page tree (if it's not out of scope). And I will take another look at the general tree.
  10. Marno Schmigotzki uploaded patch set 4 V +1 10/23/25, 12:53

  11. Marno Schmigotzki commented on patch set 4 10/23/25, 12:55

    tree-toolbar.ts:62 Reply

    I added the label for the page tree and generalised the label for the general tree. Maybe that's a good solution.
  12. Oli Bartsch commented on patch set 4 10/23/25, 13:01

    tree-toolbar.ts:62 Reply

    Looks good but now the file tree has no specific label. But would also be fine for me to not overwrite the whole toolbar component for file tree just because of the aria label.
  13. core-ci voted on patch set 4 V +1 10/23/25, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87423

  14. Simon Schaufelberger updated the commit message in patch set 5 V +1 10/26/25, 16:58

  15. core-ci voted on patch set 5 V +1 10/26/25, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87598

  16. Elias Häußler uploaded patch set 6 V +1 10/27/25, 18:45

  17. Elias Häußler voted on patch set 6 CR +1 10/27/25, 18:45

  18. Elias Häußler voted on patch set 6 V +1 10/27/25, 18:47

  19. core-ci voted on patch set 6 V +1 10/27/25, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87715

  20. Benjamin Franzke commented on patch set 6 CR +2 V +2 10/27/25, 19:05

    tree-toolbar.ts:62 Reply

    Done
  21. Benjamin Franzke merged patch set 7 10/27/25, 19:26