91225[BUGFIX] Harden `MathUtility::canBeInterpretedAsInteger()` for `PHP8.5`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Markus Klein +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Markus Klein +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 2328
Show 23 earlier messages
-
Stefan Bürk uploaded patch set 1 10/23/25, 12:46
-
core-ci voted on patch set 1 V +1 10/23/25, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87422
-
Stefan Bürk uploaded patch set 2
V +110/23/25, 13:49
-
Stefan Bürk updated the commit message in patch set 3 10/23/25, 13:49
-
core-ci voted on patch set 3 V +1 10/23/25, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87428
-
Stefan Bürk marked it ready for review 10/23/25, 14:09
-
Oliver Klee voted on patch set 3 CR +1 V +1 10/23/25, 14:26
-
Oliver Klee updated the commit message in patch set 4
CR +1V +110/23/25, 14:27 -
Oliver Klee voted on patch set 4 CR +1 V +1 10/23/25, 14:27
-
core-ci voted on patch set 4 V +1 10/23/25, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87433
-
Garvin Hicking commented on patch set 4 10/23/25, 14:39
MathUtility.php:79```suggestion // can look weird here but is required to avoid enforced casting issues ``` -
Oliver Hader commented on patch set 4 10/23/25, 14:58
MathUtility.php:74ReplyFix applied.MathUtility.php:79ReplyFix applied. -
Oliver Hader commented on patch set 5
CR +1V +110/23/25, 14:58Published edit on patch set 4. -
Oliver Hader voted on patch set 5 CR +1 V +1 10/23/25, 14:59
-
Oliver Hader commented on patch set 5 10/23/25, 14:59
This is much clearer now. Thanks! -
Oliver Klee voted on patch set 5 CR +1 V +1 10/23/25, 15:02
-
core-ci voted on patch set 5 V +1 10/23/25, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87434
-
Stephan Großberndt voted on patch set 5 CR +1 10/23/25, 17:10
-
Elias Häußler commented on patch set 5 10/23/25, 18:07
I assume this should be https://github.com/sbuerk/mathutility-preg-match-bench/blob/main/plain-benchmark.php (or even better https://github.com/sbuerk/mathutility-preg-match-bench/blob/58d03f60e3ad3142d15e7ac3221527395ab9cd55/plain-benchmark.php)? The current link leads to a 404 page. -
Markus Klein voted on patch set 5 CR +1 V +1 10/23/25, 18:08
-
Stefan Bürk updated the commit message in patch set 6
CR +1V +110/23/25, 21:57 -
Stefan Bürk commented on patch set 6 10/23/25, 22:01
Reply
Yeah thanks ... fixed that. It nagged me to loose the votes but having that wrong was not an option. Beside that, @markus.klein@typo3.org also mentioned the wrong named "scale" in the commit message ... it's `only million` instead of `billion`, but still impressive enough and way above real world usage so fixing that along the way. -
core-ci voted on patch set 6 V +1 10/23/25, 22:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87450
-
Oliver Klee voted on patch set 6 CR +1 V +1 10/24/25, 07:22
-
Markus Klein voted on patch set 6 CR +1 V +1 10/24/25, 07:23
-
Benni Mack voted on patch set 6 CR +1 V +1 10/24/25, 11:28
-
Stefan Bürk voted on patch set 6 CR +2 V +2 10/24/25, 12:14
-
Stefan Bürk merged patch set 7 10/24/25, 12:27
MathUtility.php:74