Review main Merged

91229[TASK] Ignore all files in Build/composer

Helmut Hummel CR +2 V +2 Easy +3 −6 updated 10/27/25, 16:14

Commit message

For more extensive tests it would be useful that all files
in that folder are ignored,
except the ones currently in version control.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Helmut Hummel uploaded patch set 1 10/23/25, 19:40

  2. Helmut Hummel commented on patch set 1 10/23/25, 19:45

    @markus.klein@typo3.org Feel free to review here 😊
  3. core-ci voted on patch set 1 V +1 10/23/25, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87443

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 10/27/25, 12:56

  5. Lina Wolf commented on patch set 1 CR +1 V +1 10/27/25, 13:03

    gitignore change looks good to me, tested by randomly adding previously mentioned files or folders, verified they are still excluded
  6. Stefan Bürk commented on patch set 1 CR +1 V +1 10/27/25, 13:33

    Should we not make that also in 13.4/12.4 ?
  7. Christian Kuhn commented on patch set 1 CR +2 V +2 10/27/25, 16:14

    Reply

    with most development happening on main, this change may not be *that* important in other branches. could be additionally picked later if it turns out to be needed. shouldn't matter much.
  8. Christian Kuhn merged patch set 2 10/27/25, 16:14