91236[FEATURE] Provide content statistics report
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Garvin Hicking +1
- Anja Leichsenring +1
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Garvin Hicking +1
- Anja Leichsenring +1
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-107940-IntroduceReportAboutContentTypeUsage.rstnew+46 −0
- typo3/sysext/reports/Classes/Controller/ContentStatisticsController.php8new+88 −0
- typo3/sysext/reports/Classes/Service/ContentStatisticsService.php44new+182 −0
- typo3/sysext/reports/Configuration/Backend/Modules.php+17 −0
- typo3/sysext/reports/Resources/Private/Language/locallang.xlf5+57 −0
- typo3/sysext/reports/Resources/Private/Templates/ContentStatistics.fluid.htmlnew+115 −0
- typo3/sysext/reports/Resources/Private/Templates/ContentStatisticsDetail.fluid.htmlnew+176 −0
Review log 7096
Show 4971 earlier messages
-
Georg Ringer uploaded patch set 1 10/24/25, 07:08
-
core-ci voted on patch set 1 V -1 10/24/25, 07:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87471
-
Georg Ringer uploaded patch set 2
V -110/27/25, 13:40 -
core-ci voted on patch set 2 V -1 10/27/25, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87661
-
Georg Ringer uploaded patch set 3
V -110/27/25, 17:21 -
core-ci voted on patch set 3 V -1 10/27/25, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87693
-
Georg Ringer uploaded patch set 4
V -110/29/25, 18:05 -
core-ci voted on patch set 4 V -1 10/29/25, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88026
-
Garvin Hicking commented on patch set 4 10/29/25, 21:37
I love what this does to allow "judging" setups and introspect them to do auditing or analysis of complexity. I do think the current UI is a bit overwhelming, and probably sorting capabilities would help, or some kind of "tabbing" to differentiate between the output. Maybe a CLI command for this (JSON output?) would also be helpful, especially if the evaluation takes some longer time? The collapsing and toggling already helps a lot. I think having the icon bars repeat the icon of a CType is more confusing than it helps, I think a plain number indicator would suit better. Minor things: We should directly use the new domain translation keys here, and use the ComponentFactory for the Button API. I would love for this to go forward. -
Georg Ringer uploaded patch set 5
V -110/30/25, 05:41 -
core-ci voted on patch set 5 V -1 10/30/25, 05:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88078
-
Georg Ringer uploaded patch set 6
V -110/30/25, 14:35 -
core-ci voted on patch set 6 V -1 10/30/25, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88155
-
Georg Ringer uploaded patch set 7
V -110/30/25, 16:06 -
core-ci voted on patch set 7 V -1 10/30/25, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88166
-
Josef Glatz commented on patch set 7 10/30/25, 16:31
ContentStatisticsController.php:60Would love to have the possibility to copy a direct url to the record detail view of a CType.locallang.xlf:61Should we also mention TCA changes based on FormDataProviders?ContentStatistics.html:54Is it possible to make the CType value selectable (copyable to clipbord)? -
Josef Glatz commented on patch set 7 10/30/25, 18:23
### Ordering of CTypes I like the ordering (often used → fewer used) ### UI - a detail view is crucial. especially when you want to share a detail view url to a colleague for example - as already discussed in private chat: i found no existing component to improve the UI. Improvements can always be made later. I think the primary goal is to have such an overview in the core builtin to gain a general understanding of which CTypes are used. -
Georg Ringer uploaded patch set 8
V -110/30/25, 19:41 -
core-ci voted on patch set 8 V +1 10/30/25, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88185
-
Josef Glatz uploaded patch set 9
V +110/30/25, 19:58 -
core-ci voted on patch set 9 V -1 10/30/25, 20:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88186
-
Josef Glatz uploaded patch set 10
V -110/30/25, 20:10 -
core-ci voted on patch set 10 V +1 10/30/25, 20:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88189
-
Josef Glatz uploaded patch set 11
V +110/30/25, 20:20 -
Josef Glatz commented on patch set 11 10/30/25, 20:22
ContentStatisticsController.php:60ReplyDone in patchset 11locallang.xlf:61Replydiscussed > we keep possibilities to a minimum in this infoContentStatistics.html:54ReplyAcknowledged > we can double click and copy it to clipboard in detailview -
Georg Ringer uploaded patch set 12 10/30/25, 20:24
-
core-ci voted on patch set 11 V +1 10/30/25, 20:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88191
-
core-ci voted on patch set 12 V +1 10/30/25, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88192
-
Georg Ringer uploaded patch set 13
V +110/30/25, 20:36 -
core-ci voted on patch set 13 V +1 10/30/25, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88194
-
Georg Ringer commented on patch set 13 10/30/25, 21:00
This change is ready for review. -
Garvin Hicking commented on patch set 13 10/30/25, 21:45
This is shaping up pretty nice. I think it is useful!ContentStatisticsService.php:91Methods can be private for the final class, and I believe should be called plural "statistics"ContentStatisticsService.php:169inject connectionpoolContentStatistics.html:10could use shorthand domain keys here?ContentStatisticsDetail.html:171missing l10n key -
Oli Bartsch commented on patch set 13 10/30/25, 21:48
Like the idea. Did a short read through but have to test in more detail.ContentStatisticsService.php:33I think this is not necessary because this service is not called via ::makeInstanceContentStatisticsService.php:72This might lead to ``` TYPO3\CMS\Core\Schema\Exception\UndefinedSchemaException ```ContentStatisticsService.php:140This does not respect workspacesContentStatisticsService.php:144Should be injected -
Georg Ringer commented on patch set 13 10/31/25, 05:54
ContentStatisticsService.php:33Replydid it just as in RecordStatisticServiceContentStatisticsService.php:72Replyhow likely is that with tt_content?ContentStatisticsService.php:91Replybut it is called in the controller?ContentStatisticsService.php:140Replywas by intend, but will change itContentStatisticsService.php:144Replyon itContentStatisticsService.php:169ReplyDone -
Georg Ringer uploaded patch set 14
V +110/31/25, 05:54 -
Georg Ringer commented on patch set 14 10/31/25, 05:55
ContentStatisticsService.php:148didn't add the workspacerestriction, IMO it is better that way, to really avoid having false positives? -
core-ci voted on patch set 14 V +1 10/31/25, 06:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88227
-
Garvin Hicking commented on patch set 14 10/31/25, 06:26
ContentStatisticsService.php:91Replymarked the wrong line I meant the protected ones ofc ;) -
Garvin Hicking commented on patch set 14 10/31/25, 06:27
ContentStatisticsService.php:148Replyhow about a toggle/checkbox like "[x] only evaluate published records" and only show it when workspaces are active? -
Stefan Froemken commented on patch set 15
V +110/31/25, 07:15Published edit on patch set 14. -
core-ci voted on patch set 15 V +1 10/31/25, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88230
-
Stefan Froemken commented on patch set 15 10/31/25, 07:58
ContentStatisticsService.php:33ReplyI was not needed in RecordStatisticService, too. I also prefer to remove the "public: true" -
Oli Bartsch commented on patch set 15 10/31/25, 08:02
ContentStatisticsService.php:72ReplyI actually encountered this. Otherwise I might have missed it.ContentStatisticsService.php:140ReplyI think it makes no sense to find workspace records in live workspace. -
Georg Ringer commented on patch set 15 10/31/25, 08:18
ContentStatisticsService.php:140ReplyI don't agree: if there is a new content element provided and editors start to use those in their workspace, the content element is already in use and that should be shown and not as unused. There can also be the other way that there is just outdated content in a workspace which might have even been removed. but maybe this encourages the maintainer to clean up better. Yes of course, there are editors who only hide stuff and never delete content (fear of needing it, no recycler available, seasonal content...) and also content of deleted parent pages is shown as enabled but this is a different story (dbdoctor) -
Garvin Hicking commented on patch set 15 10/31/25, 08:29
ContentStatisticsService.php:140ReplyI think for statistics it might be good to know that a planned workspace change is about to use an element that is not yet used "live". Otherwise one might think, an element is unused, but it is not. Having workspace records evaluated somehow is IMO important. -
Stefan Froemken commented on patch set 15 10/31/25, 08:39
ContentStatisticsController.php:69Not in every TYPO3 system the first root page is "1". IMO page is and should be a required parameter. If not given show a warning.ContentStatisticsService.php:42Nice to have. Implement them as "const"ContentStatisticsService.php:62Please move them to front. In core we do not have "||" at the end of a condition line.ContentStatisticsService.php:104We have an ArrayPaginator in Core. Isn't is usabe here?ContentStatisticsService.php:189Just a nice-to-have (upper-case): COUNT(CType) although: the column is not nullable, so COUNT(*) would fit better.ContentStatisticsService.php:189```suggestion ->addSelectLiteral('COUNT(*) as count') ```ContentStatisticsService.php:215```suggestion $counts[$ctype][$key] += $count; ```ContentStatisticsDetail.html:119Typo? ```suggestion <f:variable name="goToPageUrl"> ```ContentStatisticsDetail.html:130```suggestion data-url="{goToPageUrl}" /> ```ContentStatisticsDetail.html:154This is exactly the same than above. Do we need that?ContentStatisticsDetail.html:162nitpicking: In most cases you do not add any space between argument and value, but here you have added one, which is my personnel favorit. Please streamline them. -
Georg Ringer uploaded patch set 16
V +110/31/25, 08:59 -
Georg Ringer commented on patch set 16 10/31/25, 08:59
ContentStatisticsController.php:69Replythis is just the paginationContentStatisticsService.php:148ReplyIMO no. there might be a lot of elements which are marked as active but are not reachable - not even for an admin. imagine broken rootline, translated elements but the languag has been removed, inline relations to tt_content elements and parent removed ...ContentStatistics.html:10ReplyDone -
Georg Ringer commented on patch set 16 10/31/25, 09:02
ContentStatisticsService.php:42ReplyAcknowledgedContentStatisticsService.php:91ReplyDoneContentStatisticsService.php:148ReplyDoneContentStatisticsService.php:189ReplyDoneContentStatisticsService.php:189ReplyDoneContentStatisticsService.php:215ReplyDoneContentStatisticsDetail.html:119ReplyDoneContentStatisticsDetail.html:130ReplyDoneContentStatisticsDetail.html:154Replyyes IMHO we doContentStatisticsDetail.html:162ReplyDoneContentStatisticsDetail.html:171ReplyDone -
core-ci voted on patch set 16 V +1 10/31/25, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88234
-
Stefan Froemken commented on patch set 16 10/31/25, 09:31
ContentStatisticsService.php:108I would use empty() only, if I don't know the data type ```suggestion if ($ctype === '') { ``` -
Stefan Froemken commented on patch set 16 V -1 10/31/25, 09:36
Entries of table "Pages" does not have a column header as all the other tables. I prefer using "Title" -
Stefan Froemken commented on patch set 16 V 0 10/31/25, 09:41
Sorry. Content Statistics...and not Record Statistics. My fault -
Stefan Froemken commented on patch set 16 10/31/25, 09:50
locallang.xlf:67What do you want to achieve with this list? Seems you want to inform integrators to remove elements for the editors, as these elements are not in use. -
Georg Ringer commented on patch set 16 10/31/25, 10:56
locallang.xlf:67ReplyMultiple use cases: if you want to calculate an upgrade, this can be an entry point to look at, or maybe your you can discuss with the client that some elements can be removed or maybe should be used but permissions are missing Or you try to migrate away from html element and you see how many records are still using it and once all are deleted you can finally adopt the permissions -
Simon Schaufelberger commented on patch set 16 11/01/25, 18:05
ContentStatisticsController.php:38since the class is final, the Classes can be privateContentStatisticsController.php:86private -
Georg Ringer uploaded patch set 17
V +111/03/25, 20:52 -
Georg Ringer commented on patch set 17 11/03/25, 20:52
ContentStatisticsController.php:38ReplyDoneContentStatisticsController.php:86ReplyDone -
core-ci voted on patch set 17 V -1 11/03/25, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88418
-
Georg Ringer commented on patch set 18
V -111/03/25, 21:28Published edit on patch set 17. -
core-ci voted on patch set 18 V +1 11/03/25, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88419
-
Simon Schaufelberger uploaded patch set 19
V +101/17/26, 15:13 -
Simon Schaufelberger commented on patch set 19 01/17/26, 15:15
ContentStatisticsService.php:108ReplyDone -
core-ci voted on patch set 19 V +1 01/17/26, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93682
-
Georg Ringer uploaded patch set 20
V +101/23/26, 20:00 -
Simon Schaufelberger commented on patch set 20 01/23/26, 20:03
ContentStatisticsService.php:128would it be possible to use the Pagination API here from the core? -
core-ci voted on patch set 20 V +1 01/23/26, 20:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94204
-
Georg Ringer rebased onto patch set 21
V +102/24/26, 12:07 -
Georg Ringer uploaded patch set 22 02/24/26, 12:12
-
core-ci voted on patch set 22 V -1 02/24/26, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96724
-
core-ci voted on patch set 22 V +1 02/24/26, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96724
-
Stefan Froemken commented on patch set 22 02/24/26, 20:35
ContentStatisticsService.php:33ReplyDoneContentStatisticsService.php:62ReplyDonelocallang.xlf:67ReplyDone -
Stefan Froemken commented on patch set 22 02/24/26, 22:23
ContentStatisticsService.php:104ReplyDoneContentStatisticsService.php:128ReplyUntil now, we haven't had a QueryBuilder paginator in the core, so ArrayPagination always retrieves all available records, which might be very inefficient. -
Simon Schaufelberger commented on patch set 22 02/24/26, 23:03
ContentStatisticsService.php:128ReplyArrayPaginator doesn't do anything internal, you feed the items into it and it will do the rest. I'm just thinking if ArrayPaginator could be used here instead of doing everything by hand which ArrayPaginator already does for you. -
Garvin Hicking uploaded patch set 23
V +103/06/26, 11:55 -
Garvin Hicking commented on patch set 23 CR +1 V +1 03/06/26, 11:56
ContentStatisticsService.php:72ReplyAdded to intercept this case now, even if unlikely.ContentStatisticsService.php:128ReplyI think we can leave it like that for now, can be part of a follow-up or maybe CTE integration.ContentStatisticsService.php:140Reply(I'm resolving this, asked Oli privately if there are hard objections to move forward with this patch, to which he had none) -
core-ci voted on patch set 23 V +1 03/06/26, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97491
-
Georg Ringer uploaded patch set 24
CR +1V +103/06/26, 12:45 -
Garvin Hicking uploaded patch set 25 03/06/26, 12:59
Add location hash position jump to result table -
Garvin Hicking voted on patch set 25 CR +1 V +1 03/06/26, 13:00
-
core-ci voted on patch set 24 V +1 03/06/26, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97500
-
Simon Schaufelberger voted on patch set 25 CR +1 V +1 03/06/26, 13:10
-
core-ci voted on patch set 25 V +1 03/06/26, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97506
-
Stefan Froemken commented on patch set 25 03/10/26, 07:49
If I open details of CE "header" the path looks like that: / Home/ Files/ Can we somehow prevent the first return after "/"? -
Stefan Froemken commented on patch set 25 03/10/26, 07:58
This feature just shows the number of records. There is no grouping by translation like known from list/records module. For me, that's not a problem. The german record may exists on pagebrowser site 2 and the related translation of that record on page 32. -
Georg Ringer commented on patch set 25 03/10/26, 08:28
grouping cant beReply
grouping can't be done, thinking of multi sites with different sites -
Josef Glatz voted on patch set 25 CR +1 V +1 03/10/26, 09:03
-
Anja Leichsenring uploaded patch set 26
CR +1V +103/10/26, 19:40 -
Anja Leichsenring voted on patch set 26 CR +1 V +1 03/10/26, 19:45
-
core-ci voted on patch set 26 V +1 03/10/26, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97715
-
Simon Schaufelberger voted on patch set 26 CR +1 V +1 03/10/26, 19:51
-
Garvin Hicking voted on patch set 26 CR +1 V +1 03/10/26, 19:58
-
Benni Mack voted on patch set 26 CR +1 V +1 03/11/26, 08:24
-
Oli Bartsch voted on patch set 26 CR +1 V +1 03/11/26, 08:33
-
Georg Ringer voted on patch set 26 CR +2 V +2 03/11/26, 08:38
-
Georg Ringer merged patch set 27 03/11/26, 08:38