91237[TASK] Make GreedyDatabaseBackend more sophisticated
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Garvin Hicking +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2431
Show 36 earlier messages
-
Nikita Hovratov uploaded patch set 1 10/24/25, 10:33
-
Nikita Hovratov uploaded patch set 2 10/24/25, 10:35
-
core-ci voted on patch set 1 V -1 10/24/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87485
-
core-ci voted on patch set 2 V +1 10/24/25, 10:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87486
-
Nikita Hovratov uploaded patch set 3
V +112/09/25, 17:54 -
core-ci voted on patch set 3 V -1 12/09/25, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91923
-
Nikita Hovratov uploaded patch set 4
V -112/09/25, 19:41 -
core-ci voted on patch set 4 V +1 12/09/25, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91929
-
Tobias Gaertner commented on patch set 4 V +1 12/10/25, 08:23
I tested the patch and it solves a huge performance issue we faced with nested object structure in content-blocks. -
Nikita Hovratov rebased onto patch set 5
V +102/27/26, 17:19 -
core-ci voted on patch set 5 V +1 02/27/26, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96985
-
Nikita Hovratov rebased onto patch set 6
V +103/10/26, 07:46 -
core-ci voted on patch set 6 V +1 03/10/26, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97653
-
Georg Ringer voted on patch set 6 CR +1 V +1 03/11/26, 09:18
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 03/11/26, 11:14
-
Simon Schaufelberger commented on patch set 6 CR 0 V 0 03/11/26, 11:19
GreedyDatabaseBackend.php:105just by reading I don't really understand what is going on and what "pointer" here means. Can this be explained as there are 2 different kind of identifiers used.GreedyDatabaseBackend.php:168return can be inlined -
Georg Ringer commented on patch set 6 CR 0 V -1 03/11/26, 11:35
GreedyDatabaseBackend.php:108getting in backend preg_match(): Argument #2 ($subject) must be of type string, array given in line 111 (v13): if ($this->runtimeCache->has($cacheIdentifier)) { -
Nikita Hovratov commented on patch set 6 03/11/26, 11:36
GreedyDatabaseBackend.php:105Reply"cache-identifier-pointer-1" => "cache-identifier-1" "cache-identifier-pointer-2" => "cache-identifier-1" "cache-identifier-pointer-3" => "cache-identifier-2" "cache-identifier-pointer-4" => "cache-identifier-2" "cache-identifier-1" => array<DB Row> "cache-identifier-2" => array<DB Row 2>GreedyDatabaseBackend.php:168ReplyI don't like to inline such things for debugging purposes. -
Nikita Hovratov commented on patch set 6 03/11/26, 11:38
GreedyDatabaseBackend.php:108ReplyCan you debug, what's inside $cacheIdentifier? This should be always a string. -
Nikita Hovratov commented on patch set 6 03/11/26, 11:43
GreedyDatabaseBackend.php:105ReplyThis is the main change here. So instead of caching the db rows for each new uid, we cache the pointer to that identifier. -
Georg Ringer commented on patch set 6 CR +1 V +1 03/11/26, 11:55
it was my fault, sry :( -
Simon Schaufelberger commented on patch set 6 03/11/26, 11:57
GreedyDatabaseBackend.php:105Replyplease add a doc header comment that explains a bit what is going on.GreedyDatabaseBackend.php:168Replyxdebug supports debugging return types since long time now. -
Nikita Hovratov commented on patch set 6 03/11/26, 12:42
GreedyDatabaseBackend.php:105ReplyI can add one, np.GreedyDatabaseBackend.php:168ReplyI know, it's just a preference. As there is no code guideline enforcing this, I would like to keep it. -
Nikita Hovratov uploaded patch set 7
CR +1V +103/11/26, 13:44 -
Nikita Hovratov commented on patch set 7 03/11/26, 13:45
GreedyDatabaseBackend.php:105ReplyDone -
Nikita Hovratov commented on patch set 7 03/11/26, 13:45
GreedyDatabaseBackend.php:108ReplyDone -
core-ci voted on patch set 7 V +1 03/11/26, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97762
-
Simon Schaufelberger commented on patch set 7 CR +1 03/11/26, 14:51
GreedyDatabaseBackend.php:168ReplyDone -
Garvin Hicking voted on patch set 7 CR +1 V +1 03/11/26, 16:47
-
Anja Leichsenring voted on patch set 7 CR +2 V +2 03/11/26, 19:07
-
Anja Leichsenring merged patch set 8 03/11/26, 19:07