91241[BUGFIX] Sort forms across all pages
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Sven Liebert +1
-
Verified V +2 Done
- Garvin Hicking +2
- Georg Ringer +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/form/backend/form-manager/view-model.ts+0 −9
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-107342-ExtendListFormsMethodInFormPersistenceManagerInterface.rstnew+31 −0
- typo3/sysext/form/Classes/Controller/FormManagerController.php+7 −4
- typo3/sysext/form/Classes/Enum/SortDirection.php3new+27 −0
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php5+10 −5
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManagerInterface.php8+2 −1
- typo3/sysext/form/Resources/Private/Partials/Backend/FormManager/Pagination.html+6 −6
- typo3/sysext/form/Resources/Private/Templates/Backend/FormManager/Index.html+86 −7
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+1 −1
Review log 2430
Show 35 earlier messages
-
Josua Vogel uploaded patch set 1 10/24/25, 13:48
-
core-ci voted on patch set 1 V +1 10/24/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87505
-
Josua Vogel uploaded patch set 2
V +110/24/25, 14:34 -
core-ci voted on patch set 2 V +1 10/24/25, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87512
-
Josua Vogel updated the commit message in patch set 3
V +110/24/25, 14:46
-
Simon Schaufelberger commented on patch set 3 10/24/25, 14:49
-
core-ci voted on patch set 3 V +1 10/24/25, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87515
-
Josua Vogel commented on patch set 3 10/24/25, 14:57
SortDirection.php:23ReplyI wasn't sure if that was desirable. What´s you opinion @bo@cedev.de? -
Garvin Hicking commented on patch set 3 10/24/25, 15:01
SortDirection.php:23ReplyNote that EXT:filelist also has its own enum SortDirection. So does EXT:reactions ReactionDemand. And EXT:extbase QueryInterface And EXT:webhooks WebhookDemand So... maybe worth to unify this as one central ENUM in main. I think due to the other instances it's ok to have it in EXT:form in the scope of this patch. -
Garvin Hicking commented on patch set 3 10/24/25, 15:08
FormPersistenceManager.php:787If I read this right, the order field is now user-submitted. While sortByKeys definitions of persistence manager would require someone to have access to the configuration, with this an editor could sort by arbitrary keys here. We should ensure that only "allowed" fields can be specified here. I am not sure though how we can get a list of these easily. Probably just "form name", "locaiton", "references", "integrity" (don't know how those fields are internally called) -
Garvin Hicking commented on patch set 3 10/24/25, 15:12
FormPersistenceManagerInterface.php:33I see this is attributed 'internal', but I think I've seen instances of this that replace the persistencemanager, but not sure I remember. Do you think it's possible developers/integrators replace this interface with custom implementations? Because if so, we might want to make this main only, not breaking, but adding an Important.rst file to notify of change to this interface? (Otherwise, maybe we can inject the order fields/direction the the instance, and not carry it with the interface method...) -
Josua Vogel commented on patch set 3 10/24/25, 15:36
FormPersistenceManager.php:787ReplyWhy should we allow specific fields? If the user manipulates the request and sorts by another field, it won´t have an effect (btw the forms object has about 9 keys). I can see no issueFormPersistenceManagerInterface.php:33ReplyYes, that´s possible. I did that in one of my projects 😊 but it´s internal and not part of the public API. Is there a way to communicate this change in v13? -
Garvin Hicking commented on patch set 3 10/24/25, 15:58
FormPersistenceManager.php:787ReplyUnderstood. So manipulating the request and hsing invalid keys won't throw exceptions and there's no "protectworthy" attributes involved? Not deep enough into this.FormPersistenceManagerInterface.php:33ReplyI think adding this in an Important.rst could be ok, I just can't judge the impact this might have on LTS instances. -
Josua Vogel commented on patch set 3 10/24/25, 16:29
FormPersistenceManager.php:787Replyno protectworthy attributes and the sort function checks, if a key is setFormPersistenceManagerInterface.php:33Replymy guess: Fatal error 😊 but it´s an internal class, so everyone should know the risk. I would add an Important.rst, if you are fine with it? -
Josua Vogel uploaded patch set 4
V +110/24/25, 16:42 -
core-ci voted on patch set 4 V +1 10/24/25, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87528
-
Garvin Hicking commented on patch set 4 10/24/25, 16:58
FormPersistenceManager.php:787ReplyAcknowledgedFormPersistenceManagerInterface.php:33ReplyHehe, I more meant like "are 0,001% of ext:form users affected or "anyone who extends ext:form probably does this" and affect a larger crowd. Let me sleep on it, but if no one objects I think an Important.rst would make me feel better and vote for this, yeah. 😅 -
Simon Schaufelberger commented on patch set 4 10/24/25, 17:52
Important-107342-SortFormsAcrossAllPages.rst:6This should be a speaking title (with spaces) -
Josua Vogel commented on patch set 4 10/24/25, 17:54
FormPersistenceManagerInterface.php:33Replyalright :) I think only a small number will be affected. I have exactly one project with very special ext:Form needs But IMO it would be better to communicate the change - a little service to everyone -
Josua Vogel uploaded patch set 5
V +110/27/25, 17:56 -
Josua Vogel commented on patch set 5 10/27/25, 17:56
Important-107342-SortFormsAcrossAllPages.rst:6ReplyDoneFormPersistenceManagerInterface.php:33ReplyDone -
Josua Vogel rebased onto patch set 6 10/27/25, 18:02
-
Garvin Hicking commented on patch set 6 CR +1 V +1 10/27/25, 18:04
FormPersistenceManagerInterface.php:33ReplyThank you. I think this is fair to do with the notice, given it's internal. -
Georg Ringer commented on patch set 6 CR +1 V -1 10/27/25, 18:09
can we please get, like in the list module, an active state and maybe even an active state icon next to the label? -
core-ci voted on patch set 5 V +1 10/27/25, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87703
-
Georg Ringer commented on patch set 6 V +1 10/27/25, 18:18
thanks, sorry works now for me as well. awesome that you worked on that issue!! -
core-ci voted on patch set 6 V +1 10/27/25, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87707
-
Sven Liebert voted on patch set 6 CR +1 V +1 10/27/25, 18:24
-
Garvin Hicking voted on patch set 6 CR +2 V +2 10/30/25, 12:56
-
Garvin Hicking merged patch set 7 10/30/25, 13:57
SortDirection.php:23