Review main Merged

91247[TASK] Use ext:core template file in FE PageRenderer

Christian Kuhn CR +2 V +2 Easy +9 −39 updated 10/25/25, 10:09

Commit message

PageRenderer still uses 'marker based templating' for
the main HTTP response body. The template file can be
reset using a TypoScript property. The default in FE
is actively set to
'frontend/Resources/Private/Templates/MainPage.html'
while the core default is
'core/Resources/Private/Templates/PageRenderer.html'.

The two files are identical except a line break. The
patch avoids setting the FE default leading to the
ext:core fallback, and removes the `setTemplateFile()`
calls.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 913

  1. Christian Kuhn uploaded patch set 1 10/25/25, 01:12

  2. core-ci voted on patch set 1 V -1 10/25/25, 01:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87543

  3. Christian Kuhn uploaded patch set 2 V -1 10/25/25, 01:24

  4. core-ci voted on patch set 2 V -1 10/25/25, 01:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87544

  5. Christian Kuhn uploaded patch set 3 V -1 10/25/25, 02:28

  6. core-ci voted on patch set 3 V +1 10/25/25, 02:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87549

  7. Oliver Klee updated the commit message in patch set 4 V +1 10/25/25, 07:38

  8. Oliver Klee voted on patch set 4 CR +1 V +1 10/25/25, 07:39

  9. core-ci voted on patch set 4 V +1 10/25/25, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87562

  10. Benni Mack voted on patch set 4 CR +1 V +1 10/25/25, 10:01

  11. Garvin Hicking voted on patch set 4 CR +1 V +1 10/25/25, 10:08

  12. Christian Kuhn voted on patch set 4 CR +2 V +2 10/25/25, 10:09

  13. Christian Kuhn merged patch set 5 10/25/25, 10:09