Review main Merged

91248[TASK] Declare ContentObjecRenderer stdWrapOrder constant

Christian Kuhn CR +2 V +2 Easy +14 −18 updated 10/25/25, 10:12

Commit message

This property is not and should never be written. It is
now redeclared constant, protected and renamed.

The motivation for this is that ContentObjectRenderer
is stored as serialized string in cache_pages as part
of the rendering state for each non cached content
element ("INT" objects). Having this rather huge array
declared constant avoids this state being part of the
serialized string, making cache_pages rows smaller.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Christian Kuhn uploaded patch set 1 10/25/25, 02:02

  2. core-ci voted on patch set 1 V +1 10/25/25, 02:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87545

  3. Christian Kuhn updated the commit message in patch set 2 V +1 10/25/25, 02:35

  4. Christian Kuhn updated the commit message in patch set 3 10/25/25, 02:36

  5. Christian Kuhn updated the commit message in patch set 4 10/25/25, 02:39

  6. core-ci voted on patch set 2 V +1 10/25/25, 02:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87550

  7. core-ci voted on patch set 3 V +1 10/25/25, 02:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87551

  8. core-ci voted on patch set 4 V +1 10/25/25, 02:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87552

  9. Oliver Klee voted on patch set 4 CR +1 V +1 10/25/25, 07:40

  10. Benni Mack commented on patch set 4 CR +1 V +1 10/25/25, 10:03

    great change, thanks for looking into it
  11. Garvin Hicking voted on patch set 4 CR +1 V +1 10/25/25, 10:10

  12. Christian Kuhn voted on patch set 4 CR +2 V +2 10/25/25, 10:11

  13. Christian Kuhn merged patch set 5 10/25/25, 10:12