Review main Merged

91252[DOCS] Follow-up changes to documentation of System Resource API

Garvin Hicking CR +2 V +2 Normal +156 −63 updated 11/10/25, 12:43

Commit message

This patch addresses some minor details in the System Resource API
documentation.

It also streamlines to use "URI" and "URL" (uppercase) in user-facing
output.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Lina Wolf +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Lina Wolf +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 2

Files 18

Review log 2635

Show 710 earlier messages
  1. Garvin Hicking uploaded patch set 1 10/25/25, 20:26

  2. core-ci voted on patch set 1 V -1 10/25/25, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87573

  3. Garvin Hicking uploaded patch set 2 V -1 10/25/25, 20:41

  4. Garvin Hicking commented on patch set 2 10/25/25, 20:46

    composer.json:28

    I think this description could use further improvement... 😄
  5. core-ci voted on patch set 2 V +1 10/25/25, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87574

  6. Nikita Hovratov commented on patch set 2 10/25/25, 21:14

    Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:124

    tht the ```suggestion It is highly recommended to switch the FAL resource and App resource syntax ```
  7. Garvin Hicking commented on patch set 3 V +1 10/25/25, 21:26

    Published edit on patch set 2.
  8. Garvin Hicking commented on patch set 4 10/25/25, 21:28

    Published edit on patch set 3.
  9. Garvin Hicking commented on patch set 4 10/25/25, 21:29

    Feature-107537-SystemResourceAPIForSystemFileAccessAndPublicUriGeneration.rst:124 Reply

    Thanks! It was actually "to the" :-)
  10. core-ci voted on patch set 3 V +1 10/25/25, 21:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87575

  1. core-ci voted on patch set 4 V +1 10/25/25, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87576

  2. Christian Kuhn commented on patch set 4 10/27/25, 11:28

    Deprecation-107537-CreateVersionNumberedFileName.rst:80

    this is well ... half correct. (helmut may want to check this again). if i understood correctly the idea is like that: you usually have the request and pass it. if not, the globals typo3-request is a fallback that will vanish at some point. so no, it's not ok to not pass it. when the consumer is in an environment where request is not available (low level cli. note 'generating a FE mail' is NOT low level and such things need a request for site and other stuff being set up), *then* it is ok to explicitly pass null, and this will then (later) not be substituted with globals request anymore.

    Deprecation-107537-FilePathSanitizer.rst:84

    if we adapt the other one, this one will be removed, too.

    Deprecation-107537-getPublicResourcesWebPath.rst:67

    similar.
  3. Helmut Hummel uploaded patch set 5 V +1 10/27/25, 13:20

  4. Helmut Hummel commented on patch set 4 10/27/25, 13:20

    Deprecation-107537-CreateVersionNumberedFileName.rst:80 Reply

    Done

    Deprecation-107537-FilePathSanitizer.rst:84 Reply

    Done

    Deprecation-107537-getPublicResourcesWebPath.rst:67 Reply

    Done
  5. core-ci voted on patch set 5 V +1 10/27/25, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87657

  6. Garvin Hicking uploaded patch set 6 V +1 10/27/25, 14:48

  7. Garvin Hicking commented on patch set 6 10/27/25, 14:48

    Deprecation-107537-CreateVersionNumberedFileName.rst:80 Reply

    Thanks, that's much better. Fixed a small typo.
  8. core-ci voted on patch set 6 V +1 10/27/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87668

  9. Lina Wolf commented on patch set 6 11/01/25, 08:22

    composer.json:28

    ```suggestion "typo3/cms-install": "Displays a link to the Environment module in the System Information toolbar." ```
  10. Garvin Hicking commented on patch set 6 11/01/25, 10:10

    composer.json:28 Reply

    but its not only a link, and not only environment card?!
  11. Helmut Hummel uploaded patch set 7 V +1 11/10/25, 10:15

  12. Helmut Hummel commented on patch set 7 11/10/25, 10:20

    composer.json:28 Reply

    Done

    composer.json:28 Reply

    judging from this, that is all what this suggest is about. https://review.typo3.org/c/Packages/TYPO3.CMS/+/61999
  13. Helmut Hummel uploaded patch set 8 11/10/25, 10:20

  14. core-ci voted on patch set 7 V +1 11/10/25, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88819

  15. core-ci voted on patch set 8 V +1 11/10/25, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88821

  16. Oliver Klee voted on patch set 8 CR +1 V +1 11/10/25, 10:41

  17. Lina Wolf voted on patch set 8 CR +1 11/10/25, 10:53

  18. Lina Wolf voted on patch set 8 V +1 11/10/25, 10:53

  19. Garvin Hicking uploaded patch set 9 CR +1 V +1 11/10/25, 11:16

  20. core-ci voted on patch set 9 V +1 11/10/25, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88834

  21. Oliver Klee voted on patch set 9 CR +1 V +1 11/10/25, 11:24

  22. Helmut Hummel voted on patch set 9 CR +1 V +1 11/10/25, 12:11

  23. Lina Wolf voted on patch set 9 CR +1 V +1 11/10/25, 12:17

  24. Garvin Hicking commented on patch set 9 CR +2 V +2 11/10/25, 12:43

    Thank you all! 😊
  25. Garvin Hicking merged patch set 10 11/10/25, 12:43