Review main Merged

91253[BUGFIX] Translation domain syntax takes precedence

Lina Wolf CR +2 V +2 Easy +32 −13 updated 10/29/25, 14:45

Commit message

This change ensures that a combined translation domain
label in <f:translate> ViewHelper is used when
also setting a default value.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 2024

  1. Lina Wolf uploaded patch set 1 10/26/25, 11:01

  2. Lina Wolf updated the commit message in patch set 2 10/26/25, 11:02

  3. core-ci voted on patch set 1 V +1 10/26/25, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87591

  4. core-ci voted on patch set 2 V +1 10/26/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87592

  5. Lina Wolf uploaded patch set 3 V +1 10/26/25, 11:27

  6. core-ci voted on patch set 3 V +1 10/26/25, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87593

  7. Benni Mack updated the commit message in patch set 4 V +1 10/26/25, 14:04

  8. Benni Mack voted on patch set 4 CR +1 V +1 10/26/25, 14:05

  9. core-ci voted on patch set 4 V +1 10/26/25, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87597

  10. Garvin Hicking commented on patch set 4 CR +2 V +2 10/26/25, 14:13

    nice find!
  11. Garvin Hicking merged patch set 5 10/26/25, 14:14

  12. Jasmina Ließmann commented on patch set 5 10/29/25, 12:03

    Unfortunately, this change breaks the "Backend Users" > "Backend user details" (show) view. ``` (1/1) #1639828178 RuntimeException ViewHelper f:translate in non-extbase context needs attribute "domain" or "extensionName" to resolve key="Form engine - inline 1:1 with relation filed on parent side" without path. Either set attribute "domain" or "extensionName" together with the short key "yourKey" to result or (better) use a full LLL reference like key="LLL:your_extension.name:yourKey". Alternatively, you can also define a default value. ```
  13. Jasmina Ließmann commented on patch set 5 10/29/25, 12:04

    Reply

    (and "Backend user groups" as well). And maybe other places?
  14. Lina Wolf commented on patch set 5 10/29/25, 12:16

    Reply

    Are you sure the error was caused by this change, not by the original one (https://forge.typo3.org/issues/107759)?
  15. Jasmina Ließmann commented on patch set 5 10/29/25, 12:30

    Reply

    It's the one `git bisect` identifies as the cause.
  16. Lina Wolf commented on patch set 5 10/29/25, 12:35

    Reply

    So there is an automatic test that is failing now?
  17. Garvin Hicking commented on patch set 5 10/29/25, 13:25

    Hm, this works for me in my v14 checkout? Did you clear caches and do composer install in your setup? Can you tell me more specifically what you do to raise the error? Maybe also a full stack trace.
  18. Garvin Hicking commented on patch set 5 10/29/25, 13:25

    Reply

    unresolving
  19. Lina Wolf commented on patch set 5 10/29/25, 13:35

    Reply

    For me it also works, I cannot reproduce.
  20. Jasmina Ließmann commented on patch set 5 10/29/25, 14:15

    Reply

    I was able to narrow down the problem: as soon as a backend usergroup receives read and/or write permissions to (EXT:styleguide) records starting with "Form engine - inline 1:1" or "Form engine - inline 1:n", then the show views (backend user + backend user group) output an error message.
  21. Jasmina Ließmann commented on patch set 5 10/29/25, 14:17

    Reply

    @garvin@hick.ing + @112@linawolf.de please see my comment above
  22. Lina Wolf commented on patch set 5 10/29/25, 14:18

    Reply

    oh no, the double points are messing us up! I see. will look into this and create additional tests
  23. Lina Wolf commented on patch set 5 10/29/25, 14:44

    Reply

    I created an issue and will create a functional test for this case: https://forge.typo3.org/issues/107911
  24. Lina Wolf commented on patch set 5 10/29/25, 14:45

    Reply

    Acknowledged