Review main Merged

91258[BUGFIX] Fix dropdowns in element browser

Benjamin Franzke CR +2 V +2 Easy +14 −7 updated 10/27/25, 11:51

Commit message

With the modal refactoring to a native dialog element in #107443
the TYPO3 modal implementation dropped it's dependency to the
bootstrap javascript library and therefore the element browser
(which loaded the `@typo3/backend/modal.js` module in modal frames)
did no longer implicitly load bootstrap JavaScript.

That means markup triggers with an implicit bootstrap dependency
did not work. We could now make sure to "always" load the bootstrap
JS module in modal frames, but we take this as an opportunity to
phase out this implicit dependency and instead make sure that components
explicitly load "bootstrap" if they need it.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 2

Files 14

Review log 57

  1. Benjamin Franzke uploaded patch set 1 10/26/25, 19:18

  2. core-ci voted on patch set 1 V -1 10/26/25, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87601

  3. Benjamin Franzke uploaded patch set 2 V -1 10/26/25, 19:43

  4. core-ci voted on patch set 2 V +1 10/26/25, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87602

  5. Michael Telgkamp commented on patch set 2 CR +1 V +1 10/27/25, 07:21

    Dropdown menu works again inside modal, thank you for explicit loading "bootstrap" where it is used.
  6. Oli Bartsch voted on patch set 2 CR +2 V +2 10/27/25, 11:51

  7. Oli Bartsch merged patch set 3 10/27/25, 11:51