91259[BUGFIX] Streamline ESC handling in <dialog>
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 3
Files 12
- Build/Sources/TypeScript/backend/element/combobox-element.ts+2 −1
- Build/Sources/TypeScript/backend/key-bindings.tsdeleted+0 −42
- Build/Sources/TypeScript/backend/modal.ts2+55 −5
- Build/Sources/TypeScript/install/module/settings/extension-configuration.ts+0 −8
- Build/Sources/TypeScript/install/module/settings/local-configuration.ts+0 −8
- typo3/sysext/backend/Classes/Controller/BackendController.php+0 −3
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+0 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/combobox-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/key-bindings.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/modal.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/settings/extension-configuration.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/settings/local-configuration.js+1 −1
Review log 2639
Show 814 earlier messages
-
Benjamin Franzke uploaded patch set 1 10/26/25, 20:33
-
core-ci voted on patch set 1 V +1 10/26/25, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87603
-
Benjamin Franzke uploaded patch set 2
V +110/26/25, 20:54 -
core-ci voted on patch set 2 V +1 10/26/25, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87604
-
Benjamin Franzke uploaded patch set 3
V +110/26/25, 21:38 -
core-ci voted on patch set 3 V +1 10/26/25, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87605
-
Benjamin Franzke uploaded patch set 4
V +110/26/25, 22:20 -
core-ci voted on patch set 4 V -1 10/26/25, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87606
-
Benjamin Franzke uploaded patch set 5
V -110/27/25, 05:39 -
core-ci voted on patch set 5 V +1 10/27/25, 05:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87618
-
Benjamin Franzke uploaded patch set 6
V +110/27/25, 06:02 -
core-ci voted on patch set 6 V +1 10/27/25, 06:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87620
-
Michael Telgkamp commented on patch set 6 V -1 10/27/25, 10:10
For iframe variant of the problem `ESC` works now, for the filter button, the `ESC` button still does not work for me. -
Benjamin Franzke commented on patch set 6 CR -1 10/27/25, 10:13
Reply
ack, confirmed, bootstrap dropdown intercepts Escape, so that dialog's cancel event is not fired. 😞 Will try to look into it.
-
Benjamin Franzke uploaded patch set 7
CR -1V +110/27/25, 11:52 -
Benjamin Franzke commented on patch set 7 10/27/25, 11:52
Reply
Done, we can detect what happens, because bootstrap at least allows the keyboard event to bubble, when no action (dropdown close) was performed. Solved for dropdown buttons in regular modals (global search) and iframe modals (link wizard/element browser). Thanks for reporting! -
core-ci voted on patch set 7 V +1 10/27/25, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87642
-
Benjamin Franzke uploaded patch set 8
V +110/28/25, 12:13 -
Benjamin Franzke updated the commit message in patch set 9 10/28/25, 12:17
-
core-ci voted on patch set 8 V +1 10/28/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87817
-
core-ci voted on patch set 9 V +1 10/28/25, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87818
-
Andreas Kienast uploaded patch set 10
V +111/20/25, 05:11 -
Andreas Kienast voted on patch set 10 CR +1 V +1 11/20/25, 05:16
-
core-ci voted on patch set 10 V +1 11/20/25, 05:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90228
-
Michael Telgkamp commented on patch set 10 V -1 11/20/25, 08:09
With this version I cannot close the "New file" dialog in the "Filelist" module when anything inside the iframe is selected. The dialog does the shake move, but stays open. Is that intended? I would expect the dialog to be closed when pressing ESC. -
Garvin Hicking uploaded patch set 11
CR +1V +101/25/26, 00:19address merge conflict -
Garvin Hicking commented on patch set 11 V +1 01/25/26, 00:20
Reply
I can't reproduce this in chromium or FF on macos - I can close that dialog just fine, no matter what I select. Can you show a screenshot or so? -
core-ci voted on patch set 11 V +1 01/25/26, 00:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94275
-
Benjamin Franzke commented on patch set 11 01/28/26, 17:00
Reply Unresolved
Hey Michael, I remember we had an issue that bootstrap-dropdown intercepted the Escape keypress, which was fixed in 6..7 – as I can't reproduce it either, my guess is that your checkout still used a cached `modal.js`. I think we should try to merge and can fix afterwards..modal.ts:133Can probably be removed again, since we replaced bootstrap dropdown in: > 92434: [TASK] Replace Bootstrap dropdown with Popover API | https://review.typo3.org/c/Packages/TYPO3.CMS/+/92434 -
Benjamin Franzke uploaded patch set 12
V +101/28/26, 17:05 -
Benjamin Franzke commented on patch set 12 01/28/26, 17:05
modal.ts:133ReplyDone -
core-ci voted on patch set 12 V +1 01/28/26, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94520
-
Garvin Hicking commented on patch set 12 CR +1 V +1 01/30/26, 08:11
(Core-review is a bit of 'wishful-thinking' but I'm feeling lucky) -
Benjamin Franzke uploaded patch set 13
CR +1V +101/30/26, 09:54 -
core-ci voted on patch set 13 V +1 01/30/26, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94633
-
Garvin Hicking voted on patch set 13 CR +1 V +1 01/30/26, 14:35
-
Andreas Kienast voted on patch set 13 CR +1 V +1 01/30/26, 14:48
-
Benjamin Franzke voted on patch set 13 CR +2 V +2 01/30/26, 14:49
-
Benjamin Franzke merged patch set 14 01/30/26, 14:50