Review main Abandoned

91261[DOCS] Improve readability of access patterns in changelog of #107831

Elias Häußler CR -1 V +1 Easy +3 −5 updated 10/27/25, 11:25

Commit message

Review

  • Code review CR -1
    • Georg Ringer +1
    • Oliver Klee +1
    • Garvin Hicking -1
  • Verified V +1
    • Georg Ringer +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 89

  1. Elias Häußler uploaded patch set 1 10/27/25, 06:57

  2. core-ci voted on patch set 1 V +1 10/27/25, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87622

  3. Georg Ringer voted on patch set 1 CR +1 V +1 10/27/25, 07:26

  4. Oliver Klee voted on patch set 1 CR +1 V +1 10/27/25, 09:15

  5. Garvin Hicking commented on patch set 1 CR -1 10/27/25, 09:41

    I had some other remarks here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91156 let's address those too please (can't do that myself atm)
  6. Garvin Hicking commented on patch set 1 10/27/25, 09:43

    Breaking-107831-RemovedTypoScriptFrontendController.rst:24 Unresolved

    ```suggestion All API methods that returned an instance of :php:`TypoScriptFrontendController`, ```
  7. Garvin Hicking commented on patch set 1 10/27/25, 09:44

    Reply

    Another file could need changing, can't do that in the gerrit web UI, if someone could take care that would be lovely: ``` typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107831-AfterCachedPageIsPersistedEventNoLongerReceivesTypoScriptFrontendController.rst s/whith/which/ ```
  8. Elias Häußler commented on patch set 1 10/27/25, 09:47

    Reply Unresolved

    Thanks for the hint. It seems lolli already took care of these adjustments at https://review.typo3.org/c/Packages/TYPO3.CMS/+/91246. So I'll probably just abandon this patch.
  9. Elias Häußler abandoned the change 10/27/25, 11:25