Review main Merged

91268[TASK] Use system resource API in ext:adminpanel

Christian Kuhn CR +2 V +2 Hard +120 −281 updated 06/18/26, 23:10

Commit message

Avoid PathUtility::getSystemResourceUri() in
ext:adminpanel ResourceUtility by switching to
system resource API. It is so longer static.
This is not considered breaking since custom
admin panel modules do not deal with this
management part of ext:adminpanel.

The patch adapts some DI details along the way:
MainController is now stateless and does not park
modules anymore. This avoids fishy state handling
in middlewares. ModuleLoader is stateless as well
and ext:core DependencyOrderingService is declared
strict and declares type on all method signatures.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Helmut Hummel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 1320

  1. Christian Kuhn uploaded patch set 1 10/27/25, 12:31

  2. Christian Kuhn uploaded patch set 2 10/27/25, 12:42

  3. core-ci voted on patch set 1 V -1 10/27/25, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87649

  4. core-ci voted on patch set 2 V +1 10/27/25, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87652

  5. Christian Kuhn uploaded patch set 3 V +1 10/27/25, 12:55

  6. core-ci voted on patch set 3 V -1 10/27/25, 13:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87653

  7. Christian Kuhn uploaded patch set 4 V -1 10/27/25, 14:53

  8. core-ci voted on patch set 4 V -1 10/27/25, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87669

  9. Christian Kuhn uploaded patch set 5 V -1 10/27/25, 15:18

  10. core-ci voted on patch set 5 V -1 10/27/25, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87670

  11. Christian Kuhn uploaded patch set 6 V -1 10/27/25, 15:40

  12. core-ci voted on patch set 6 V +1 10/27/25, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87672

  13. Christian Kuhn updated the commit message in patch set 7 V +1 10/27/25, 15:49

  14. core-ci voted on patch set 7 V +1 10/27/25, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87674

  15. Helmut Hummel commented on patch set 7 CR +1 10/28/25, 08:47

    ResourceUtility.php:60

    Ah, I missed that. Good catch
  16. Stefan Bürk voted on patch set 7 CR +1 V +1 10/28/25, 11:54

  17. Benni Mack voted on patch set 7 CR +1 V +1 10/28/25, 12:14

  18. Christian Kuhn voted on patch set 7 CR +2 V +2 10/28/25, 12:34

  19. Christian Kuhn merged patch set 8 10/28/25, 12:34

  20. Oliver Hader commented on patch set 8 12/18/25, 10:10

    ResourceUtility.php:29 Unresolved

    I feel this should have been a new (`@internal`) `ResourceService` instead, keeping the previous static functions and introducing a the new API...

    ResourceUtility.php:53 Unresolved

    The (late) static invocation works, but probably should be `$this->getJsTag`