Review main Merged

91270[TASK] Adapt translation domain in EXT:seo

Maike Kiebele CR +2 V +2 Normal +117 −32 updated 10/29/25, 13:59

Commit message

This patch adjusts translation domains within EXT:seo
to use the new syntax.

In addition, the file is moved from locallang_tca.xlf
to db.xlf with a fallback layer in place for this
file if third-party extensions have referenced it, the
reference is continuing to work.

A small drive-by fix is made including tests for resolving
the proper locale in LabelFileResolver.php for label
files with only two letter in the file name (db.xlf for example)
which was previously mistaken for being a locale, but
is now correctly detected as a filename.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Benni Mack +2
    • Lina Wolf +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 2434

Show 79 earlier messages
  1. Maike Kiebele uploaded patch set 1 10/27/25, 13:19

  2. core-ci voted on patch set 1 V +1 10/27/25, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87656

  3. Maike Kiebele uploaded patch set 2 V +1 10/27/25, 13:35

  4. core-ci voted on patch set 2 V +1 10/27/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87660

  5. Georg Ringer commented on patch set 2 10/27/25, 14:00

    can we do that without changing the path? @benni@typo3.org
  6. Lina Wolf commented on patch set 2 10/27/25, 14:18

    Reply

    @benni@typo3.org suggested to consolidate the file names so they use db over tca and the locallang_ is removed
  7. Garvin Hicking commented on patch set 2 10/27/25, 14:53

    Suggestion: ``` [TASK] Adapt translation domain in EXT:seo ``` so it matches our commit message rules https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html Thanks Maike for contributing and working on this! 😊
  8. Maike Kiebele updated the commit message in patch set 3 V +1 10/28/25, 08:16

  9. Maike Kiebele commented on patch set 3 10/28/25, 08:17

    Reply

    Done
  1. core-ci voted on patch set 3 V +1 10/28/25, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87765

  2. Lina Wolf uploaded patch set 4 V +1 10/28/25, 10:09

  3. core-ci voted on patch set 4 V +1 10/28/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87788

  4. Maike Kiebele uploaded patch set 5 V +1 10/28/25, 14:21

  5. core-ci voted on patch set 5 V +1 10/28/25, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87835

  6. Benni Mack uploaded patch set 6 V +1 10/28/25, 14:44

  7. core-ci voted on patch set 6 V +1 10/28/25, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87841

  8. Maike Kiebele uploaded patch set 7 V +1 10/28/25, 15:08

  9. core-ci voted on patch set 7 V +1 10/28/25, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87848

  10. Benni Mack uploaded patch set 8 V +1 10/28/25, 15:59

  11. Benni Mack uploaded patch set 9 10/28/25, 15:59

  12. Benni Mack voted on patch set 9 CR +1 V +1 10/28/25, 15:59

  13. core-ci voted on patch set 8 V +1 10/28/25, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87855

  14. core-ci voted on patch set 9 V +1 10/28/25, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87856

  15. Garvin Hicking commented on patch set 9 10/28/25, 19:35

    LocalizationFactory.php:65

    I think we could avoid state for this factory and move this as a inline array to the getParsedData method, or use a class constant, wdyt?
  16. Benni Mack commented on patch set 9 10/29/25, 06:52

    LocalizationFactory.php:65 Reply

    claas constants sounds appropriate
  17. Benni Mack uploaded patch set 10 CR +1 V +1 10/29/25, 10:15

  18. Benni Mack commented on patch set 10 10/29/25, 10:15

    LocalizationFactory.php:65 Reply

    Done
  19. core-ci voted on patch set 10 V +1 10/29/25, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87930

  20. Garvin Hicking voted on patch set 10 CR +1 10/29/25, 13:32

  21. Benni Mack voted on patch set 10 CR +1 V +1 10/29/25, 13:43

  22. Lina Wolf commented on patch set 10 V +1 10/29/25, 13:56

    The SEO palettes in the pages module display fine, no labels missing
  23. Lina Wolf commented on patch set 10 CR +1 10/29/25, 13:57

    Code looks good to me
  24. Benni Mack voted on patch set 10 CR +2 V +2 10/29/25, 13:59

  25. Benni Mack merged patch set 11 10/29/25, 13:59