91270[TASK] Adapt translation domain in EXT:seo
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Lina Wolf +1
-
Verified V +2 Done
- Benni Mack +2
- Lina Wolf +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/Localization/LabelFileResolver.php+3 −1
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php3+11 −0
- typo3/sysext/core/Tests/Unit/Localization/LabelFileResolverTest.phpnew+72 −0
- typo3/sysext/seo/Configuration/TCA/Overrides/pages.php+30 −30
- typo3/sysext/seo/Resources/Private/Language/db.xlfrenamed+1 −1
Review log 2434
Show 79 earlier messages
-
Maike Kiebele uploaded patch set 1 10/27/25, 13:19
-
core-ci voted on patch set 1 V +1 10/27/25, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87656
-
Maike Kiebele uploaded patch set 2
V +110/27/25, 13:35 -
core-ci voted on patch set 2 V +1 10/27/25, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87660
-
Georg Ringer commented on patch set 2 10/27/25, 14:00
can we do that without changing the path? @benni@typo3.org -
Lina Wolf commented on patch set 2 10/27/25, 14:18
Reply
@benni@typo3.org suggested to consolidate the file names so they use db over tca and the locallang_ is removed -
Garvin Hicking commented on patch set 2 10/27/25, 14:53
Suggestion: ``` [TASK] Adapt translation domain in EXT:seo ``` so it matches our commit message rules https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html Thanks Maike for contributing and working on this! 😊 -
Maike Kiebele updated the commit message in patch set 3
V +110/28/25, 08:16 -
Maike Kiebele commented on patch set 3 10/28/25, 08:17
Reply
Done
-
core-ci voted on patch set 3 V +1 10/28/25, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87765
-
Lina Wolf uploaded patch set 4
V +110/28/25, 10:09 -
core-ci voted on patch set 4 V +1 10/28/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87788
-
Maike Kiebele uploaded patch set 5
V +110/28/25, 14:21 -
core-ci voted on patch set 5 V +1 10/28/25, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87835
-
Benni Mack uploaded patch set 6
V +110/28/25, 14:44 -
core-ci voted on patch set 6 V +1 10/28/25, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87841
-
Maike Kiebele uploaded patch set 7
V +110/28/25, 15:08 -
core-ci voted on patch set 7 V +1 10/28/25, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87848
-
Benni Mack uploaded patch set 8
V +110/28/25, 15:59 -
Benni Mack uploaded patch set 9 10/28/25, 15:59
-
Benni Mack voted on patch set 9 CR +1 V +1 10/28/25, 15:59
-
core-ci voted on patch set 8 V +1 10/28/25, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87855
-
core-ci voted on patch set 9 V +1 10/28/25, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87856
-
Garvin Hicking commented on patch set 9 10/28/25, 19:35
LocalizationFactory.php:65I think we could avoid state for this factory and move this as a inline array to the getParsedData method, or use a class constant, wdyt? -
Benni Mack commented on patch set 9 10/29/25, 06:52
LocalizationFactory.php:65Replyclaas constants sounds appropriate -
Benni Mack uploaded patch set 10
CR +1V +110/29/25, 10:15 -
Benni Mack commented on patch set 10 10/29/25, 10:15
LocalizationFactory.php:65ReplyDone -
core-ci voted on patch set 10 V +1 10/29/25, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87930
-
Garvin Hicking voted on patch set 10 CR +1 10/29/25, 13:32
-
Benni Mack voted on patch set 10 CR +1 V +1 10/29/25, 13:43
-
Lina Wolf commented on patch set 10 V +1 10/29/25, 13:56
The SEO palettes in the pages module display fine, no labels missing -
Lina Wolf commented on patch set 10 CR +1 10/29/25, 13:57
Code looks good to me -
Benni Mack voted on patch set 10 CR +2 V +2 10/29/25, 13:59
-
Benni Mack merged patch set 11 10/29/25, 13:59