Review main Merged

91271[BUGFIX] Fix vimeo and youtube rendering for deleted reference

morgane garcia CR +2 V +2 Easy +16 −9 updated 10/30/25, 08:39

Commit message

The online media video renderers do no longer crash
on missing files by returning just an empty string
if the video id can not be determined.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1725

  1. morgane garcia uploaded patch set 1 10/27/25, 13:23

  2. core-ci voted on patch set 1 V +1 10/27/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87658

  3. Georg Ringer updated the commit message in patch set 2 V +1 10/27/25, 14:01

  4. core-ci voted on patch set 2 V +1 10/27/25, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87662

  5. Garvin Hicking commented on patch set 2 10/27/25, 14:51

    Please check out the conventions about commit message subjects: https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html Also maybe you can adjust your gerrit username to match a realname (for license/legal reasons). Thanks for the patch!

    VimeoRenderer.php:133

    I think in this case the whole ViewHelper should rather not return a vimeo link at all? This would return a link like `https://player.vimeo.com/video/?....` without any ID reference...?
  6. Garvin Hicking commented on patch set 2 10/27/25, 14:52

    Reply

    (sorry I mean the "git" username, so that `Author` matches)
  7. morgane garcia updated the commit message in patch set 3 V +1 10/27/25, 15:47

  8. core-ci voted on patch set 3 V +1 10/27/25, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87673

  9. morgane garcia uploaded patch set 4 V +1 10/27/25, 17:07

  10. core-ci voted on patch set 4 V -1 10/27/25, 17:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87691

  11. morgane garcia uploaded patch set 5 V -1 10/27/25, 19:58

  12. core-ci voted on patch set 5 V +1 10/27/25, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87732

  13. morgane garcia rebased onto patch set 6 V +1 10/28/25, 11:57

  14. core-ci voted on patch set 6 V +1 10/28/25, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87810

  15. Benni Mack commented on patch set 6 10/28/25, 16:23

    morgane, let's check tomorrow about this patch pls
  16. morgane garcia uploaded patch set 7 V +1 10/29/25, 08:15

  17. core-ci voted on patch set 7 V +1 10/29/25, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87910

  18. morgane garcia commented on patch set 7 10/29/25, 11:10

    Reply

    @garvin@hick.ing Thanks for your feedback. I have change the git message according the convention. About the 'git username', I don't understand what I need to do. Where can you see the wrong username ?

    VimeoRenderer.php:133 Reply

    Done
  19. Garvin Hicking commented on patch set 7 10/29/25, 13:30

    Reply

    Thanks for adjusting the title, that's good! The git username is set in your `~/.gitconfig` file and probably looks like this: ``` [user] name = morgane email = morgane.garcia@ideative.ch ``` You could either globally adjust your name, but maybe at least in your TYPO3 git directory you could adjust the `.git/config` file to insert: ``` [user] name = Morgane Garcia email = morgane.garcia@ideative.ch ``` Once you did that and do a "git commit --amend && git push" I think this should propagate your username to here. And if not... don't mind me. I just saw this mentioned in another patch review and wanted to be in line.
  20. Garvin Hicking commented on patch set 7 CR +1 V +1 10/30/25, 08:10

    Reply

    Done
  21. Oli Bartsch uploaded patch set 8 CR +1 V +1 10/30/25, 08:27

  22. core-ci voted on patch set 8 V +1 10/30/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88088

  23. Garvin Hicking voted on patch set 8 CR +1 V +1 10/30/25, 08:38

  24. Oli Bartsch voted on patch set 8 CR +2 V +2 10/30/25, 08:39

  25. Oli Bartsch merged patch set 9 10/30/25, 08:39