Review main Merged

91272[TASK] Avoid property `DataHandler->bypassWorkspaceRestrictions`

Daniel Windloff CR +2 V +2 Easy +2 −15 updated 10/27/25, 17:24

Commit message

The leftover usages in MissingRelationsCommand and
AbstractGenerator in styleguide have been removed,
as these are always in the live workspace.

The usage in the SetupModuleController could  also be
removed, as it refers only to `be_users` entries,
which are always allowed to be edited in the live
workspace via `versioningWS_alwaysAllowLiveEdit`

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1318

  1. Daniel Windloff uploaded patch set 1 10/27/25, 14:12

  2. core-ci voted on patch set 1 V +1 10/27/25, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87663

  3. Christian Kuhn commented on patch set 1 10/27/25, 16:12

    interesting. will review now / asap.
  4. Benni Mack commented on patch set 1 10/27/25, 16:16

    SetupModuleController.php:352

    I assume this comment is not needed then anymore?
  5. Daniel Windloff uploaded patch set 2 V +1 10/27/25, 16:38

  6. Daniel Windloff commented on patch set 2 10/27/25, 16:40

    SetupModuleController.php:352 Reply

    Done
  7. Christian Kuhn commented on patch set 2 CR -1 10/27/25, 16:43

    on it.
  8. Benni Mack commented on patch set 3 CR -1 10/27/25, 16:49

    Published edit on patch set 2.
  9. core-ci voted on patch set 2 V +1 10/27/25, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87683

  10. Christian Kuhn uploaded patch set 4 10/27/25, 16:49

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 10/27/25, 16:49

  12. Christian Kuhn uploaded patch set 5 CR +1 V +1 10/27/25, 16:51

  13. Christian Kuhn voted on patch set 5 CR +1 V +1 10/27/25, 16:51

  14. core-ci voted on patch set 3 V +1 10/27/25, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87688

  15. core-ci voted on patch set 4 V +1 10/27/25, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87689

  16. core-ci voted on patch set 5 V +1 10/27/25, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87690

  17. Benni Mack voted on patch set 5 CR +2 V +2 10/27/25, 17:24

  18. Benni Mack merged patch set 6 10/27/25, 17:24