Review main Merged

91277[TASK] Remove not needed .phpstorm.meta.php entry

Markus Klein CR +2 V +2 Easy +0 −4 updated 10/27/25, 19:51

Commit message

A lot of generic-related bugs have been fixed in PHPStorm.
The meta-configs for methods properly covered with phpdoc
can be removed now. GeneralUtility::makeInstance() is
affected, we added this a while ago only to help PHPStorm
resolving return types.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Markus Klein uploaded patch set 1 10/27/25, 16:33

  2. core-ci voted on patch set 1 V +1 10/27/25, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87682

  3. Christian Kuhn commented on patch set 1 10/27/25, 17:11

    would love the change, but does not work for me: as soon as its applied, i loose completion on the result objects of FunctionalTestCase->get() (containerinterface) and eventdispatcherinterface->dispatch().
  4. Christian Kuhn commented on patch set 1 10/27/25, 17:12

    Reply

    'you are already using the latest version of phpstorm'
  5. Christian Kuhn uploaded patch set 2 V +1 10/27/25, 18:10

  6. Christian Kuhn commented on patch set 1 CR +1 V +1 10/27/25, 18:11

    Reply

    it works with GU::makeInstance() since that method has proper "T template" annotations.
  7. Christian Kuhn voted on patch set 2 CR +1 V +1 10/27/25, 18:12

  8. core-ci voted on patch set 2 V +1 10/27/25, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87710

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 10/27/25, 18:47

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 10/27/25, 19:12

  11. Christian Kuhn merged patch set 3 10/27/25, 19:51