Review main Merged

91280[BUGFIX] Improve submodule link accessibility without breaking UX

Oli Bartsch CR +2 V +2 Normal +31 −29 updated 10/29/25, 08:12

Commit message

The module name was recently added to the link
text (#107852) to provide better context for
accessibility ("Open <Module Name> module"
instead of just "Open module"). However, this
caused UX issues with long module names that
made the buttons visually odd.

This change moves the contextual information
to an `aria-label` attribute instead, which
provides the full context to screen readers
while keeping the visible link text short and
clean. This maintains accessibility improvements
without compromising the visual user experience.

For consistency, this change is also applied
to the modules overview in the About module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jasmina Ließmann +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1214

  1. Oli Bartsch uploaded patch set 1 10/27/25, 17:41

  2. core-ci voted on patch set 1 V +1 10/27/25, 17:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87697

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 10/27/25, 18:00

  4. Jasmina Ließmann commented on patch set 1 10/27/25, 18:31

    In the "About" module the module titles are included in the link titles (which was also introduced for accessibility reasons). I would like to keep the link titles consistent – either include the module name in the link title everywhere or insert it as an aria-label in the "About" module too. I would also like to see this applied to all places without an icon (as in the ‘About’ module). Another option would be to allow word-break in button styles.
  5. Jasmina Ließmann commented on patch set 1 10/27/25, 18:33

    Reply

    See above, was incorrectly set to ‘resolved’.
  6. Oli Bartsch commented on patch set 1 10/27/25, 19:36

    Reply

    > I would also like to see this applied to all places without an icon (as in the ‘About’ module). Which places do you mean in particular?
  7. Jasmina Ließmann commented on patch set 1 10/27/25, 19:48

    Reply

    Cards in the modules of the "Admin Tools" section and cards in the "About" module do not have a button icon. The newly introduced card based sub module overview instead uses an 'actions-play' button icon per card.
  8. Oli Bartsch uploaded patch set 2 CR +1 V +1 10/28/25, 13:56

  9. Oli Bartsch commented on patch set 1 10/28/25, 13:58

    Reply

    Ah I see. Oke I removed the icon again and adjusted the "About" template to align with the submodule overview cards.
  10. Georg Ringer voted on patch set 2 CR +1 V +1 10/28/25, 13:59

  11. core-ci voted on patch set 2 V +1 10/28/25, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87828

  12. Jasmina Ließmann commented on patch set 2 CR +1 V +1 10/28/25, 21:19

    Reply

    Thank you :)
  13. Oli Bartsch commented on patch set 2 CR +2 V +2 10/29/25, 08:12

    Reply

    Done
  14. Oli Bartsch merged patch set 3 10/29/25, 08:12