Review main Merged Breaking

91281[!!!][TASK] DataHandler: Remove copy related properties

Daniel Windloff CR +2 V +2 Normal +83 −74 updated 11/23/25, 02:26

Commit message

The configuration of copy processes now only relies on
the current `BE_USER`. The following public DataHandler
properties have been removed:
- `neverHideAtCopy` - directly read from BE_USER->uc, can
  still be configured using User TSconfig.
- `copyTree` - directly read from BE_USER->uc, can be set
  by users and configured using User TSconfig.
- `copyWhichTables` - internal, core unused, very limited
  use case

Requires a pre-patch in testing-framework:
> composer u typo3/testing-framework

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1929

Show 24 earlier messages
  1. Daniel Windloff uploaded patch set 1 10/27/25, 17:46

  2. core-ci voted on patch set 1 V -1 10/27/25, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87698

  3. Daniel Windloff uploaded patch set 2 V -1 10/27/25, 18:15

  4. core-ci voted on patch set 2 V -1 10/27/25, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87711

  1. Daniel Windloff uploaded patch set 3 V -1 10/28/25, 08:29

  2. core-ci voted on patch set 3 V +1 10/28/25, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87767

  3. Simon Schaufelberger commented on patch set 3 11/07/25, 17:12

    can you finish this for v14.0?
  4. Daniel Windloff uploaded patch set 4 V +1 11/21/25, 08:14

  5. core-ci voted on patch set 4 V -1 11/21/25, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90455

  6. Daniel Windloff uploaded patch set 5 V -1 11/21/25, 09:12

  7. core-ci voted on patch set 5 V -1 11/21/25, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90465

  8. Daniel Windloff uploaded patch set 6 V -1 11/21/25, 09:40

  9. core-ci voted on patch set 6 V +1 11/21/25, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90474

  10. Daniel Windloff uploaded patch set 7 V +1 11/21/25, 12:09

  11. Daniel Windloff uploaded patch set 8 11/21/25, 12:12

  12. Oliver Klee commented on patch set 8 11/21/25, 12:16

    SetupModuleController.php:442

    Are these lines related to the topic of the change?
  13. core-ci voted on patch set 7 V -1 11/21/25, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90496

  14. core-ci voted on patch set 8 V -1 11/21/25, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90497

  15. Daniel Windloff commented on patch set 8 11/21/25, 12:33

    Reply

    I try :)

    SetupModuleController.php:442 Reply

    If you would like to test this change in the backend, I missed neverHideAtCopy in the Controller and the values you can set might not be valid as negative number doesn't make any sense. That's why I added this here. From a tecnical point of view, the changes in the setup extension can also be a another bugfix.
  16. Christian Kuhn commented on patch set 8 11/23/25, 01:03

    ext_tables.php:79

    let's do that in a dedicated fix if needed and sanitize where used for now.

    ext_tables.php:84

    the only way to set this option is by using setup.override|default.neverHideAtCopy. I think we should keep it that way and should not add it now.
  17. Christian Kuhn uploaded patch set 9 V -1 11/23/25, 01:39

  18. Christian Kuhn commented on patch set 9 11/23/25, 01:39

    SetupModuleController.php:442 Reply

    i'll skip this for now.

    ext_tables.php:79 Reply

    Done

    ext_tables.php:84 Reply

    Done
  19. core-ci voted on patch set 9 V +1 11/23/25, 01:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90713

  20. Christian Kuhn voted on patch set 9 CR +1 V +1 11/23/25, 01:47

  21. Stefan Bürk updated the commit message in patch set 10 CR +1 V +1 11/23/25, 01:59

  22. core-ci voted on patch set 10 V +1 11/23/25, 02:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90714

  23. Stefan Bürk voted on patch set 10 CR +1 V +1 11/23/25, 02:26

  24. Christian Kuhn voted on patch set 10 CR +2 V +2 11/23/25, 02:26

  25. Christian Kuhn merged patch set 11 11/23/25, 02:26