Review main Abandoned

91283[TASK] Replace "OK" label on modals button with context-specific wording

Riccardo De Contardi CR 0 V 0 Normal +129 −27 updated 08/06/26, 21:52

Commit message

This patch replaces the "OK" button label on modal windows on the following places/features:

- Workspace module (Workspace module > delete a record (delete icon))
- System notes (add a sys_note to a page; page view > delete the note)
- Clipboard (1) (copy a page from the PageTree and paste it into/after another)
- Backend Layout editing (Create or open a Backend Layout > edit a cell)
- Import/Export page -> Export -> Save export (Pagetree > page > export > go to tab "File & Preset" > click on "save"
- Import/Export page -> Export -> Delete export (Pagetree > page > export > go to tab "File & Preset" > click on "delete"
- Import/Export page -> Export -> Merge export (Pagetree > page > export > go to tab "File & Preset" > click on "merge"
- Import/Export page -> Import -> Merge export (Pagetree > page > import > select a file > click on "Preview" then click on "Import"
- Import/Export page -> Import -> Merge export (Pagetree > page > import > select a file ; check "Update Records" > click on "Preview" then click on "Update"
- Change doktype (Pagetree > edit page > change doktype)
- Bookmarks (Create a bookmark and then delete it)
- Scheduler - delete task group (scheduler module > create a task and then delete it from the task list)
- Scheduler - delete task within a group (scheduler module > create a task within a group and then delete it from the task list)
- Scheduler - delete task without a group (scheduler module > create a task without a group and then delete it from the task list)

TBD:
- delete a record from list view
- delete a file from filelist

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 3052

Show 1427 earlier messages
  1. Riccardo De Contardi uploaded patch set 1 10/27/25, 17:56

  2. core-ci voted on patch set 1 V +1 10/27/25, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87704

  3. Riccardo De Contardi uploaded patch set 2 V +1 10/28/25, 09:16

  4. Riccardo De Contardi uploaded patch set 3 10/28/25, 09:18

  5. Riccardo De Contardi uploaded patch set 4 10/28/25, 09:33

  6. core-ci voted on patch set 2 V -1 10/28/25, 09:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87777

  7. core-ci voted on patch set 3 V -1 10/28/25, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87779

  8. core-ci voted on patch set 4 V -1 10/28/25, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87783

  9. Riccardo De Contardi uploaded patch set 5 V -1 10/28/25, 10:33

  10. core-ci voted on patch set 5 V -1 10/28/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87790

  11. Riccardo De Contardi commented on patch set 6 V -1 10/28/25, 11:10

    Published edit on patch set 5.
  12. Riccardo De Contardi uploaded patch set 7 10/28/25, 11:12

  13. Lina Wolf commented on patch set 5 10/28/25, 11:17

    GroupUnusedList.html:67

    111?
  14. core-ci voted on patch set 6 V -1 10/28/25, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87803

  15. Riccardo De Contardi uploaded patch set 8 10/28/25, 11:28

  16. core-ci voted on patch set 7 V -1 10/28/25, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87805

  17. Riccardo De Contardi uploaded patch set 9 10/28/25, 11:34

  18. core-ci voted on patch set 8 V -1 10/28/25, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87808

  19. core-ci voted on patch set 9 V -1 10/28/25, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87809

  20. Riccardo De Contardi uploaded patch set 10 V -1 10/28/25, 14:09

  21. core-ci voted on patch set 10 V -1 10/28/25, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87834

  22. Riccardo De Contardi uploaded patch set 11 V -1 10/28/25, 14:55

  23. Riccardo De Contardi uploaded patch set 12 10/28/25, 14:59

  24. core-ci voted on patch set 11 V -1 10/28/25, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87842

  25. core-ci voted on patch set 12 V -1 10/28/25, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87844

  26. Riccardo De Contardi uploaded patch set 13 V -1 10/29/25, 08:09

  27. core-ci voted on patch set 13 V -1 10/29/25, 08:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87909

  1. Riccardo De Contardi uploaded patch set 14 V -1 10/29/25, 09:09

  2. core-ci voted on patch set 14 V -1 10/29/25, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87922

  3. Riccardo De Contardi uploaded patch set 15 V -1 10/29/25, 09:36

  4. core-ci voted on patch set 15 V -1 10/29/25, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87923

  5. Riccardo De Contardi uploaded patch set 16 V -1 10/29/25, 09:47

  6. core-ci voted on patch set 16 V -1 10/29/25, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87925

  7. Riccardo De Contardi uploaded patch set 17 V -1 10/29/25, 10:16

  8. Riccardo De Contardi uploaded patch set 18 10/29/25, 10:17

  9. core-ci voted on patch set 17 V -1 10/29/25, 10:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87932

  10. core-ci voted on patch set 18 V +1 10/29/25, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87933

  11. Riccardo De Contardi updated the commit message in patch set 19 V +1 10/29/25, 11:06

  12. core-ci voted on patch set 19 V +1 10/29/25, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87945

  13. Riccardo De Contardi updated the commit message in patch set 20 V +1 10/29/25, 11:22

  14. core-ci voted on patch set 20 V +1 10/29/25, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87949

  15. Riccardo De Contardi commented on patch set 20 10/29/25, 13:40

    GroupUnusedList.html:67 Reply

    my bad. sorry
  16. Lina Wolf commented on patch set 20 CR -1 10/29/25, 14:08

    Thanks a lot for this change, I still have some small remarks that would need to be resolved, however

    backend.ts:613 Unresolved

    doaction sounds strange to me

    locallang_wizards.xlf:6 Unresolved

    I would suggest to move these into actions.xlf, they are not wizard specific

    locallang.xlf:129 Unresolved

    This label is still used, for example in typo3/sysext/impexp/Resources/Private/Partials/Export/AdvancedOptions.html

    locallang.xlf:138

    This transunit has no id

    TaskList.html:73 Unresolved

    When touching labels please convert them to the new translation domain syntax

    List.html:54 Unresolved

    convert to translation domain syntax
  17. Riccardo De Contardi commented on patch set 21 CR -1 V +1 10/30/25, 08:46

    Published edit on patch set 20.
  18. Riccardo De Contardi commented on patch set 21 10/30/25, 08:47

    locallang.xlf:138 Reply

    Done
  19. Benni Mack commented on patch set 21 10/30/25, 08:51

    Save.html:38

    does this comma belong in there?
  20. core-ci voted on patch set 21 V +1 10/30/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88091

  21. Riccardo De Contardi commented on patch set 22 V +1 10/30/25, 09:54

    Published edit on patch set 21.
  22. Riccardo De Contardi commented on patch set 22 10/30/25, 09:54

    Save.html:38 Reply

    done
  23. core-ci voted on patch set 22 V +1 10/30/25, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88101

  24. Riccardo De Contardi marked it work in progress 11/05/25, 13:44

  25. Riccardo De Contardi abandoned the change 08/06/26, 21:52

    Abandoned. Must be solved with several different smaller patches