91288[!!!][TASK] Rework actions to use Buttons API
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 16
- typo3/sysext/backend/Classes/RecordList/Event/ModifyRecordListRecordActionsEvent.php1+69 −75
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php14+257 −264
- typo3/sysext/backend/Classes/Template/Components/Buttons/ButtonSize.phpnew+25 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php+13 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/GenericButton.php4+13 −1
- typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php2+15 −2
- typo3/sysext/backend/Classes/Template/Components/ActionGroup.phpnew+28 −0
- typo3/sysext/backend/Classes/Template/Components/ComponentFactory.php+12 −0
- typo3/sysext/backend/Classes/Template/Components/ComponentGroup.php9new+87 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107884-ReworkActionsToUseButtonsAPI.rst4new+317 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107824-ComponentFactoryForBackendComponents.rst+57 −2
- typo3/sysext/filelist/Classes/Event/ProcessFileListActionsEvent.php2+108 −6
- typo3/sysext/filelist/Classes/FileList.php3+84 −59
- typo3/sysext/form/Classes/EventListener/ProcessFileListActionsEventListener.php+1 −5
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentDroppedMatcher.php+6 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php4+28 −0
Review log 3652
Show 1627 earlier messages
-
Matthias Vogel uploaded patch set 1 10/27/25, 18:57
-
core-ci voted on patch set 1 V -1 10/27/25, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87718
-
Matthias Vogel uploaded patch set 2
V -110/27/25, 19:24 -
core-ci voted on patch set 2 V -1 10/27/25, 19:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87723
-
Matthias Vogel uploaded patch set 3
V -110/27/25, 20:24 -
Matthias Vogel uploaded patch set 4 10/27/25, 20:26
-
core-ci voted on patch set 3 V -1 10/27/25, 20:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87739
-
Matthias Vogel uploaded patch set 5 10/27/25, 20:41
-
core-ci voted on patch set 4 V -1 10/27/25, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87740
-
core-ci voted on patch set 5 V +1 10/27/25, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87742
-
Benni Mack commented on patch set 5 CR -1 10/27/25, 21:05
The previous icons that were "empty" were spans, not button tags, and had the "disabled" class and aria-hidden="true"DatabaseRecordList.php:1593DatabaseRecordList->makeControl() is breaking -
Matthias Vogel uploaded patch set 6
CR -1V +110/28/25, 08:57 -
core-ci voted on patch set 6 V -1 10/28/25, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87771
-
Matthias Vogel uploaded patch set 7
V -110/28/25, 09:17 -
core-ci voted on patch set 7 V +1 10/28/25, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87778
-
Matthias Vogel uploaded patch set 8
V +110/28/25, 09:43 -
core-ci voted on patch set 8 V -1 10/28/25, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87785
-
Matthias Vogel uploaded patch set 9
V -110/28/25, 11:10 -
Matthias Vogel uploaded patch set 10 10/28/25, 11:26
-
core-ci voted on patch set 9 V -1 10/28/25, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87804
-
core-ci voted on patch set 10 V -1 10/28/25, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87807
-
Benni Mack uploaded patch set 11
V -110/28/25, 12:13 -
Oli Bartsch commented on patch set 11 10/28/25, 12:16
ComponentGroup.php:20Please let's wait with this for my ViewSettings patch. Maybe we can find a combined approach. -
core-ci voted on patch set 11 V +1 10/28/25, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87816
-
Benni Mack commented on patch set 11 10/28/25, 12:27
DatabaseRecordList.php:1593ReplyDoneComponentGroup.php:20ReplyThis is *actively* blocking further development of related RecordList changes! -
Benni Mack commented on patch set 11 10/29/25, 08:08
ComponentGroup.php:20ReplyI haven't seen any code about this patch until now, and we want to have a productive code sprint here with participants waiting for this, so I think we should proceed and adapt this change later once we have seen how both patches are actually conflicting each other. Feel free to ping me on slack to discuss this further once your patch has arrived in our review system. Resolving this one for now. -
Garvin Hicking uploaded patch set 12
V +110/29/25, 08:27
-
Garvin Hicking commented on patch set 12 10/29/25, 08:33
MethodCallMatcher.php:6673I'm afraid scanning for usage of "getTable" is too broad, it will create false positives for very many events. The scanner sadly does not scan for the "surrounding" class, only the method name counts (see note at the end). The scanners for "(s|g)etActions" and "(s|g)etActionItems" should be fine! -
core-ci voted on patch set 12 V +1 10/29/25, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87912
-
Benni Mack commented on patch set 12 10/29/25, 08:36
MethodCallMatcher.php:6673ReplyI am fine with removing them... can you take care please? -
Garvin Hicking uploaded patch set 13
V +110/29/25, 08:41 -
core-ci voted on patch set 13 V +1 10/29/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87915
-
Garvin Hicking commented on patch set 13 10/29/25, 08:56
Working on this and reviewing; feel free to work alongside, I will fetch newer patchsets.Breaking-107884-ReworkActionsToUseButtonsAPI.rst:85Needs a migration path for the two events with code examples, too. We should mention core dual-version compatibility using a version switch. -
Garvin Hicking commented on patch set 13 10/29/25, 08:56
MethodCallMatcher.php:6673Replywill do -
Garvin Hicking uploaded patch set 14
V +110/29/25, 11:35 -
Garvin Hicking commented on patch set 13 10/29/25, 11:36
ActionGroup.php:18I think this belongs into TYPO3\CMS\Backend\Template\ComponentsComponentGroup.php:20This class needs test coverage as wellComponentGroup.php:35this needs a check if the item array key existsComponentGroup.php:42I think the "ifEmptyUseThis" parameter needs some explanation here on why/when that is useful?ProcessFileListActionsEvent.php:65We will need test coverage for this, especially because the core does not utilize these methods yet. To not block this, we need to add this in later.MethodCallMatcher.php:6673ReplyDone -
core-ci voted on patch set 14 V +1 10/29/25, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87950
-
Garvin Hicking uploaded patch set 15
V +110/29/25, 12:11 -
core-ci voted on patch set 15 V +1 10/29/25, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87955
-
Garvin Hicking commented on patch set 15 10/29/25, 12:41
Thank you! This generally seems to work quite well for me. I would positively vote on it if we: - can address the sizing issue - enhance the "Component API" feature RST (107824) to mention the additions to the component API (ActionGroup, ButtonSizes, ComponentGroup) - agree to add tests later on (for the event changes and ActionGroup+ComponentGroup - move ActionGroup to Component namespace I will happily adjust the feature rst and also the example for dual-core version compatibility tonight.DatabaseRecordList.php:2021This HTML here could probably also get a distinct type in the ComponentFactory, or add a todo for itDatabaseRecordList.php:2275Even though this is public and 'makeControl()' has been documented in breaking, I'd say we can leave this one out, it's rather a hidden protected method.LinkButton.php:77should be part of the feature ReSTBreaking-107884-ReworkActionsToUseButtonsAPI.rst:5This also needs a Feature RST because it introduces several new things.FileList.php:957nifty :)FileList.php:966My filelist now displays slightly larger icons, see screenshots: Before: https://www.dropbox.com/scl/fi/plaglp1qgufpo3xxzeibv/Screenshot-2025-10-29-at-13.34.34.png?rlkey=saafyf9mhlpwvpwxhoe99seye&dl=0 After: https://www.dropbox.com/scl/fi/k2kuo7ew0zv5fovw8rohw/Screenshot-2025-10-29-at-13.34.25.png?rlkey=n6nlnelnim9fwlwxytxfjjcgk&dl=0 This enlarges the nasty scrollbar below. Would the increase in icon size be intentional? -
Garvin Hicking commented on patch set 15 CR -1 10/29/25, 18:23
on it -
Garvin Hicking uploaded patch set 16
CR -1V +110/29/25, 18:34 -
Garvin Hicking commented on patch set 16 10/29/25, 18:34
ActionGroup.php:18ReplyDoneDatabaseRecordList.php:2021ReplyDoneLinkButton.php:77ReplyDoneComponentGroup.php:20ReplyAcknowledgedComponentGroup.php:35ReplyDoneComponentGroup.php:42ReplyAcknowledgedBreaking-107884-ReworkActionsToUseButtonsAPI.rst:5ReplyDoneBreaking-107884-ReworkActionsToUseButtonsAPI.rst:85ReplyDoneProcessFileListActionsEvent.php:65ReplyAcknowledgedFileList.php:966ReplyIs now streamlined in both Record list and file list. Changes can be done in a follow up to optimize display. -
core-ci voted on patch set 16 V +1 10/29/25, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88030
-
Garvin Hicking voted on patch set 16 CR +1 V +1 10/29/25, 18:57
-
Garvin Hicking commented on patch set 16 10/29/25, 18:58
(voted under the assumption we'll have tests later and this is needed to proceed in the codesprint rather sooner than later. This is a good improvement IMO) -
Benni Mack voted on patch set 16 CR +2 V +2 10/30/25, 15:14
-
Benni Mack merged patch set 17 10/30/25, 15:14
-
Ayke Halder commented on patch set 17 10/31/25, 00:58
DatabaseRecordList.php:1930Should be `createLinkButton()` here, because it uses `->setHref()`.DatabaseRecordList.php:1953Should be `createLinkButton()` here, because it uses `->setHref()`.DatabaseRecordList.php:2067Should be `createLinkButton()` here, because it uses `->setHref()`.DatabaseRecordList.php:2083Should be `createLinkButton()` here, because it uses `->setHref()`.GenericButton.php:155This `GenericButton` has a default tag `$tag = 'button'`. There should not be any convenience function to set an `href` attribute in `GenericButton`. `LinkButton` is for `href` attribute buttons.GenericButton.php:155`GenericButton` has the tag `<button>` as default. There should not be any convenience functions for setting `href` attribute here. If a `href` attribute is needed, use `LinkButton` instead. -
Garvin Hicking commented on patch set 17 10/31/25, 07:53
DatabaseRecordList.php:1930ReplyWill check this. Do you want to make a follow-up patch or should I? Note that only the genericButton allows to set non-data attributes for now. And it can use `->setTag('a')` to adjust for being an anchor.GenericButton.php:155ReplyAcknowledgedGenericButton.php:155ReplyThe GenericButton allows to use any tag, so it needs a setHref/getHref. -
Garvin Hicking commented on patch set 17 10/31/25, 09:48
DatabaseRecordList.php:1930ReplyDatabaseRecordList.php:1953ReplyDoneDatabaseRecordList.php:2067ReplyDoneDatabaseRecordList.php:2083ReplyDone -
Simon Schaufelberger commented on patch set 17 06/18/26, 21:06
ModifyRecordListRecordActionsEvent.php:30Unresolved@typo3@kanti.de Why did you drop the table here? It was so convenient to directly access this information to only execute code for a specific table. Now I need to fetch the record, then the raw record and then the maintype i guess?