91291[!!!][FEATURE] Enhance page type `Link` to fully support typolinks
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Sven Liebert +1
-
Verified V +2 Done
- Georg Ringer +2
- Sven Liebert +1
- core-ci +1 CI
Issues 6
- Feature #17406Page type Shortcut with anchor points
- Feature #102129Integrate link wizard (linkhandler) for page type "shortcut"
- Feature #81379For a page_type "Shortcut" make it possible to link to specific content
- Feature #66218Linkhandler for Shortcut
- Feature #46138Allow for shortcuts to files (and content-elements?)
- Feature #38185when creating a link to a page, allow to select an intra-page target with the GUI
Files 56
- Build/tests/playwright/e2e/reports/reports-module.spec.ts+1 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php6+7 −43
- typo3/sysext/backend/Classes/Service/PageLinkMessageProvider.php7new+334 −0
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php+1 −1
- typo3/sysext/backend/Resources/Private/Language/pages/messages.xlfnew+45 −0
- typo3/sysext/backend/Resources/Private/Language/links.xlfnew+35 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf2+2 −2
- typo3/sysext/backend/Resources/Private/tsref.xml2+2 −2
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php10+180 −21
- typo3/sysext/core/Classes/Error/Http/LinkedPageNotResolvableException.phpnew+23 −0
- typo3/sysext/core/Classes/Exception/Page/CircularPageReferenceChainException.phpnew+28 −0
- typo3/sysext/core/Classes/Exception/Page/PageReferenceResolvingReachedIterationLimitException.phpnew+31 −0
- typo3/sysext/core/Classes/LinkHandling/PageTypeLinkResolver.php2new+108 −0
- typo3/sysext/core/Configuration/TCA/pages.php4+13 −12
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-17406-FieldUrlInTablePagesHasBeenRemoved.rst2new+88 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-17406-EnhancePageTypeLinkToFullySupportTypolinks.rstnew+42 −0
- typo3/sysext/core/Resources/Private/Language/db/pages/doktype.xlfnew+10 −0
- typo3/sysext/core/Resources/Private/Language/db/pages.xlf+11 −1
- typo3/sysext/core/Resources/Private/Language/locallang_general.xlf+1 −1
Show 36 more files
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizeNCopyPageWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizePageAddMonoglotHotelChildNCopyPageWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizePageNAddHotelChildWExclude.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizePageNAddHotelChildWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizePageNAddMonoglotHotelChildWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizePageWithSynchronizationAndCustomLocalizedHotel.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/localizePageWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularLocalize/Modify/DataSet/localizeNCopyPageWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularLocalize/Modify/DataSet/localizeNModifyNCopyPageWSynchronization.csv+2 −2
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php7+21 −36
- typo3/sysext/frontend/Classes/Page/PageAccessFailureReasons.php+2 −2
- typo3/sysext/frontend/Classes/Page/PageInformationFactory.php2+44 −15
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php6+91 −47
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+5 −2
- typo3/sysext/frontend/Tests/Functional/Middleware/Fixtures/pageLinkAndShortcutCases.csvnew+18 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/ShortcutAndMountPointRedirectTest.phpnew+88 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+8 −5
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/TypoLinkScenario.yaml+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+102 −39
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+3 −1
- typo3/sysext/info/Classes/Controller/PageInformationController.php+11 −3
- typo3/sysext/info/Configuration/page.tsconfig+1 −1
- typo3/sysext/info/Tests/Functional/Controller/PageInformationControllerTest.php+4 −4
- typo3/sysext/install/Classes/Updates/PageDoktypeLinkMigration.php4new+200 −0
- typo3/sysext/install/Tests/Functional/Fixtures/Extensions/test_pagelinkmigration_existingurlfield/Configuration/TCA/Overrides/pages.phpnew+18 −0
- typo3/sysext/install/Tests/Functional/Fixtures/Extensions/test_pagelinkmigration_existingurlfield/composer.jsonnew+14 −0
- typo3/sysext/install/Tests/Functional/Fixtures/Extensions/test_pagelinkmigration_existingurlfield/ext_emconf.phpnew+18 −0
- typo3/sysext/install/Tests/Functional/Updates/PageDoktypeLinkMigration/Fixtures/DroppedUrlField/dataset_import.csvnew+5 −0
- typo3/sysext/install/Tests/Functional/Updates/PageDoktypeLinkMigration/Fixtures/DroppedUrlField/dataset_migrated.csvnew+5 −0
- typo3/sysext/install/Tests/Functional/Updates/PageDoktypeLinkMigration/Fixtures/ExistingUrlField/dataset_import.csvnew+19 −0
- typo3/sysext/install/Tests/Functional/Updates/PageDoktypeLinkMigration/Fixtures/ExistingUrlField/dataset_migrated.csvnew+19 −0
- typo3/sysext/install/Tests/Functional/Updates/PageDoktypeLinkMigration/DroppedUrlFieldTest.phpnew+38 −0
- typo3/sysext/install/Tests/Functional/Updates/PageDoktypeLinkMigration/ExistingUrlFieldTest.phpnew+47 −0
- typo3/sysext/linkvalidator/Configuration/page.tsconfig+1 −1
- typo3/sysext/linkvalidator/Documentation/Configuration/Fields.rst+6 −2
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+3 −0
Review log 106157
Show 89132 earlier messages
-
Lina Wolf uploaded patch set 1 10/27/25, 19:19
-
Oli Bartsch commented on patch set 1 10/27/25, 19:25
-
core-ci voted on patch set 1 V -1 10/27/25, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87722
-
Lina Wolf uploaded patch set 2
V -110/27/25, 19:57 -
core-ci voted on patch set 2 V -1 10/27/25, 20:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87731
-
Lina Wolf uploaded patch set 3
V -110/27/25, 20:22 -
Lina Wolf uploaded patch set 4 10/27/25, 20:23
-
Lina Wolf commented on patch set 4 10/27/25, 20:25
pages.php:266ReplyDone -
Lina Wolf uploaded patch set 5 10/27/25, 20:29
-
Oli Bartsch commented on patch set 5 10/27/25, 20:37
pages.php:266ReplyThanks. We now would need an upgrade wizard, migrating existing doktype records to copy the link to the new field. -
core-ci voted on patch set 3 V -1 10/27/25, 20:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87736
-
core-ci voted on patch set 4 V -1 10/27/25, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87737
-
core-ci voted on patch set 5 V -1 10/27/25, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87741
-
Mathias Brodala commented on patch set 5 CR -1 10/28/25, 08:04
PageLayoutController.php:398I wonder if this could be changed to simply call resolvePageLink() and check if the resulting URL is empty. This way we need to know about this structural detail only once.PageLayoutController.php:404Since it's typolink now, it doesn't need to be a page link. It could also be mailto, file, an arbitrary record, etc. The naming should reflect that.PageLayoutController.php:407No external URL anymore, the naming should reflect that.locallang_layout.xlf:292This should keep saying "URL". The "target" can be interpreted as link "target" attribute.tsref.xml:3540> 3 (Link) and 4 (Shortcut) Let's make this clearer while we're at it.ShortcutAndMountPointRedirect.php:89Do we really need all this post-processing? Why not directly redirect to the URL?ShortcutAndMountPointRedirect.php:93It feels like we're repeating existing logic here.ShortcutAndMountPointRedirect.php:110Links to mail/phone may be valid. In navigation rendering definitely, on access depending on the context.PageLinkBuilder.php:213This should be moved after the following condition, otherwise it's stored pointlessly on error.PageLinkBuilder.php:215> on It's the link "on" this page. -
Lina Wolf uploaded patch set 6
CR -1V -110/28/25, 08:16 -
core-ci voted on patch set 6 V -1 10/28/25, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87766
-
Lina Wolf uploaded patch set 7
V -110/28/25, 08:42 -
Lina Wolf commented on patch set 7 10/28/25, 08:45
PageLayoutController.php:398ReplyDonePageLayoutController.php:404ReplyIt is a page of type link and it gets resolved.PageLayoutController.php:407ReplyDoneShortcutAndMountPointRedirect.php:89ReplyYes, as internal and external redirects receive different status codes and additional information, Compare how currently external link and shortcut handle redirectsShortcutAndMountPointRedirect.php:93ReplyWhere did you find the same logic?ShortcutAndMountPointRedirect.php:110ReplyOn menu rendering they are output, however, when you attemp to open the page directly you get a 404 just like you would with a SysfolderPageLinkBuilder.php:213ReplyI dont really get your comment? -
core-ci voted on patch set 7 V -1 10/28/25, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87768
-
Lina Wolf commented on patch set 7 10/28/25, 09:14
locallang_layout.xlf:292ReplyDonetsref.xml:3540ReplyDonePageLinkBuilder.php:215ReplyDone -
Lina Wolf uploaded patch set 8
V -110/28/25, 09:15 -
Lina Wolf uploaded patch set 9 10/28/25, 09:22
-
Lina Wolf commented on patch set 9 10/28/25, 09:24
pages.php:266ReplyDone -
Mathias Brodala commented on patch set 9 10/28/25, 09:34
PageLinkBuilder.php:213ReplyIf $url is empty then $linkResultType is not used anymore. So it should be set after the check instead. -
core-ci voted on patch set 8 V -1 10/28/25, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87776
-
core-ci voted on patch set 9 V -1 10/28/25, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87780
-
Lina Wolf uploaded patch set 10
V -110/28/25, 15:43 -
core-ci voted on patch set 10 V -1 10/28/25, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87854
-
Lina Wolf uploaded patch set 11
V -110/28/25, 16:06 -
Benni Mack commented on patch set 11 10/28/25, 16:13
I just bricked my system by building a simple loop over two pages pointing at each other now. Out of memory - PHP limit. -
Benni Mack commented on patch set 11 10/28/25, 16:15
Reply
If i create a link to one of these pages (e.g. in the menu) the page is also not stopping to be created. -
core-ci voted on patch set 11 V -1 10/28/25, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87858
-
Lina Wolf commented on patch set 11 10/28/25, 16:42
Reply
So the link page type has always been a "stupid" link, if you have linked to the page itself you would receive an infinite loop. Should we test this and to what level? Only for links of type page or also for external links that resolve to the current site? Or those that are forwarded via httaccess to my current site? There is like an almost infinitive possibility to create infinitive loops, no? -
Benni Mack commented on patch set 11 10/29/25, 08:11
Reply
we need to have a loop detection. doktype=shortcut has a loop detection of depth=20, I think that's be sufficient. -
Lina Wolf uploaded patch set 12
V -110/29/25, 09:04 -
Lina Wolf marked it work in progress 10/29/25, 09:08
-
core-ci voted on patch set 12 V +1 10/29/25, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87917
-
Lina Wolf commented on patch set 12 10/30/25, 07:12
This change is ready for review.PageLinkBuilder.php:213ReplyDone -
Lina Wolf marked it work in progress 10/30/25, 07:27
-
Lina Wolf uploaded patch set 13
V +110/30/25, 11:28 -
core-ci voted on patch set 13 V -1 10/30/25, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88120
-
Lina Wolf uploaded patch set 14
V -110/30/25, 12:59 -
Lina Wolf commented on patch set 14 10/30/25, 13:00
This change is ready for review.Reply
It is resolved, also when shortcuts link to page links and vice versaShortcutAndMountPointRedirect.php:93ReplyDone -
Lina Wolf commented on patch set 14 10/30/25, 13:00
Reply
Done -
core-ci voted on patch set 14 V -1 10/30/25, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88139
-
Lina Wolf uploaded patch set 15
V -110/30/25, 14:02 -
Mathias Brodala commented on patch set 15 10/30/25, 14:10
Just to be sure it's not forgotten: we need a Feature RST for this. Also is pages.url about to the deprecated with this? If yes, then we also need a Deprecation RST. -
Lina Wolf commented on patch set 15 10/30/25, 14:18
Reply
Yep if the tests ever pass I will make one.... -
core-ci voted on patch set 15 V -1 10/30/25, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88149
-
Lina Wolf uploaded patch set 16
V -110/30/25, 15:09 -
core-ci voted on patch set 16 V -1 10/30/25, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88159
-
Stefan Bürk commented on patch set 16 10/31/25, 08:24
Working on it ... -
Lina Wolf marked it work in progress 11/10/25, 12:09
-
Lina Wolf commented on patch set 16 11/10/25, 12:09
Working on it again -
Lina Wolf uploaded patch set 17
V -111/10/25, 12:21 -
core-ci voted on patch set 17 V -1 11/10/25, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88839
-
Lina Wolf uploaded patch set 18
V -111/11/25, 03:41 -
core-ci voted on patch set 18 V -1 11/11/25, 03:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88932
-
Lina Wolf rebased onto patch set 19
V -111/11/25, 04:10 -
core-ci voted on patch set 19 V -1 11/11/25, 04:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88936
-
Lina Wolf uploaded patch set 20
V -111/11/25, 18:17 -
Lina Wolf uploaded patch set 21 11/11/25, 18:20
-
core-ci voted on patch set 20 V -1 11/11/25, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89051
-
core-ci voted on patch set 21 V -1 11/11/25, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89052
-
Lina Wolf uploaded patch set 22
V -111/11/25, 19:51 -
core-ci voted on patch set 22 V -1 11/11/25, 20:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89066
-
Lina Wolf uploaded patch set 23
V -111/11/25, 20:16 -
core-ci voted on patch set 23 V -1 11/11/25, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89068
-
Lina Wolf uploaded patch set 24
V -111/11/25, 21:46 -
core-ci voted on patch set 24 V -1 11/11/25, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89084
-
Lina Wolf uploaded patch set 25
V -111/12/25, 11:30 -
core-ci voted on patch set 25 V +1 11/12/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89289
-
Lina Wolf uploaded patch set 26
V +111/12/25, 13:30 -
core-ci voted on patch set 26 V +1 11/12/25, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89324
-
Lina Wolf marked it ready for review 11/12/25, 13:40
-
Garvin Hicking commented on patch set 26 11/12/25, 15:08
Breaking-17406-FieldUrlInTablePagesHasBeenRemoved.rst:5when it's breaking we need a [!!!] commit message. also maybe add a commit message? -
Lina Wolf updated the commit message in patch set 27
V +111/12/25, 15:47 -
Lina Wolf commented on patch set 27 11/12/25, 15:47
Breaking-17406-FieldUrlInTablePagesHasBeenRemoved.rst:5ReplyDone -
core-ci voted on patch set 27 V +1 11/12/25, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89360
-
Simon Schaufelberger commented on patch set 27 11/17/25, 12:47
PageLinkMessageProvider.php:91I don't know if it makes much sense to make most of the stuff protected but these methods private. Either everything private or everything protected. What do you think?PageTypeLinkResolver.php:34these can be readonlyPageInformationFactory.php:78final -> private -
Francois Suter commented on patch set 27 CR -1 V -1 11/17/25, 21:03
This is a really cool feature and I'm all for it. About the code, I feel like there are very few comments and I wish there would be more, explaining the logic, the various conditions, etc. I know you can guess from the code, but I feel it's so much easier with an explanation. It makes the intent clear and the code easier to understand. About using the feature, it all went well, except when using a t3://record type of link. In the page layout module, the link type was not correctly detected and the message about the link being invalid was displayed. The link is resolved fine in the frontend. -
Lina Wolf uploaded patch set 28
CR -1V +111/17/25, 22:28 -
Lina Wolf commented on patch set 27 11/17/25, 22:30
Reply
Thanks for the feedback. I tried to add more comments, please have another look and tell me where you think more comments are missing. Thanks also for pointing out the record link.PageLinkMessageProvider.php:91ReplyDonePageTypeLinkResolver.php:34ReplyDonePageInformationFactory.php:78ReplyDone -
core-ci voted on patch set 28 V +1 11/17/25, 22:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89975
-
Lina Wolf marked it work in progress 11/18/25, 09:15
-
Lina Wolf commented on patch set 28 11/18/25, 09:15
Working on including message for records -
Lina Wolf uploaded patch set 29
V +111/18/25, 13:13 -
Lina Wolf commented on patch set 29 11/18/25, 13:14
This change is ready for review.Reply
I added handling for custom records -
core-ci voted on patch set 29 V +1 11/18/25, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90023
-
Francois Suter commented on patch set 29 11/18/25, 15:54
Thanks for this new version, with more comments and support for record-type links. I add a few minor comments in the code. However I have a more general question: it is possible to define custom link handlers. How does your code cope with that? Is the message about a "destination" kind of a default one (I have seen it when defining a telephone-type link)? Should we actually delegate to the link handlers the task of assembling the message for the page layout module? Or have an event for customising the message?PageLinkMessageProvider.php:83recordPageLinkMessageProvider.php:219What about having a specific message (indicating that it is a link to a record)? Right now, it's a bit confusing, because it says "Page of type "Link" links to the following page", but link is to edit some arbitrary record. I think the message should be more detailed like the one for when the record is not found. -
Stefan Bürk commented on patch set 29 CR -1 11/19/25, 02:52
(Working) on it ... -
Lina Wolf commented on patch set 29 11/19/25, 05:23
Reply
Custom link types resolve like any other typolink in the frontend. In the backend they use the default fallback message if they resolve in a backend context. I can introduce an event in a follow up to override the backend messagePageLinkMessageProvider.php:219ReplyAck, forgot about it -
Stefan Bürk commented on patch set 29 11/20/25, 12:31
Reply
Still on it ...PageRepository.php:1130This line is obsolete, `$doktype` is not used/passed. Can be removed.PageRepository.php:1180Throwing an extension ? Nice, Maria Kart in TYPO3 core 😄. I assume that `exception` was ment here. Going to fix that with next push.PageRepository.php:2167Public method should get some description for consumer (developers). Also let's move public methods more up.PageRepository.php:2170I guess we can streamline the method to use early returns, making the code flow a little bit smarter and avoids nesting if-else levels and structures.PageRepository.php:2191Currently, this exception is thrown in two different cases: * Cycling has been detected (page already in the chain) * Iteration limit reached without having the page already in the chain. That does only mean that chain is "huge" but does not necessarily mean that it **would** end up in a cycling chain if continued. I'd say we should have two dedicated exception for the different cases being on this here right now.CircularChainException.php:24This exception is thrown in case resolving referenced (page) records in a chain could not be resolved within given iterations (20 for core usage) and not related to Rootline, which are technically different things. Following that, this exception should not extend `RootlineException` as parent exception class. `PageNotFoundException` also extends the RootlineException which confuses me slightly. So we should either extend from `\RuntimeException` or `PageNotFoundException`. The latter would reflect that the referenced page could not be resolved (found) within 20 iterations looking into the reference chain. Need to think about it, and it is possible that I'm overseeing the technical reason basing this on `RootLineException`. Another point is the naming .. `CirularChain` is to generic and opens reusing it in the future for completly unrelated things breaking a concrete exception messaging. -
Stefan Bürk commented on patch set 29 11/20/25, 12:55
PageLinkMigration.php:28We should not add the upgrade wizard to EXT:install .. one upgrade wizard lesser to move in v14 ... -
Stefan Bürk commented on patch set 29 11/20/25, 14:07
PageLinkMigration.php:28ReplyKeeping it in EXT:install and move it with the other once when it is time. -
Stefan Bürk uploaded patch set 30
CR -1V +111/20/25, 16:22 -
Stefan Bürk voted on patch set 30 CR -1 11/20/25, 16:22
-
Lina Wolf marked it work in progress 11/20/25, 16:23
-
core-ci voted on patch set 30 V -1 11/20/25, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90315
-
Lina Wolf rebased onto patch set 31
CR -1V -111/20/25, 17:50 -
core-ci voted on patch set 31 V -1 11/20/25, 18:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90340
-
Lina Wolf uploaded patch set 32
V -111/20/25, 18:07 -
core-ci voted on patch set 32 V -1 11/20/25, 18:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90343
-
Lina Wolf uploaded patch set 33
V -111/20/25, 18:27 -
core-ci voted on patch set 33 V -1 11/20/25, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90344
-
Stefan Bürk uploaded patch set 34
V -111/21/25, 08:33 -
core-ci voted on patch set 34 V +1 11/21/25, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90456
-
Christian Kuhn commented on patch set 34 11/21/25, 09:45
This change is ready for review.PageLinkMigration.php:189we don't manage zzz_deleted_url: this does not exist from core PoV anymore. nowhere. and not in wizards, either. the upgrade deal is: add NEW fields, then run wizards. delete fields / rename-to-delete after that. -
Lina Wolf commented on patch set 34 11/21/25, 09:48
PageLinkMigration.php:189ReplyThis change was marked as WIP since it is not finished yet. I think you just accidently marked it for review? -
Lina Wolf marked it work in progress 11/21/25, 09:48
-
Stefan Bürk uploaded patch set 35
V +111/21/25, 10:22 -
core-ci voted on patch set 35 V +1 11/21/25, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90480
-
Stefan Bürk uploaded patch set 36
V +111/21/25, 11:04 -
core-ci voted on patch set 36 V -1 11/21/25, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90486
-
Stefan Bürk uploaded patch set 37
V -111/21/25, 13:23 -
core-ci voted on patch set 37 V +1 11/21/25, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90525
-
Stefan Bürk uploaded patch set 38
V +111/21/25, 16:14 -
core-ci voted on patch set 38 V -1 11/21/25, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90545
-
Stefan Bürk uploaded patch set 39
V -111/21/25, 16:39 -
Stefan Bürk commented on patch set 39 11/21/25, 16:42
PageLinkMessageProvider.php:83ReplyDonePageRepository.php:1130ReplyDonePageRepository.php:1180ReplyDonePageRepository.php:2170ReplyDonePageRepository.php:2191ReplySplitted into two exceptions and renamed the cycling one.CircularChainException.php:24ReplyExtended the exception (both) now from the PageNotFound instead of the rootline parent exception.PageLinkMigration.php:189Reply@lolli@schwarzbu.ch ack. Removed it and other stuff reducing the wizard. @112@linawolf.de For sure. Pressure, sleep absence, ... ;) -
core-ci voted on patch set 39 V +1 11/21/25, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90552
-
Lina Wolf commented on patch set 39 11/22/25, 05:47
Reply
Custom links produced by a link handler are displayed as external link both in the frontend and the backendPageLinkMessageProvider.php:219ReplyDone -
Lina Wolf rebased onto patch set 40
V +111/22/25, 11:59 -
core-ci voted on patch set 40 V -1 11/22/25, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90633
-
Stefan Bürk commented on patch set 40 11/22/25, 15:18
PageRepository.php:2167ReplyDone -
Stefan Bürk uploaded patch set 41
V -111/22/25, 15:19 -
core-ci voted on patch set 41 V -1 11/22/25, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90651
-
Stefan Bürk uploaded patch set 42
V -111/22/25, 16:54 -
core-ci voted on patch set 42 V +1 11/22/25, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90669
-
Stefan Bürk uploaded patch set 43
V +111/22/25, 18:28 -
core-ci voted on patch set 43 V +1 11/22/25, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90678
-
Stefan Bürk uploaded patch set 44
V +111/22/25, 20:12 -
core-ci voted on patch set 44 V -1 11/22/25, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90689
-
Stefan Bürk uploaded patch set 45
V -111/22/25, 21:04 -
core-ci voted on patch set 45 V +1 11/22/25, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90693
-
Stefan Bürk uploaded patch set 46
V +111/24/25, 10:53 -
core-ci voted on patch set 46 V -1 11/24/25, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90819
-
Simon Schaufelberger wrote 11/24/25, 11:07
Removed cc Simon Schaufelberger. -
Stefan Bürk uploaded patch set 47
V -111/24/25, 11:47 -
core-ci voted on patch set 47 V +1 11/24/25, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90825
-
Stefan Bürk uploaded patch set 48
V +111/24/25, 12:25 -
core-ci voted on patch set 48 V +1 11/24/25, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90832
-
Stefan Bürk uploaded patch set 49
V +111/24/25, 15:01 -
Stefan Bürk commented on patch set 49 11/24/25, 15:02
Reply
Done -
Stefan Bürk uploaded patch set 50 11/24/25, 15:09
-
core-ci voted on patch set 49 V +1 11/24/25, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90853
-
core-ci voted on patch set 50 V +1 11/24/25, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90854
-
Lina Wolf marked it ready for review 11/24/25, 15:20
-
Oli Bartsch commented on patch set 50 11/24/25, 15:46
PageDoktypeLinkMigration.php:53```suggestion return 'Migrate field "pages.url" to "pages.link" for pages of type Link.'; ```PageDoktypeLinkMigration.php:58```suggestion return 'Migrates "pages.url" to "pages.link", preserving former behaviour of the page type "External Link".'; ``` -
Stefan Bürk uploaded patch set 51
V +111/24/25, 15:54 -
Stefan Bürk commented on patch set 51 11/24/25, 15:55
PageDoktypeLinkMigration.php:53ReplyDonePageDoktypeLinkMigration.php:58ReplyDone -
core-ci voted on patch set 51 V +1 11/24/25, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90863
-
Sven Liebert voted on patch set 51 CR +1 V +1 11/24/25, 16:17
-
Georg Ringer voted on patch set 51 CR +1 V +1 11/24/25, 16:17
-
Georg Ringer voted on patch set 51 CR +2 V +2 11/24/25, 16:27
-
Georg Ringer merged patch set 52 11/24/25, 16:27
pages.php:266