Review main Merged

91293[BUGFIX] Render callout title markup only if title is not empty

Elias Häußler CR +2 V +2 Easy +1 −7 updated 11/13/25, 20:04

Commit message

Since the title is always a string, checking for NULL has no effect and
always fails unexpectedly. Instead, we now check for an empty string.
This avoids rendering the title markup with an empty title and
`margin-bottom`, avoiding the visual gap.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Torben Hansen +1

Issues 1

Files 2

Review log 710

  1. Elias Häußler uploaded patch set 1 10/27/25, 19:38

  2. core-ci voted on patch set 1 V -1 10/27/25, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87725

  3. Elias Häußler uploaded patch set 2 V -1 10/27/25, 19:55

  4. core-ci voted on patch set 2 V +1 10/27/25, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87730

  5. Elias Häußler uploaded patch set 3 V +1 11/13/25, 19:53

  6. Torben Hansen voted on patch set 3 CR +1 V +1 11/13/25, 19:55

  7. Oliver Hader voted on patch set 3 CR +1 V +1 11/13/25, 19:57

  8. Oliver Hader voted on patch set 3 CR +2 V +2 11/13/25, 19:59

  9. Oliver Hader merged patch set 4 11/13/25, 19:59

  10. core-ci voted on patch set 3 V +1 11/13/25, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89579