91294[!!!][FEATURE] Autoconfigure backend avatar providers
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Lina Wolf +1
-
Verified V +2 Done
- Christian Kuhn +2
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 10
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/backend/Classes/Attribute/AsAvatarProvider.phpnew+38 −0
- typo3/sysext/backend/Classes/Backend/Avatar/Avatar.php+14 −32
- typo3/sysext/backend/Classes/Backend/Avatar/DefaultAvatarProvider.php+2 −0
- typo3/sysext/backend/Classes/DependencyInjection/AvatarProviderPass.phpnew+65 −0
- typo3/sysext/backend/Configuration/Services.php+16 −0
- typo3/sysext/backend/ext_localconf.php+0 −5
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-107871-RemoveBackendAvatarProviderRegistrationViaGLOBALS.rst2new+73 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107871-AutoconfigureBackendAvatarProviders.rst2new+52 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+6 −0
Review log 2633
Show 48 earlier messages
-
Elias Häußler uploaded patch set 1 10/27/25, 19:43
-
Elias Häußler uploaded patch set 2 10/27/25, 19:48
-
core-ci voted on patch set 1 V -1 10/27/25, 19:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87726
-
Elias Häußler uploaded patch set 3 10/27/25, 19:54
-
core-ci voted on patch set 2 V -1 10/27/25, 20:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87727
-
core-ci voted on patch set 3 V +1 10/27/25, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87728
-
Elias Häußler uploaded patch set 4
V +110/27/25, 20:47 -
core-ci voted on patch set 4 V +1 10/27/25, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87743
-
Elias Häußler marked it ready for review 10/27/25, 21:09
-
Elias Häußler uploaded patch set 5
V +111/06/25, 08:38 -
core-ci voted on patch set 5 V +1 11/06/25, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88557
-
Lina Wolf commented on patch set 5 CR +1 V +1 11/07/25, 12:37
Tested with a custom AvatorProvider in extension t3docs/examples -
Josua Vogel voted on patch set 5 CR +1 V +1 11/07/25, 22:04
-
Georg Ringer voted on patch set 5 CR +1 V +1 11/08/25, 08:03
-
Simon Schaufelberger commented on patch set 5 11/08/25, 09:13
is it possible to inject all classes implementing the interface instead of manually tagging them? then of course without any before or after configuration -
Elias Häußler commented on patch set 5 11/10/25, 08:54
Reply
What's your intention here? AFAIK it's not easily possible without tagging. -
Simon Schaufelberger commented on patch set 5 11/10/25, 09:12
Reply
less configuration, more magic. -
Simon Schaufelberger commented on patch set 5 11/10/25, 09:22
Reply
Done -
Lina Wolf commented on patch set 5 11/10/25, 09:26
Reply
I think this is such a rare use case that no magic is required. -
Elias Häußler uploaded patch set 6
CR +1V +111/18/25, 13:37 -
Elias Häußler commented on patch set 6 11/18/25, 13:42
Reply
Done -
core-ci voted on patch set 6 V +1 11/18/25, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90028
-
Georg Ringer voted on patch set 6 CR +1 V +1 11/18/25, 20:18
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 11/18/25, 21:39
-
Lina Wolf voted on patch set 6 CR +1 V +1 11/19/25, 12:43
-
Oli Bartsch commented on patch set 6 CR -1 11/19/25, 21:16
Breaking-107871-RemoveBackendAvatarProviderRegistrationViaGLOBALS.rst:18This is not true, autoconfiguration happens based on the AsAvatarProvider tag.Feature-107871-AutoconfigureBackendAvatarProviders.rst:15This is not true, autoconfiguration happens based on the AsAvatarProvider tag. The interface is only validated in the registry. -
Lina Wolf commented on patch set 6 CR -1 11/20/25, 11:00
Working on it -
Lina Wolf uploaded patch set 7
CR +1V +111/20/25, 11:11 -
Lina Wolf commented on patch set 7 CR +1 V +1 11/20/25, 11:11
Fixed the mistakes and did a general review of the changelog entries.Breaking-107871-RemoveBackendAvatarProviderRegistrationViaGLOBALS.rst:18ReplyDoneFeature-107871-AutoconfigureBackendAvatarProviders.rst:15ReplyDone -
core-ci voted on patch set 7 V +1 11/20/25, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90265
-
Christian Kuhn voted on patch set 7 CR +1 V +1 11/20/25, 11:25
-
Christian Kuhn voted on patch set 7 CR +2 V +2 11/20/25, 11:55
-
Christian Kuhn merged patch set 8 11/20/25, 11:55