91295[FEATURE] Add Username and creation date to redirects
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107755-AddCreationInformationForRedirects.rstnew+40 −0
- typo3/sysext/redirects/Classes/Form/Element/RenderCreationInformation.php16new+84 −0
- typo3/sysext/redirects/Classes/Hooks/DataHandlerSlugUpdateHook.php+6 −1
- typo3/sysext/redirects/Classes/Service/SlugService.php2+1 −0
- typo3/sysext/redirects/Configuration/TCA/sys_redirect.php+11 −2
- typo3/sysext/redirects/Resources/Private/Language/locallang.xlf+6 −0
- typo3/sysext/redirects/Resources/Private/Language/locallang_db.xlf2+3 −0
- typo3/sysext/redirects/ext_localconf.php+7 −0
- typo3/sysext/redirects/ext_tables.sql3+1 −0
Review log 2431
Show 46 earlier messages
-
Regis TEDONE uploaded patch set 1 10/27/25, 20:04
-
core-ci voted on patch set 1 V -1 10/27/25, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87733
-
Benni Mack uploaded patch set 2
V -110/27/25, 20:49 -
Benni Mack voted on patch set 2 CR +1 V +1 10/27/25, 20:49
-
core-ci voted on patch set 2 V +1 10/27/25, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87744
-
Oli Bartsch commented on patch set 2 CR -1 10/27/25, 21:23
RenderCreationInformation.php:71Please do not use such inline styles.RenderCreationInformation.php:94Could we use existing functionality here? It is also technically not usual to have database queries in a display related service directly.CreatedByDefaultProvider.php:26Why do we need this when we have the DH hook in place?locallang_db.xlf:129This label is not related to tca while based on the identifier it looks as it wouldext_tables.sql:4Why do we define this here?
-
Benni Mack uploaded patch set 3
CR +1V +110/27/25, 21:35 -
Benni Mack commented on patch set 3 10/27/25, 21:36
RenderCreationInformation.php:26ReplyDoneRenderCreationInformation.php:71ReplyDoneRenderCreationInformation.php:94ReplyDonelocallang_db.xlf:129ReplyDoneext_tables.sql:4Replybecause the TCA type is type=passthrough -
Benni Mack commented on patch set 3 10/27/25, 21:36
CreatedByDefaultProvider.php:26ReplyDone -
core-ci voted on patch set 3 V -1 10/27/25, 21:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87748
-
Oli Bartsch commented on patch set 3 10/27/25, 21:45
RenderCreationInformation.php:40This makes no sense. Now for every redirect which does not have this field set (which is every record as this field is new), the creator is the current user.. -
Benni Mack uploaded patch set 4
V -110/28/25, 06:51 -
Benni Mack commented on patch set 4 10/28/25, 06:55
RenderCreationInformation.php:40ReplyDone -
core-ci voted on patch set 4 V -1 10/28/25, 06:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87761
-
Oli Bartsch commented on patch set 4 10/28/25, 07:26
RenderCreationInformation.php:40ReplyIssue is still not resolved because `getBackendUserById` returns the current user for missing createdby field. -
Regis TEDONE uploaded patch set 5
V -110/28/25, 10:57 -
core-ci voted on patch set 5 V -1 10/28/25, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87798
-
Stefan Bürk commented on patch set 5 10/29/25, 09:56
So, this a single place "revert" of the `Remove TCA option "cruser_id"` [1]. Having it in the table makes it easier to get it (lateron) and is also more concrete than looking it up in the `sys_history` which may have been cleaned/shrinked and creator "removed" from the history chain. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/75123SlugService.php:152```suggestion 'createdby' => $this->context->getPropertyFromAspect('backend.user', 'id'),, ``` Let's avoid the global beuser access here. IMO taken from the `cruser_id` removal https://review.typo3.org/c/Packages/TYPO3.CMS/+/75123/12/typo3/sysext/redirects/Classes/Service/SlugService.php#b191 -
Stefan Bürk commented on patch set 5 10/29/25, 09:59
Reply
Just wanted to mention this. Fine with adding the field ... not sure about data privacy concerns. -
Stefan Bürk commented on patch set 5 10/29/25, 10:02
RenderCreationInformation.php:40ReplyYeah ... the "current user" fallback is suboptimal. Could we not use something generic (system) or (unknown) to be rendered instead ? -
Stefan Bürk commented on patch set 5 CR -1 10/29/25, 10:10
On it ... I'll take care of the comments. -
Stefan Bürk commented on patch set 5 10/29/25, 14:37
Reply
Still on it ..RenderCreationInformation.php:45* `datetime` does not exists. Should be `date`. * We could reuse the context to retrieve the current backenduser id instead of using the default.RenderCreationInformation.php:52We can inline `BU::getRecord()` here again as `$userId === 0` is already checked together early return (skip) done above. In case no record could be loaded we should also do the skip. -
Stefan Bürk uploaded patch set 6
CR -1V -110/29/25, 14:58 -
Stefan Bürk commented on patch set 6 10/29/25, 14:59
Reply
DoneRenderCreationInformation.php:40Reply@bo@cedev.de adjusted the implementation and I would say it works better now. Can you have a look again if it now works out for you ?RenderCreationInformation.php:45ReplyDoneRenderCreationInformation.php:52ReplyDoneSlugService.php:152ReplyDone -
Stefan Bürk voted on patch set 6 CR +1 V +1 10/29/25, 15:10
-
core-ci voted on patch set 6 V +1 10/29/25, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87996
-
Oli Bartsch uploaded patch set 7
CR +1V +110/29/25, 20:02 -
Oli Bartsch commented on patch set 7 CR +1 V +1 10/29/25, 20:02
RenderCreationInformation.php:40ReplyDoneext_tables.sql:4ReplyDone -
core-ci voted on patch set 7 V +1 10/29/25, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88041
-
Benni Mack voted on patch set 7 CR +2 V +2 10/29/25, 21:44
-
Benni Mack merged patch set 8 10/29/25, 21:44
RenderCreationInformation.php:26