Review main Merged

91301[BUGFIX] Fix ESC key handling in Install Tool modal

Michael Binder CR +2 V +2 Easy +14 −10 updated 10/28/25, 11:31

Commit message

Clear the search field with ESC, if it is filled.
If it is not filled, close the modal with ESC.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Michael Binder uploaded patch set 1 10/28/25, 08:52

  2. core-ci voted on patch set 1 V +1 10/28/25, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87770

  3. Michael Binder updated the commit message in patch set 2 V +1 10/28/25, 09:39

  4. core-ci voted on patch set 2 V +1 10/28/25, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87784

  5. Jochen Roth voted on patch set 2 CR +1 V +1 10/28/25, 09:56

  6. Benni Mack voted on patch set 2 CR +2 V +2 10/28/25, 11:10

  7. Benni Mack merged patch set 3 10/28/25, 11:10

  8. Benjamin Franzke commented on patch set 3 10/28/25, 11:31

    Please also see > 91259: [BUGFIX] Fix Escape handling in <dialog> iframes | https://review.typo3.org/c/Packages/TYPO3.CMS/+/91259 …which solves Escape + search in a generic way