Review main Merged

91311[BUGFIX] Avoid performance bottleneck in system information toolbar

Benjamin Franzke CR +2 V +2 Easy +17 −7 updated 10/31/25, 05:21

Commit message

The system information toolbar renders the entire backend in the toolbar
dropdown, if logged out in another tab, because the request to the
information refresh route is redirected to the login page (and once
logged back in, to the main backend controller).

Once the main backend controller is inserted (e.g. after relogin in
another tab), a nested system information toolbar will be updated
to contain the backend again and again and again, resulting in
exponential growth, which can lead to 10GB of RAM usage and
4 million DOM nodes over time, making the entire backend unresponsive.

To circumvent this issue, we're now instruction `fetch()` to avoid
following redirects, which means we can detect that a redirect
would have performed and ignore the request result instead of
inserting invalid markup.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Benjamin Franzke uploaded patch set 1 10/28/25, 14:24

  2. Benjamin Franzke commented on patch set 1 10/28/25, 14:28

    This is no annoying that I can't believe it hasn't been reported yet, but I couldn't find a ticket. Maybe some of our bug scraper has seen a similar report?
  3. core-ci voted on patch set 1 V +1 10/28/25, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87836

  4. Benjamin Franzke uploaded patch set 2 V +1 10/28/25, 19:56

  5. Benjamin Franzke uploaded patch set 3 10/28/25, 20:01

  6. Benjamin Franzke commented on patch set 3 10/28/25, 20:01

    Reply

    Haven't found anything so far, so I created a new ticket.
  7. core-ci voted on patch set 2 V +1 10/28/25, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87879

  8. core-ci voted on patch set 3 V +1 10/28/25, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87880

  9. Benjamin Kott voted on patch set 3 CR +1 V +1 10/29/25, 13:34

  10. Georg Ringer voted on patch set 3 CR +1 V +1 10/31/25, 03:30

  11. Benjamin Franzke voted on patch set 3 CR +2 V +2 10/31/25, 05:06

  12. Benjamin Franzke merged patch set 4 10/31/25, 05:21