91312[BUGFIX] Fix duplicate cache-control headers
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2531
Show 56 earlier messages
-
Peter Kraume uploaded patch set 1 10/28/25, 15:18
-
core-ci voted on patch set 1 V +1 10/28/25, 15:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87852
-
Mathias Brodala commented on patch set 1 10/29/25, 07:40
root-htaccess:178You need to use tabs here. -
Peter Kraume uploaded patch set 2
V +111/11/25, 11:14 -
Peter Kraume commented on patch set 2 11/11/25, 11:18
root-htaccess:178ReplyDone -
Peter Kraume commented on patch set 2 11/11/25, 11:18
root-htaccess:176ReplyI'll check that.
-
core-ci voted on patch set 2 V +1 11/11/25, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88986
-
Peter Kraume uploaded patch set 3
V +111/11/25, 15:00 -
Peter Kraume commented on patch set 3 11/11/25, 15:06
root-htaccess:176ReplyDone -
core-ci voted on patch set 3 V -1 11/11/25, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89021
-
Marcus Schwemer voted on patch set 3 CR +1 V +1 11/11/25, 15:23
-
Marcus Schwemer voted on patch set 3 CR 0 V 0 11/11/25, 15:40
-
Peter Kraume uploaded patch set 4
V -111/11/25, 15:47 -
Peter Kraume uploaded patch set 5 11/11/25, 15:53
-
core-ci voted on patch set 4 V +1 11/11/25, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89031
-
Marcus Schwemer voted on patch set 5 CR +1 V +1 11/11/25, 15:57
-
core-ci voted on patch set 5 V +1 11/11/25, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89034
-
Stefan Bürk commented on patch set 5 11/11/25, 20:44
Looks like working so far. I'm not a nginx user, so no glue if that may also occure on a pure nginx webserver with communicated config or not ... would be nice if some nginx user may can elaborate on that - and if we possibly need to add a important rst to notify them too (in case they are hit) ? Also nice to know is the fact that this change only targets for new setups ... and not changing existing root .htaccess files ... should we alone add a important restfile for apache2 users to make them aware that they need to check and possibly need to change there project .htaccess files ? What do you think ? -
Marcus Schwemer commented on patch set 5 11/12/25, 18:18
Reply
Just tested it, with a plain ddev installation. There is only one cache header as expected. Since we do not deliver a default configuration for nginx, it's up to the admins, to configure it correctly. There is an example configuration for nginx in the docs: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/Administration/Installation/SystemRequirements/Index.html#nginx-web-server-configuration. This is the same as the ddev config (slightly other notation). DDEV additionally support the backend entrypoint rewriting. So there is nothing to do IMHO. As we are talking about webservers, what about IIS? There we deliver a web-config. Does anybody know about these? -
Peter Kraume commented on patch set 5 01/09/26, 08:41
So how can we continue with this patch? -
Peter Kraume rebased onto patch set 6
CR +1V +101/23/26, 00:51 -
Stefan Bürk commented on patch set 6 01/23/26, 00:53
Reply
Done -
core-ci voted on patch set 6 V +1 01/23/26, 00:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94110
-
Peter Kraume commented on patch set 6 01/23/26, 06:08
Reply
Thx for the rebase. But what I meant was how to get this patch finally reviewed. Whom to ask? I already posted in #cms-core-dev but with no response. -
Garvin Hicking commented on patch set 6 CR +1 V +1 01/23/26, 20:49
Voting, because I think this improves the situation for new setups. I think it does depend a bit on whether mod_php or (f)cgi is utilized for apache+php, and might also affect what happens when "virtual" URIs (routed through index.php) set CSS or XML/RSS headers (like sitemap generation), which probably also would be overridden by ExpiresByType. -
Stefan Bürk commented on patch set 6 CR -1 01/24/26, 01:09
Looking into it again ... -
Benni Mack commented on patch set 6 CR +1 V +1 02/25/26, 09:45
Reply
Let me know when you're done... I had this problem as well in an apache env -
Stefan Bürk voted on patch set 6 CR 0 02/25/26, 20:30
-
Stefan Bürk commented on patch set 6 CR +1 V +1 02/25/26, 20:30
Reply
Done -
Benni Mack voted on patch set 6 CR +2 V +2 02/25/26, 20:53
-
Benni Mack merged patch set 7 02/25/26, 20:54
root-htaccess:176