Review main Merged

91314[TASK] Free table tx_extensionmanager_domain_model_extension from TCA

Michael Binder CR +2 V +2 Expert +439 −848 updated 10/30/25, 11:27

Commit message

This change removes TCA from
"tx_extensionmanager_domain_model_extension" in order to
use native SQL over Doctrine ORM for such lowlevel jobs.

Extbase Persistence is not in use anymore,
DataMapping and Hydration is statically built.

A minor change in the listing is also adapted to make the
table of remote extensions look nicer.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 3346

Show 1221 earlier messages
  1. Michael Binder uploaded patch set 1 10/28/25, 16:23

  2. core-ci voted on patch set 1 V -1 10/28/25, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87862

  3. Benni Mack commented on patch set 1 10/29/25, 06:59

    ExtensionRepository.php:36

    lets go over the annotations and native PHP types and return types in the final phase of this patch.
  4. Michael Binder uploaded patch set 2 V -1 10/29/25, 11:03

  5. core-ci voted on patch set 2 V -1 10/29/25, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87944

  6. Michael Binder uploaded patch set 3 V -1 10/29/25, 14:13

  7. core-ci voted on patch set 3 V -1 10/29/25, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87982

  8. Michael Binder uploaded patch set 4 V -1 10/29/25, 14:47

  9. Michael Binder uploaded patch set 5 10/29/25, 15:12

  10. Michael Binder commented on patch set 5 10/29/25, 15:19

    This change is ready for review.
  11. Benni Mack commented on patch set 6 10/29/25, 17:04

    Published edit on patch set 5.
  12. core-ci voted on patch set 4 V -1 10/29/25, 17:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87992

  13. core-ci voted on patch set 5 V -1 10/29/25, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87999

  14. core-ci voted on patch set 6 V -1 10/29/25, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88012

  15. Benni Mack uploaded patch set 7 V -1 10/29/25, 18:29

  16. core-ci voted on patch set 7 V -1 10/29/25, 18:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88029

  17. Benni Mack uploaded patch set 8 V -1 10/29/25, 19:22

  18. Benni Mack commented on patch set 8 10/29/25, 19:24

    ExtensionRepository.php:36 Reply

    Done
  19. core-ci voted on patch set 8 V -1 10/29/25, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88033

  20. Benni Mack uploaded patch set 9 V -1 10/29/25, 21:02

  21. core-ci voted on patch set 9 V +1 10/29/25, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88051

  1. Benni Mack uploaded patch set 10 V +1 10/29/25, 21:31

  2. Benni Mack voted on patch set 10 CR +1 V +1 10/29/25, 21:31

  3. core-ci voted on patch set 10 V +1 10/29/25, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88056

  4. Benni Mack commented on patch set 10 CR -1 10/29/25, 21:41

    we need to check if we can remove the labels.
  5. Michael Binder uploaded patch set 11 CR -1 V +1 10/29/25, 21:46

  6. Benni Mack voted on patch set 11 CR +1 V +1 10/29/25, 21:48

  7. core-ci voted on patch set 11 V +1 10/29/25, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88057

  8. Oli Bartsch commented on patch set 11 CR -1 10/29/25, 22:24

    will check tomorrow morning.

    _extensionmanager.scss:48

    Why do we need those changes?
  9. Benni Mack commented on patch set 11 10/29/25, 23:22

    _extensionmanager.scss:48 Reply

    see commit message: A minor change in the listing is also adapted to make the table of remote extensions look nicer.
  10. Simon Schaufelberger commented on patch set 11 10/30/25, 01:06

    ExtensionRepository.php:101

    can this mapping only be done for the paginated result instead of all?
  11. Benni Mack commented on patch set 11 10/30/25, 07:56

    ExtensionRepository.php:101 Reply

    no, as we don't have a paginated queryinterface anymore
  12. Nikita Hovratov commented on patch set 11 10/30/25, 07:58

    Extension.php:66

    array $row
  13. Michael Binder commented on patch set 11 10/30/25, 08:16

    Reply

    removed the locallang_db.xlf
  14. Christian Kuhn commented on patch set 11 10/30/25, 09:02

    Extension.php:27

    this can be removed i hope and suppose?
  15. Christian Kuhn commented on patch set 11 CR -1 10/30/25, 09:09

    working on it. will push.
  16. Christian Kuhn commented on patch set 11 10/30/25, 09:45

    i think the model could be turned into a readonly DO after some further iterations with other patches.

    Extension.php:27 Reply

    Done

    Extension.php:61

    obsolete, right?

    Extension.php:66 Reply

    Done

    ExtensionRepository.php:101 Reply

    Done
  17. Christian Kuhn commented on patch set 11 10/30/25, 09:45

    Reply

    Done
  18. Christian Kuhn uploaded patch set 12 CR +1 V +1 10/30/25, 09:48

  19. core-ci voted on patch set 12 V +1 10/30/25, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88100

  20. Christian Kuhn voted on patch set 12 CR +1 V +1 10/30/25, 09:57

  21. Michael Binder uploaded patch set 13 CR +1 V +1 10/30/25, 10:10

  22. core-ci voted on patch set 13 V +1 10/30/25, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88105

  23. Christian Kuhn voted on patch set 13 CR +1 V +1 10/30/25, 10:53

  24. Benni Mack voted on patch set 13 CR +2 V +2 10/30/25, 11:27

  25. Benni Mack merged patch set 14 10/30/25, 11:27